Deprecate --gfe2_reloadable_flag_quic_limit_encoder_stream_buffering. PiperOrigin-RevId: 432979519
diff --git a/quic/core/qpack/qpack_encoder.cc b/quic/core/qpack/qpack_encoder.cc index 974f7b2..8037542 100644 --- a/quic/core/qpack/qpack_encoder.cc +++ b/quic/core/qpack/qpack_encoder.cc
@@ -13,8 +13,6 @@ #include "quic/core/qpack/qpack_instruction_encoder.h" #include "quic/core/qpack/qpack_required_insert_count.h" #include "quic/core/qpack/value_splitting_header_list.h" -#include "quic/platform/api/quic_flag_utils.h" -#include "quic/platform/api/quic_flags.h" #include "quic/platform/api/quic_logging.h" namespace quic { @@ -87,11 +85,7 @@ const QuicByteCount initial_encoder_stream_buffered_byte_count = encoder_stream_sender_.BufferedByteCount(); - bool can_write_to_encoder_stream = true; - if (GetQuicReloadableFlag(quic_limit_encoder_stream_buffering)) { - QUIC_RELOADABLE_FLAG_COUNT(quic_limit_encoder_stream_buffering); - can_write_to_encoder_stream = encoder_stream_sender_.CanWrite(); - } + const bool can_write_to_encoder_stream = encoder_stream_sender_.CanWrite(); Representations representations; representations.reserve(header_list.size());
diff --git a/quic/core/qpack/qpack_encoder_test.cc b/quic/core/qpack/qpack_encoder_test.cc index 30f578e..7f75f97 100644 --- a/quic/core/qpack/qpack_encoder_test.cc +++ b/quic/core/qpack/qpack_encoder_test.cc
@@ -10,7 +10,6 @@ #include "absl/strings/escaping.h" #include "absl/strings/str_cat.h" #include "absl/strings/string_view.h" -#include "quic/platform/api/quic_flags.h" #include "quic/platform/api/quic_test.h" #include "quic/test_tools/qpack/qpack_encoder_peer.h" #include "quic/test_tools/qpack/qpack_encoder_test_utils.h" @@ -499,10 +498,6 @@ } TEST_F(QpackEncoderTest, EncoderStreamWritesDisallowedThenAllowed) { - if (!GetQuicReloadableFlag(quic_limit_encoder_stream_buffering)) { - return; - } - EXPECT_CALL(encoder_stream_sender_delegate_, NumBytesBuffered()) .WillRepeatedly(Return(kTooManyBytesBuffered)); encoder_.SetMaximumBlockedStreams(1); @@ -564,10 +559,6 @@ } TEST_F(QpackEncoderTest, EncoderStreamWritesAllowedThenDisallowed) { - if (!GetQuicReloadableFlag(quic_limit_encoder_stream_buffering)) { - return; - } - EXPECT_CALL(encoder_stream_sender_delegate_, NumBytesBuffered()) .WillRepeatedly(Return(0)); encoder_.SetMaximumBlockedStreams(1);
diff --git a/quic/core/quic_flags_list.h b/quic/core/quic_flags_list.h index 90cd7c4..6e3ce64 100644 --- a/quic/core/quic_flags_list.h +++ b/quic/core/quic_flags_list.h
@@ -27,8 +27,6 @@ QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_use_lower_min_for_trusted_irtt, false) // If true, QUIC will default enable MTU discovery at server, with a target of 1450 bytes. QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_enable_mtu_discovery_at_server, false) -// If true, QpackEncoder will stop emitting instructions on the encoder stream if amount of buffered data exceeds a hardcoded limit. -QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_limit_encoder_stream_buffering, true) // If true, QuicGsoBatchWriter will support release time if it is available and the process has the permission to do so. QUIC_FLAG(FLAGS_quic_restart_flag_quic_support_release_time_for_gso, false) // If true, TlsServerHandshaker will be able to 1) request client cert, and 2) verify the client cert in the virtual method TlsServerHandshaker::VerifyCertChain.