Fix 1 ClangTidyReadability finding:
* function 'ClientFullyConnected' has inline specifier but is implicitly inlined. For more info, see go/clang_tidy/checks/readability-redundant-inline-specifier
This CL looks good? Just grant approval!
This CL doesn’t look good? This is what you can do:
* Revert this CL, by replying "REVERT: <provide reason>"
* File a bug under go/clang-tidy-bug for category ClangTidyReadability if there's an issue with the CL content.
* File a bug under go/rosie-bug if there's an issue with how the CL was managed.
* For all other issues such as the formatting of the CL, please file a bug under
go/clrobot-bug.
* Revert this CL and not get a CL that cleans up these paths in the future by
replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to
opt out the respective paths in your CL Robot configuration instead:
go/clrobot-opt-out.
This CL was generated by CL Robot - a tool that cleans up code findings
(go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/third_party/quiche/METADATA.common which is reachable following include_presubmits from //depot/google3/third_party/quic/METADATA by
following go/clrobot#how-to-opt-in. Anything wrong with the signup? File a bug
at go/clrobot-bug.
#clrobot #readability-redundant-inline-specifier
Tested:
Local presubmit tests passed.
PiperOrigin-RevId: 923780106
diff --git a/quiche/quic/moqt/tools/moqt_relay_test.cc b/quiche/quic/moqt/tools/moqt_relay_test.cc
index 1f677bc..0153629 100644
--- a/quiche/quic/moqt/tools/moqt_relay_test.cc
+++ b/quiche/quic/moqt/tools/moqt_relay_test.cc
@@ -81,7 +81,7 @@
RunUntilConnected(downstream_, relay_);
}
- inline bool ClientFullyConnected(TestMoqtRelay& client) {
+ bool ClientFullyConnected(TestMoqtRelay& client) {
return client.publisher()->GetDefaultUpstreamSession().IsValid() &&
client.publisher()->GetDefaultUpstreamSession().GetIfAvailable() ==
client.client_session();
