commit e12ee33ab1f3aa31066e713c0b90b6bd93fe7980
author wub <wub@google.com> Wed Sep 21 10:28:28 2022 -0700
committer Copybara-Service <copybara-worker@google.com> Wed Sep 21 10:30:40 2022 -0700
tree 6b75ff3d27dc39676ca6f34dcd3a61e594997a36
parent e736c4167d4ce3f63482b56379e611aa2534ed0f

Change quic::CryptoUtils::GetSSLCapabilities to use ScopedCBB instead of CBB. This can avoid a memleak if SSL_serialize_capabilities fails.

PiperOrigin-RevId: 475863497

quiche/quic/core/crypto/crypto_utils.cc

diff --git a/quiche/quic/core/crypto/crypto_utils.cc b/quiche/quic/core/crypto/crypto_utils.cc
index 9b33b0b..428edb7 100644
--- a/quiche/quic/core/crypto/crypto_utils.cc
+++ b/quiche/quic/core/crypto/crypto_utils.cc
@@ -776,10 +776,11 @@
                                      bssl::UniquePtr<uint8_t>* capabilities,
                                      size_t* capabilities_len) {
   uint8_t* buffer;
-  CBB cbb;
+  bssl::ScopedCBB cbb;
 
-  if (!CBB_init(&cbb, 128) || !SSL_serialize_capabilities(ssl, &cbb) ||
-      !CBB_finish(&cbb, &buffer, capabilities_len)) {
+  if (!CBB_init(cbb.get(), 128) ||
+      !SSL_serialize_capabilities(ssl, cbb.get()) ||
+      !CBB_finish(cbb.get(), &buffer, capabilities_len)) {
     return false;
   }