Remove QuicHeaderList::max_header_list_size(). The QuicHeaderList object in the affected methods originates from QuicSpdySession::SpdyFramerVisitor. Its |max_header_list_size_| has been set in QuicSpdySession::SpdyFramerVisitor::set_max_header_list_size(), called from QuicSpdySession::Initialize() with the value of |max_inbound_header_list_size_|. This value can be directly accessed instead. This is in preparation to remove header size limit enforcement from QuicHeaderList altogether. gfe-relnote: n/a, no functional change. PiperOrigin-RevId: 286383519 Change-Id: If08f23e05f08f90a7358168f7741a8e805a1614f
diff --git a/quic/core/http/quic_header_list.h b/quic/core/http/quic_header_list.h index c019ceb..fe62f51 100644 --- a/quic/core/http/quic_header_list.h +++ b/quic/core/http/quic_header_list.h
@@ -52,10 +52,13 @@ } size_t compressed_header_bytes() const { return compressed_header_bytes_; } + // Deprecated. TODO(b/145909215): remove. void set_max_header_list_size(size_t max_header_list_size) { max_header_list_size_ = max_header_list_size; } + // Deprecated. TODO(b/145909215): remove when deprecating + // FLAGS_gfe2_reloadable_flag_quic_use_session_max_inbound_header_list_size. size_t max_header_list_size() const { return max_header_list_size_; } std::string DebugString() const;
diff --git a/quic/core/http/quic_spdy_stream.h b/quic/core/http/quic_spdy_stream.h index 9650744..419b88f 100644 --- a/quic/core/http/quic_spdy_stream.h +++ b/quic/core/http/quic_spdy_stream.h
@@ -219,6 +219,8 @@ bool header_list_size_limit_exceeded) override; void OnHeaderDecodingError(quiche::QuicheStringPiece error_message) override; + QuicSpdySession* spdy_session() const { return spdy_session_; } + protected: // Called when the received headers are too large. By default this will // reset the stream. @@ -235,7 +237,6 @@ bool fin, QuicReferenceCountedPointer<QuicAckListenerInterface> ack_listener); - QuicSpdySession* spdy_session() const { return spdy_session_; } Visitor* visitor() { return visitor_; } void set_headers_decompressed(bool val) { headers_decompressed_ = val; }