Extract the FakeProofVerifier from quic_client_bin.cc to facilitate sharing with Chromium. gfe-relnote: n/a - Tools only PiperOrigin-RevId: 248432782 Change-Id: Ib91037bfbeaf4bfd76c72ed87cc710cef068f0be
diff --git a/quic/tools/fake_proof_verifier.h b/quic/tools/fake_proof_verifier.h new file mode 100644 index 0000000..ffeb6e9 --- /dev/null +++ b/quic/tools/fake_proof_verifier.h
@@ -0,0 +1,49 @@ +// Copyright (c) 2012 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef QUICHE_QUIC_TOOLS_FAKE_PROOF_VERIFIER_H_ +#define QUICHE_QUIC_TOOLS_FAKE_PROOF_VERIFIER_H_ + +#include "net/third_party/quiche/src/quic/core/crypto/proof_verifier.h" + +namespace quic { + +// ProofVerifier implementation which always returns success. +class FakeProofVerifier : public ProofVerifier { + public: + ~FakeProofVerifier() override {} + QuicAsyncStatus VerifyProof( + const std::string& /*hostname*/, + const uint16_t /*port*/, + const std::string& /*server_config*/, + QuicTransportVersion /*quic_version*/, + QuicStringPiece /*chlo_hash*/, + const std::vector<std::string>& /*certs*/, + const std::string& /*cert_sct*/, + const std::string& /*signature*/, + const ProofVerifyContext* /*context*/, + std::string* /*error_details*/, + std::unique_ptr<ProofVerifyDetails>* /*details*/, + std::unique_ptr<ProofVerifierCallback> /*callback*/) override { + return QUIC_SUCCESS; + } + QuicAsyncStatus VerifyCertChain( + const std::string& /*hostname*/, + const std::vector<std::string>& /*certs*/, + const std::string& /*ocsp_response*/, + const std::string& /*cert_sct*/, + const ProofVerifyContext* /*context*/, + std::string* /*error_details*/, + std::unique_ptr<ProofVerifyDetails>* /*details*/, + std::unique_ptr<ProofVerifierCallback> /*callback*/) override { + return QUIC_SUCCESS; + } + std::unique_ptr<ProofVerifyContext> CreateDefaultContext() override { + return nullptr; + } +}; + +} // namespace quic + +#endif // QUICHE_QUIC_TOOLS_FAKE_PROOF_VERIFIER_H_
diff --git a/quic/tools/quic_client_bin.cc b/quic/tools/quic_client_bin.cc index 43f0df6..1ec47a9 100644 --- a/quic/tools/quic_client_bin.cc +++ b/quic/tools/quic_client_bin.cc
@@ -60,6 +60,7 @@ #include "net/third_party/quiche/src/quic/platform/api/quic_string_piece.h" #include "net/third_party/quiche/src/quic/platform/api/quic_system_event_loop.h" #include "net/third_party/quiche/src/quic/platform/api/quic_text_utils.h" +#include "net/third_party/quiche/src/quic/tools/fake_proof_verifier.h" #include "net/third_party/quiche/src/quic/tools/quic_client.h" #include "net/third_party/quiche/src/quic/tools/quic_url.h" @@ -70,40 +71,6 @@ using quic::QuicTextUtils; using quic::QuicUrl; -class FakeProofVerifier : public quic::ProofVerifier { - public: - ~FakeProofVerifier() override {} - quic::QuicAsyncStatus VerifyProof( - const std::string& /*hostname*/, - const uint16_t /*port*/, - const std::string& /*server_config*/, - quic::QuicTransportVersion /*quic_version*/, - quic::QuicStringPiece /*chlo_hash*/, - const std::vector<std::string>& /*certs*/, - const std::string& /*cert_sct*/, - const std::string& /*signature*/, - const quic::ProofVerifyContext* /*context*/, - std::string* /*error_details*/, - std::unique_ptr<quic::ProofVerifyDetails>* /*details*/, - std::unique_ptr<quic::ProofVerifierCallback> /*callback*/) override { - return quic::QUIC_SUCCESS; - } - quic::QuicAsyncStatus VerifyCertChain( - const std::string& /*hostname*/, - const std::vector<std::string>& /*certs*/, - const std::string& /*ocsp_response*/, - const std::string& /*cert_sct*/, - const quic::ProofVerifyContext* /*context*/, - std::string* /*error_details*/, - std::unique_ptr<quic::ProofVerifyDetails>* /*details*/, - std::unique_ptr<quic::ProofVerifierCallback> /*callback*/) override { - return quic::QUIC_SUCCESS; - } - std::unique_ptr<quic::ProofVerifyContext> CreateDefaultContext() override { - return nullptr; - } -}; - QuicSocketAddress LookupAddress(std::string host, std::string port) { addrinfo hint; memset(&hint, 0, sizeof(hint)); @@ -285,7 +252,7 @@ const int32_t num_requests(GetQuicFlag(FLAGS_num_requests)); std::unique_ptr<quic::ProofVerifier> proof_verifier; if (GetQuicFlag(FLAGS_disable_certificate_verification)) { - proof_verifier = quic::QuicMakeUnique<FakeProofVerifier>(); + proof_verifier = quic::QuicMakeUnique<quic::FakeProofVerifier>(); } else { proof_verifier = quic::CreateDefaultProofVerifier(); }