Http3DebugVisitor: trim default implementations
Remove default implementations from Http3DebugVisitor where QuicHttp3Logger in Chrome already has overrides.
Also remove unused header file includes.
No impact on the GFE as it doesn't provide an implementation of this class.
PiperOrigin-RevId: 490789675
diff --git a/quiche/quic/core/http/quic_spdy_session.h b/quiche/quic/core/http/quic_spdy_session.h
index e1cf902..476841d 100644
--- a/quiche/quic/core/http/quic_spdy_session.h
+++ b/quiche/quic/core/http/quic_spdy_session.h
@@ -22,9 +22,7 @@
#include "quiche/quic/core/http/quic_send_control_stream.h"
#include "quiche/quic/core/http/quic_spdy_stream.h"
#include "quiche/quic/core/qpack/qpack_decoder.h"
-#include "quiche/quic/core/qpack/qpack_decoder_stream_sender.h"
#include "quiche/quic/core/qpack/qpack_encoder.h"
-#include "quiche/quic/core/qpack/qpack_encoder_stream_sender.h"
#include "quiche/quic/core/qpack/qpack_receive_stream.h"
#include "quiche/quic/core/qpack/qpack_send_stream.h"
#include "quiche/quic/core/quic_session.h"
@@ -32,7 +30,6 @@
#include "quiche/quic/core/quic_types.h"
#include "quiche/quic/core/quic_versions.h"
#include "quiche/quic/platform/api/quic_export.h"
-#include "quiche/common/quiche_circular_deque.h"
#include "quiche/spdy/core/http2_frame_decoder_adapter.h"
#include "quiche/spdy/core/http2_header_block.h"
@@ -62,11 +59,11 @@
// Creation of unidirectional streams.
// Called when locally-initiated control stream is created.
- virtual void OnControlStreamCreated(QuicStreamId /*stream_id*/) {}
+ virtual void OnControlStreamCreated(QuicStreamId /*stream_id*/) = 0;
// Called when locally-initiated QPACK encoder stream is created.
- virtual void OnQpackEncoderStreamCreated(QuicStreamId /*stream_id*/) {}
+ virtual void OnQpackEncoderStreamCreated(QuicStreamId /*stream_id*/) = 0;
// Called when locally-initiated QPACK decoder stream is created.
- virtual void OnQpackDecoderStreamCreated(QuicStreamId /*stream_id*/) {}
+ virtual void OnQpackDecoderStreamCreated(QuicStreamId /*stream_id*/) = 0;
// Called when peer's control stream type is received.
virtual void OnPeerControlStreamCreated(QuicStreamId /*stream_id*/) = 0;
// Called when peer's QPACK encoder stream type is received.
@@ -80,40 +77,40 @@
// Incoming HTTP/3 frames on the control stream.
virtual void OnSettingsFrameReceived(const SettingsFrame& /*frame*/) = 0;
- virtual void OnGoAwayFrameReceived(const GoAwayFrame& /*frame*/) {}
+ virtual void OnGoAwayFrameReceived(const GoAwayFrame& /*frame*/) = 0;
virtual void OnPriorityUpdateFrameReceived(
- const PriorityUpdateFrame& /*frame*/) {}
+ const PriorityUpdateFrame& /*frame*/) = 0;
virtual void OnAcceptChFrameReceived(const AcceptChFrame& /*frame*/) {}
// Incoming HTTP/3 frames on request or push streams.
virtual void OnDataFrameReceived(QuicStreamId /*stream_id*/,
- QuicByteCount /*payload_length*/) {}
+ QuicByteCount /*payload_length*/) = 0;
virtual void OnHeadersFrameReceived(
- QuicStreamId /*stream_id*/, QuicByteCount /*compressed_headers_length*/) {
- }
+ QuicStreamId /*stream_id*/,
+ QuicByteCount /*compressed_headers_length*/) = 0;
virtual void OnHeadersDecoded(QuicStreamId /*stream_id*/,
- QuicHeaderList /*headers*/) {}
+ QuicHeaderList /*headers*/) = 0;
// Incoming HTTP/3 frames of unknown type on any stream.
virtual void OnUnknownFrameReceived(QuicStreamId /*stream_id*/,
uint64_t /*frame_type*/,
- QuicByteCount /*payload_length*/) {}
+ QuicByteCount /*payload_length*/) = 0;
// Outgoing HTTP/3 frames on the control stream.
virtual void OnSettingsFrameSent(const SettingsFrame& /*frame*/) = 0;
- virtual void OnGoAwayFrameSent(QuicStreamId /*stream_id*/) {}
- virtual void OnPriorityUpdateFrameSent(const PriorityUpdateFrame& /*frame*/) {
- }
+ virtual void OnGoAwayFrameSent(QuicStreamId /*stream_id*/) = 0;
+ virtual void OnPriorityUpdateFrameSent(
+ const PriorityUpdateFrame& /*frame*/) = 0;
// Outgoing HTTP/3 frames on request or push streams.
virtual void OnDataFrameSent(QuicStreamId /*stream_id*/,
- QuicByteCount /*payload_length*/) {}
+ QuicByteCount /*payload_length*/) = 0;
virtual void OnHeadersFrameSent(
QuicStreamId /*stream_id*/,
- const spdy::Http2HeaderBlock& /*header_block*/) {}
+ const spdy::Http2HeaderBlock& /*header_block*/) = 0;
// 0-RTT related events.
- virtual void OnSettingsFrameResumed(const SettingsFrame& /*frame*/) {}
+ virtual void OnSettingsFrameResumed(const SettingsFrame& /*frame*/) = 0;
};
// Whether HTTP Datagrams are supported on this session and if so which version
diff --git a/quiche/quic/test_tools/quic_test_utils.h b/quiche/quic/test_tools/quic_test_utils.h
index 9808498..0c0ab24 100644
--- a/quiche/quic/test_tools/quic_test_utils.h
+++ b/quiche/quic/test_tools/quic_test_utils.h
@@ -35,14 +35,12 @@
#include "quiche/quic/core/quic_types.h"
#include "quiche/quic/core/quic_utils.h"
#include "quiche/quic/platform/api/quic_socket_address.h"
-#include "quiche/quic/platform/api/quic_test.h"
#include "quiche/quic/test_tools/mock_clock.h"
#include "quiche/quic/test_tools/mock_connection_id_generator.h"
#include "quiche/quic/test_tools/mock_quic_session_visitor.h"
#include "quiche/quic/test_tools/mock_random.h"
#include "quiche/quic/test_tools/quic_framer_peer.h"
#include "quiche/quic/test_tools/simple_quic_framer.h"
-#include "quiche/common/quiche_mem_slice_storage.h"
#include "quiche/common/simple_buffer_allocator.h"
#include "quiche/spdy/core/http2_header_block.h"
@@ -1026,6 +1024,7 @@
MOCK_METHOD(void, OnDataFrameSent, (QuicStreamId, QuicByteCount), (override));
MOCK_METHOD(void, OnHeadersFrameSent,
(QuicStreamId, const spdy::Http2HeaderBlock&), (override));
+ MOCK_METHOD(void, OnSettingsFrameResumed, (const SettingsFrame&), (override));
};
class TestQuicSpdyServerSession : public QuicServerSessionBase {
