Deprecate --gfe2_reloadable_flag_quic_server_reverse_validate_new_path3 PiperOrigin-RevId: 443115398
diff --git a/quiche/quic/core/quic_connection.cc b/quiche/quic/core/quic_connection.cc index cce0d5c..3826f8d 100644 --- a/quiche/quic/core/quic_connection.cc +++ b/quiche/quic/core/quic_connection.cc
@@ -645,10 +645,8 @@ quic_remove_connection_migration_connection_option_v2); } if (framer_.version().HasIetfQuicFrames() && - GetQuicReloadableFlag(quic_server_reverse_validate_new_path3) && (remove_connection_migration_connection_option || config.HasClientSentConnectionOption(kRVCM, perspective_))) { - QUIC_CODE_COUNT_N(quic_server_reverse_validate_new_path3, 6, 6); validate_client_addresses_ = true; } // Having connection_migration_use_new_cid_ depends on the same set of flags @@ -1693,7 +1691,6 @@ if (!validate_client_addresses_) { return OnPathChallengeFrameInternal(frame); } - QUIC_CODE_COUNT_N(quic_server_reverse_validate_new_path3, 1, 6); { // TODO(danzh) inline OnPathChallengeFrameInternal() once // validate_client_addresses_ is deprecated. @@ -5148,7 +5145,6 @@ if (!validate_client_addresses_) { return; } - QUIC_CODE_COUNT_N(quic_server_reverse_validate_new_path3, 2, 6); if (debug_visitor_ != nullptr) { const QuicTime now = clock_->ApproximateNow(); if (now >= stats_.handshake_completion_time) { @@ -5194,7 +5190,6 @@ return; } - QUIC_CODE_COUNT_N(quic_server_reverse_validate_new_path3, 3, 6); if (type == NO_CHANGE) { UpdatePeerAddress(last_received_packet_info_.source_address); QUIC_BUG(quic_bug_10511_36) @@ -5508,7 +5503,6 @@ current_effective_peer_address, client_cid, last_packet_destination_connection_id_, stateless_reset_token); } else if (!default_path_.validated) { - QUIC_CODE_COUNT_N(quic_server_reverse_validate_new_path3, 4, 6); // Skip reverse path validation because either handshake hasn't // completed or the connection is validating the default path. Using // PATH_CHALLENGE to validate alternative client address before @@ -5522,7 +5516,6 @@ IsHandshakeConfirmed() && !alternative_path_.validated) << "No validated peer address to send after handshake comfirmed."; } else if (!IsReceivedPeerAddressValidated()) { - QUIC_CODE_COUNT_N(quic_server_reverse_validate_new_path3, 5, 6); QuicConnectionId client_connection_id; absl::optional<StatelessResetToken> stateless_reset_token; FindMatchingOrNewClientConnectionIdOrToken(
diff --git a/quiche/quic/core/quic_flags_list.h b/quiche/quic/core/quic_flags_list.h index befd715..3c1bc12 100644 --- a/quiche/quic/core/quic_flags_list.h +++ b/quiche/quic/core/quic_flags_list.h
@@ -97,8 +97,6 @@ QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_connection_migration_use_new_cid_v2, true) // If true, uses conservative cwnd gain and pacing gain when cwnd gets bootstrapped. QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_conservative_cwnd_and_pacing_gains, false) -// If true, validate that peer owns the new address once the server detects peer migration or is probed from that address, and also apply anti-amplification limit while sending to that address. -QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_server_reverse_validate_new_path3, true) // If true, when a packet is forced retransmitted, only set packet state if all data gets retransmitted. QUIC_FLAG(FLAGS_quic_restart_flag_quic_set_packet_state_if_all_data_retransmitted, true) // When the flag is true, exit STARTUP after the same number of loss events as PROBE_UP.