commit a80920cb762ade1828c6b4e6c159caa67d5344b6
author QUICHE team <quiche-dev@google.com> Thu Aug 22 14:06:29 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Fri Aug 23 12:19:03 2019 -0700
tree f5db2d075da53caaa3ad499c61fe02d0e4d2e706
parent 93cc53a80af0e180da674020ea827ec516c05b93

Deprecate --gfe2_reloadable_flag_quic_log_cert_name_for_empty_sct.

This was created with a modified version of the standard script with manual changes.  See cl/264822404 for more information.
Command-line:
gfe/gfe2/tools/deprecate_flag.sh gfe2_reloadable_flag_quic_log_cert_name_for_empty_sct

gfe-relnote: deprecate gfe2_reloadable_flag_quic_log_cert_name_for_empty_sct.
PiperOrigin-RevId: 264915124
Change-Id: I05ca640e5836232fa570240ded53ad9b0c4f99d9

quic/core/crypto/quic_crypto_server_config.cc

diff --git a/quic/core/crypto/quic_crypto_server_config.cc b/quic/core/crypto/quic_crypto_server_config.cc
index 50ea2f8..862dc62 100644
--- a/quic/core/crypto/quic_crypto_server_config.cc
+++ b/quic/core/crypto/quic_crypto_server_config.cc
@@ -1490,24 +1490,18 @@
     out->SetStringPiece(kPROF, context.signed_config()->proof.signature);
     if (should_return_sct) {
       if (cert_sct.empty()) {
-        if (!GetQuicReloadableFlag(quic_log_cert_name_for_empty_sct)) {
-          QUIC_LOG_EVERY_N_SEC(WARNING, 60)
-              << "SCT is expected but it is empty. sni :"
-              << context.params()->sni;
-        } else {
-          // Log SNI and subject name for the leaf cert if its SCT is empty.
-          // This is for debugging b/28342827.
-          const std::vector<std::string>& certs =
-              context.signed_config()->chain->certs;
-          QuicStringPiece ca_subject;
-          if (!certs.empty()) {
-            QuicCertUtils::ExtractSubjectNameFromDERCert(certs[0], &ca_subject);
-          }
-          QUIC_LOG_EVERY_N_SEC(WARNING, 60)
-              << "SCT is expected but it is empty. sni: '"
-              << context.params()->sni << "' cert subject: '" << ca_subject
-              << "'";
+        // Log SNI and subject name for the leaf cert if its SCT is empty.
+        // This is for debugging b/28342827.
+        const std::vector<std::string>& certs =
+            context.signed_config()->chain->certs;
+        QuicStringPiece ca_subject;
+        if (!certs.empty()) {
+          QuicCertUtils::ExtractSubjectNameFromDERCert(certs[0], &ca_subject);
         }
+        QUIC_LOG_EVERY_N_SEC(WARNING, 60)
+            << "SCT is expected but it is empty. sni: '"
+            << context.params()->sni << "' cert subject: '" << ca_subject
+            << "'";
       } else {
         out->SetStringPiece(kCertificateSCTTag, cert_sct);
       }