Remove minimally used QuicConnectionCloseFrame constructor gfe-relnote: N/A removes a constructor used only in tests. PiperOrigin-RevId: 254980727 Change-Id: I10adbbf0ea8524e5f4a5ba0e1d3031d366147a78
diff --git a/quic/core/frames/quic_connection_close_frame.cc b/quic/core/frames/quic_connection_close_frame.cc index 3587ebd..ad51068 100644 --- a/quic/core/frames/quic_connection_close_frame.cc +++ b/quic/core/frames/quic_connection_close_frame.cc
@@ -15,13 +15,6 @@ extracted_error_code(QUIC_IETF_GQUIC_ERROR_MISSING), transport_close_frame_type(0) {} -QuicConnectionCloseFrame::QuicConnectionCloseFrame(QuicErrorCode error_code) - // Default close type ensures that existing, pre-V99 code works as expected. - : close_type(GOOGLE_QUIC_CONNECTION_CLOSE), - quic_error_code(error_code), - extracted_error_code(QUIC_IETF_GQUIC_ERROR_MISSING), - transport_close_frame_type(0) {} - QuicConnectionCloseFrame::QuicConnectionCloseFrame(QuicErrorCode error_code, std::string error_details) // Default close type ensures that existing, pre-V99 code works as expected.
diff --git a/quic/core/frames/quic_connection_close_frame.h b/quic/core/frames/quic_connection_close_frame.h index 7997fbc..68ed112 100644 --- a/quic/core/frames/quic_connection_close_frame.h +++ b/quic/core/frames/quic_connection_close_frame.h
@@ -26,7 +26,6 @@ struct QUIC_EXPORT_PRIVATE QuicConnectionCloseFrame { QuicConnectionCloseFrame(); - QuicConnectionCloseFrame(QuicErrorCode error_code); QuicConnectionCloseFrame(QuicErrorCode error_code, std::string error_details); QuicConnectionCloseFrame(QuicIetfTransportErrorCodes transport_error_code, QuicErrorCode extracted_error_code,
diff --git a/quic/core/quic_connection_test.cc b/quic/core/quic_connection_test.cc index 5762957..b51ca45 100644 --- a/quic/core/quic_connection_test.cc +++ b/quic/core/quic_connection_test.cc
@@ -1444,7 +1444,7 @@ header.packet_number = QuicPacketNumber(number); - QuicConnectionCloseFrame qccf(QUIC_PEER_GOING_AWAY); + QuicConnectionCloseFrame qccf(QUIC_PEER_GOING_AWAY, ""); if (VersionHasIetfQuicFrames(peer_framer_.transport_version())) { // Default close-type is Google QUIC. If doing IETF QUIC then // set close type to be IETF CC/T. @@ -6862,7 +6862,7 @@ header.packet_number = QuicPacketNumber(1); header.version_flag = false; - QuicConnectionCloseFrame qccf(QUIC_PEER_GOING_AWAY); + QuicConnectionCloseFrame qccf(QUIC_PEER_GOING_AWAY, ""); if (VersionHasIetfQuicFrames(peer_framer_.transport_version())) { // Default close-type is Google QUIC. If doing IETF QUIC then // set close type to be IETF CC/T. @@ -8486,7 +8486,7 @@ EXPECT_CALL(visitor_, OnConnectionClosed(_, _)); EXPECT_EQ(Perspective::IS_CLIENT, connection_.perspective()); std::unique_ptr<QuicConnectionCloseFrame> connection_close_frame( - new QuicConnectionCloseFrame(QUIC_INTERNAL_ERROR)); + new QuicConnectionCloseFrame(QUIC_INTERNAL_ERROR, "")); if (VersionHasIetfQuicFrames(connection_.transport_version())) { connection_close_frame->close_type = IETF_QUIC_TRANSPORT_CONNECTION_CLOSE; }