Rename MaybeUpdateAckFrequency to MaybeEnableAckDecimation. PiperOrigin-RevId: 874173443
diff --git a/quiche/quic/core/quic_received_packet_manager.cc b/quiche/quic/core/quic_received_packet_manager.cc index 5b78319..39aba3a 100644 --- a/quiche/quic/core/quic_received_packet_manager.cc +++ b/quiche/quic/core/quic_received_packet_manager.cc
@@ -262,13 +262,9 @@ return std::max(ack_delay, kAlarmGranularity); } -void QuicReceivedPacketManager::MaybeUpdateAckFrequency( +void QuicReceivedPacketManager::MaybeEnableAckDecimation( QuicPacketNumber last_received_packet_number) { - if (AckFrequencyFrameReceived()) { - // Skip Ack Decimation below after receiving an AckFrequencyFrame from the - // other end point. - return; - } + QUICHE_DCHECK(!AckFrequencyFrameReceived()); if (last_received_packet_number < PeerFirstSendingPacketNumber() + min_received_before_ack_decimation_) { return; @@ -330,7 +326,9 @@ ++num_retransmittable_packets_received_since_last_ack_sent_; - MaybeUpdateAckFrequency(last_received_packet_number); + if (!AckFrequencyFrameReceived()) { + MaybeEnableAckDecimation(last_received_packet_number); + } if (num_retransmittable_packets_received_since_last_ack_sent_ >= ack_frequency_) { ack_timeout_ = now;
diff --git a/quiche/quic/core/quic_received_packet_manager.h b/quiche/quic/core/quic_received_packet_manager.h index 7bf05b6..78942d0 100644 --- a/quiche/quic/core/quic_received_packet_manager.h +++ b/quiche/quic/core/quic_received_packet_manager.h
@@ -149,8 +149,8 @@ // Sets ack_timeout_ to |time| if ack_timeout_ is not initialized or > time. void MaybeUpdateAckTimeoutTo(QuicTime time); - // Maybe update ack_frequency_ when condition meets. - void MaybeUpdateAckFrequency(QuicPacketNumber last_received_packet_number); + // Sets ack_frequency_ when enough packets have been received. + void MaybeEnableAckDecimation(QuicPacketNumber last_received_packet_number); QuicTime::Delta GetMaxAckDelay(QuicPacketNumber last_received_packet_number, const RttStats& rtt_stats) const;