commit 70430d7235d2128f916ccd1a4bc66cfc3a407d5a
author vasilvv <vasilvv@google.com> Sun Jul 21 12:06:49 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Jul 23 06:45:56 2019 -0700
tree a8153ec626251fed68977b693dc23f01a07ebad5
parent a87865c18fa205315a2267b4fcf990c04a21e889

Hex encode the path challenge buffer.

gfe-relnote: logging change, not flag protected
PiperOrigin-RevId: 259219838
Change-Id: Ifa6798671856f178cedd6fe7f03ed4324f01c82a

quic/core/frames/quic_path_challenge_frame.cc

diff --git a/quic/core/frames/quic_path_challenge_frame.cc b/quic/core/frames/quic_path_challenge_frame.cc
index c1ca6a8..feaa71c 100644
--- a/quic/core/frames/quic_path_challenge_frame.cc
+++ b/quic/core/frames/quic_path_challenge_frame.cc
@@ -3,8 +3,10 @@
 // found in the LICENSE file.
 
 #include "net/third_party/quiche/src/quic/core/frames/quic_path_challenge_frame.h"
+
 #include "net/third_party/quiche/src/quic/core/quic_constants.h"
 #include "net/third_party/quiche/src/quic/platform/api/quic_bug_tracker.h"
+#include "net/third_party/quiche/src/quic/platform/api/quic_text_utils.h"
 
 namespace quic {
 
@@ -22,15 +24,11 @@
 
 std::ostream& operator<<(std::ostream& os,
                          const QuicPathChallengeFrame& frame) {
-  os << "{ control_frame_id: " << frame.control_frame_id
-     << ", data: " << static_cast<unsigned>(frame.data_buffer[0]) << " "
-     << static_cast<unsigned>(frame.data_buffer[1]) << " "
-     << static_cast<unsigned>(frame.data_buffer[2]) << " "
-     << static_cast<unsigned>(frame.data_buffer[3]) << " "
-     << static_cast<unsigned>(frame.data_buffer[4]) << " "
-     << static_cast<unsigned>(frame.data_buffer[5]) << " "
-     << static_cast<unsigned>(frame.data_buffer[6]) << " "
-     << static_cast<unsigned>(frame.data_buffer[7]) << " }\n";
+  os << "{ control_frame_id: " << frame.control_frame_id << ", data: "
+     << QuicTextUtils::HexEncode(
+            reinterpret_cast<const char*>(frame.data_buffer.data()),
+            frame.data_buffer.size())
+     << " }\n";
   return os;
 }
 

quic/core/frames/quic_path_response_frame.cc

diff --git a/quic/core/frames/quic_path_response_frame.cc b/quic/core/frames/quic_path_response_frame.cc
index 85e9712..bf36ab4 100644
--- a/quic/core/frames/quic_path_response_frame.cc
+++ b/quic/core/frames/quic_path_response_frame.cc
@@ -3,8 +3,10 @@
 // found in the LICENSE file.
 
 #include "net/third_party/quiche/src/quic/core/frames/quic_path_response_frame.h"
+
 #include "net/third_party/quiche/src/quic/core/quic_constants.h"
 #include "net/third_party/quiche/src/quic/platform/api/quic_bug_tracker.h"
+#include "net/third_party/quiche/src/quic/platform/api/quic_text_utils.h"
 
 namespace quic {
 
@@ -21,15 +23,11 @@
 QuicPathResponseFrame::~QuicPathResponseFrame() {}
 
 std::ostream& operator<<(std::ostream& os, const QuicPathResponseFrame& frame) {
-  os << "{ control_frame_id: " << frame.control_frame_id
-     << ", data: " << static_cast<unsigned>(frame.data_buffer[0]) << " "
-     << static_cast<unsigned>(frame.data_buffer[1]) << " "
-     << static_cast<unsigned>(frame.data_buffer[2]) << " "
-     << static_cast<unsigned>(frame.data_buffer[3]) << " "
-     << static_cast<unsigned>(frame.data_buffer[4]) << " "
-     << static_cast<unsigned>(frame.data_buffer[5]) << " "
-     << static_cast<unsigned>(frame.data_buffer[6]) << " "
-     << static_cast<unsigned>(frame.data_buffer[7]) << " }\n";
+  os << "{ control_frame_id: " << frame.control_frame_id << ", data: "
+     << QuicTextUtils::HexEncode(
+            reinterpret_cast<const char*>(frame.data_buffer.data()),
+            frame.data_buffer.size())
+     << " }\n";
   return os;
 }