commit 67e5bcb6ec09511f454e015ddc7f483a86c99fa7
author renjietang <renjietang@google.com> Thu Sep 26 16:19:55 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Fri Sep 27 05:59:51 2019 -0700
tree f92a62551d25eb883c7cb08138befe49efb19b20
parent f0fe2069005c907660534fc7d3ee9694c79799d6

Comments on some disabled v99 tests.

gfe-relnote: n/a - test only
PiperOrigin-RevId: 271456397
Change-Id: Ibb4b377f71e7414b7ca6aa9936158dbd239ec958

quic/core/http/quic_spdy_session_test.cc

diff --git a/quic/core/http/quic_spdy_session_test.cc b/quic/core/http/quic_spdy_session_test.cc
index cf49dd0..16028de 100644
--- a/quic/core/http/quic_spdy_session_test.cc
+++ b/quic/core/http/quic_spdy_session_test.cc
@@ -1544,6 +1544,7 @@
 
 TEST_P(QuicSpdySessionTestServer, WindowUpdateUnblocksHeadersStream) {
   if (VersionUsesQpack(GetParam().transport_version)) {
+    // The test relies on headers stream, which no longer exists in IETF QUIC.
     return;
   }
 
@@ -1792,6 +1793,7 @@
 
 TEST_P(QuicSpdySessionTestClient, WritePriority) {
   if (VersionHasStreamType(transport_version())) {
+    // IETF QUIC currently doesn't support PRIORITY.
     return;
   }
   TestHeadersStream* headers_stream;

quic/core/quic_session_test.cc

diff --git a/quic/core/quic_session_test.cc b/quic/core/quic_session_test.cc
index 1f3b5b7..7a3b44a 100644
--- a/quic/core/quic_session_test.cc
+++ b/quic/core/quic_session_test.cc
@@ -933,6 +933,7 @@
 
 TEST_P(QuicSessionTestServer, Http2Priority) {
   if (VersionHasIetfQuicFrames(GetParam().transport_version)) {
+    // The test is using HTTP/2 priority which is not supported in IETF QUIC.
     return;
   }
   SetQuicReloadableFlag(quic_use_http2_priority_write_scheduler, true);
@@ -1015,6 +1016,7 @@
 
 TEST_P(QuicSessionTestServer, RoundRobinScheduling) {
   if (VersionHasIetfQuicFrames(GetParam().transport_version)) {
+    // IETF QUIC currently doesn't support PRIORITY.
     return;
   }
   SetQuicReloadableFlag(quic_enable_rr_write_scheduler, true);
@@ -1373,11 +1375,6 @@
   if (!VersionHasIetfQuicFrames(transport_version())) {
     return;
   }
-  if (GetParam().handshake_protocol == PROTOCOL_TLS1_3) {
-    // TODO(nharper, b/112643533): Figure out why this test fails when TLS is
-    // enabled and fix it.
-    return;
-  }
   QuicSocketAddress old_peer_address =
       QuicSocketAddress(QuicIpAddress::Loopback4(), kTestPort);
   EXPECT_EQ(old_peer_address, session_.peer_address());
@@ -1416,6 +1413,7 @@
 
 TEST_P(QuicSessionTestServer, OnStreamFrameFinStaticStreamId) {
   if (VersionUsesQpack(connection_->transport_version())) {
+    // The test relies on headers stream, which no longer exists in IETF QUIC.
     return;
   }
   QuicStreamId headers_stream_id =
@@ -1435,6 +1433,7 @@
 
 TEST_P(QuicSessionTestServer, OnRstStreamStaticStreamId) {
   if (VersionUsesQpack(connection_->transport_version())) {
+    // The test relies on headers stream, which no longer exists in IETF QUIC.
     return;
   }
   QuicStreamId headers_stream_id =