Add -Winconsistent-missing-override to QUIC This will avoid QUIC merge issues like the missing override in cl/253262405. gfe-relnote: n/a, only adds compilation warning PiperOrigin-RevId: 253317636 Change-Id: I818c59188f52eb0bb92d2a5df8ccd1509a1c9a67
diff --git a/quic/core/quic_connection_test.cc b/quic/core/quic_connection_test.cc index f96a7e6..314898b 100644 --- a/quic/core/quic_connection_test.cc +++ b/quic/core/quic_connection_test.cc
@@ -422,7 +422,7 @@ return max_packet_size_; } - bool SupportsReleaseTime() const { return supports_release_time_; } + bool SupportsReleaseTime() const override { return supports_release_time_; } bool IsBatchMode() const override { return is_batch_mode_; }
diff --git a/quic/quartc/quartc_fakes.h b/quic/quartc/quartc_fakes.h index abf2a43..be45400 100644 --- a/quic/quartc/quartc_fakes.h +++ b/quic/quartc/quartc_fakes.h
@@ -63,12 +63,13 @@ sent_datagram_ids_.push_back(datagram_id); } - void OnMessageAcked(int64_t datagram_id, QuicTime receive_timestamp) { + void OnMessageAcked(int64_t datagram_id, + QuicTime receive_timestamp) override { acked_datagram_id_to_receive_timestamp_.emplace(datagram_id, receive_timestamp); } - void OnMessageLost(int64_t datagram_id) { + void OnMessageLost(int64_t datagram_id) override { lost_datagram_ids_.push_back(datagram_id); }