gfe-relnote: undeprecate gfe2_reloadable_flag_quic_create_incoming_stream_bug gfe2_reloadable_flag_quic_create_incoming_stream_bug has been mistakenly deprecated at the same time it was verified at cl/303999833. This CL undeprecates the flag while keeping it verified. PiperOrigin-RevId: 304403085 Change-Id: I73d82607a31ce36eb020545e572317072f0ddf5a
diff --git a/quic/core/http/quic_spdy_client_session.cc b/quic/core/http/quic_spdy_client_session.cc index 48d21ea..07b9c7a 100644 --- a/quic/core/http/quic_spdy_client_session.cc +++ b/quic/core/http/quic_spdy_client_session.cc
@@ -136,9 +136,23 @@ return false; } + if (GetQuicReloadableFlag(quic_create_incoming_stream_bug)) { + if (QuicUtils::IsClientInitiatedStreamId(transport_version(), id)) { + QUIC_RELOADABLE_FLAG_COUNT_N(quic_create_incoming_stream_bug, 1, 2); + QUIC_BUG << "ShouldCreateIncomingStream called with client initiated " + "stream ID."; + return false; + } else { + QUIC_RELOADABLE_FLAG_COUNT_N(quic_create_incoming_stream_bug, 2, 2); + } + } + if (QuicUtils::IsClientInitiatedStreamId(transport_version(), id)) { - QUIC_BUG << "ShouldCreateIncomingStream called with client initiated " - "stream ID."; + QUIC_LOG(WARNING) << "Received invalid push stream id " << id; + connection()->CloseConnection( + QUIC_INVALID_STREAM_ID, + "Server created non write unidirectional stream", + ConnectionCloseBehavior::SEND_CONNECTION_CLOSE_PACKET); return false; }