commit 4c8b5796b6050668f621deb528c219d67270a659
author bnc <bnc@google.com> Wed Sep 14 11:25:20 2022 -0700
committer Copybara-Service <copybara-worker@google.com> Wed Sep 14 11:27:16 2022 -0700
tree 868e36d6ba8fc9575718c6575bf64833137568f4
parent 2f10941b814348cf0a428ab856f03399253ad73e

Remove code to write unidirectional push stream type.

Push has never been implemented for HTTP/3.  If QuicSpdySession receives a
push stream, it closes the connection, see
https://github.com/google/quiche/blob/2f10941b814348cf0a428ab856f03399253ad73e/quiche/quic/core/http/quic_spdy_session.cc#L1406-L1410
This error is not seen in the wild, implying that this code is not exercised.

PiperOrigin-RevId: 474345082

quiche/quic/core/http/quic_spdy_stream.cc

diff --git a/quiche/quic/core/http/quic_spdy_stream.cc b/quiche/quic/core/http/quic_spdy_stream.cc
index 44de84c..c2c269a 100644
--- a/quiche/quic/core/http/quic_spdy_stream.cc
+++ b/quiche/quic/core/http/quic_spdy_stream.cc
@@ -254,22 +254,6 @@
   }
 
   QuicConnection::ScopedPacketFlusher flusher(spdy_session_->connection());
-  // Send stream type for server push stream
-  if (VersionUsesHttp3(transport_version()) && type() == WRITE_UNIDIRECTIONAL &&
-      send_buffer().stream_offset() == 0) {
-    char data[sizeof(kServerPushStream)];
-    QuicDataWriter writer(ABSL_ARRAYSIZE(data), data);
-    writer.WriteVarInt62(kServerPushStream);
-
-    // Similar to frame headers, stream type byte shouldn't be exposed to upper
-    // layer applications.
-    unacked_frame_headers_offsets_.Add(0, writer.length());
-
-    QUIC_LOG(INFO) << ENDPOINT << "Stream " << id()
-                   << " is writing type as server push";
-    WriteOrBufferData(absl::string_view(writer.data(), writer.length()), false,
-                      nullptr);
-  }
 
   MaybeProcessSentWebTransportHeaders(header_block);