Remove QuicSpdySession::WritePushPromise(). PiperOrigin-RevId: 572696168
diff --git a/quiche/quic/core/http/quic_headers_stream_test.cc b/quiche/quic/core/http/quic_headers_stream_test.cc index 8df07bb..a086800 100644 --- a/quiche/quic/core/http/quic_headers_stream_test.cc +++ b/quiche/quic/core/http/quic_headers_stream_test.cc
@@ -397,40 +397,6 @@ } } -TEST_P(QuicHeadersStreamTest, WritePushPromises) { - for (QuicStreamId stream_id = client_id_1_; stream_id < client_id_3_; - stream_id += next_stream_id_) { - QuicStreamId promised_stream_id = NextPromisedStreamId(); - if (perspective() == Perspective::IS_SERVER) { - // Write the headers and capture the outgoing data - EXPECT_CALL(session_, WritevData(QuicUtils::GetHeadersStreamId( - connection_->transport_version()), - _, _, NO_FIN, _, _)) - .WillOnce(WithArgs<1>(Invoke(this, &QuicHeadersStreamTest::SaveIov))); - session_.WritePushPromise(stream_id, promised_stream_id, - headers_.Clone()); - - // Parse the outgoing data and check that it matches was was written. - EXPECT_CALL(visitor_, - OnPushPromise(stream_id, promised_stream_id, kFrameComplete)); - headers_handler_ = std::make_unique<RecordingHeadersHandler>(); - EXPECT_CALL(visitor_, OnHeaderFrameStart(stream_id)) - .WillOnce(Return(headers_handler_.get())); - EXPECT_CALL(visitor_, OnHeaderFrameEnd(stream_id)).Times(1); - deframer_->ProcessInput(saved_data_.data(), saved_data_.length()); - EXPECT_FALSE(deframer_->HasError()) - << http2::Http2DecoderAdapter::SpdyFramerErrorToString( - deframer_->spdy_framer_error()); - CheckHeaders(); - saved_data_.clear(); - } else { - EXPECT_QUIC_BUG(session_.WritePushPromise(stream_id, promised_stream_id, - headers_.Clone()), - "Client shouldn't send PUSH_PROMISE"); - } - } -} - TEST_P(QuicHeadersStreamTest, ProcessRawData) { for (QuicStreamId stream_id = client_id_1_; stream_id < client_id_3_; stream_id += next_stream_id_) {
diff --git a/quiche/quic/core/http/quic_spdy_session.cc b/quiche/quic/core/http/quic_spdy_session.cc index 03f65db..69c6382 100644 --- a/quiche/quic/core/http/quic_spdy_session.cc +++ b/quiche/quic/core/http/quic_spdy_session.cc
@@ -843,31 +843,6 @@ last_sent_http3_goaway_id_ = stream_id; } -void QuicSpdySession::WritePushPromise(QuicStreamId original_stream_id, - QuicStreamId promised_stream_id, - Http2HeaderBlock headers) { - if (perspective() == Perspective::IS_CLIENT) { - QUIC_BUG(quic_bug_10360_4) << "Client shouldn't send PUSH_PROMISE"; - return; - } - - if (VersionUsesHttp3(transport_version())) { - QUIC_BUG(quic_bug_12477_6) - << "Support for server push over HTTP/3 has been removed."; - return; - } - - SpdyPushPromiseIR push_promise(original_stream_id, promised_stream_id, - std::move(headers)); - // PUSH_PROMISE must not be the last frame sent out, at least followed by - // response headers. - push_promise.set_fin(false); - - SpdySerializedFrame frame(spdy_framer_.SerializeFrame(push_promise)); - headers_stream()->WriteOrBufferData( - absl::string_view(frame.data(), frame.size()), false, nullptr); -} - void QuicSpdySession::SendInitialData() { if (!VersionUsesHttp3(transport_version())) { return;
diff --git a/quiche/quic/core/http/quic_spdy_session.h b/quiche/quic/core/http/quic_spdy_session.h index 9d21b5d..ada9d8c 100644 --- a/quiche/quic/core/http/quic_spdy_session.h +++ b/quiche/quic/core/http/quic_spdy_session.h
@@ -245,12 +245,6 @@ // before encryption gets established. void SendHttp3GoAway(QuicErrorCode error_code, const std::string& reason); - // Write |headers| for |promised_stream_id| on |original_stream_id| in a - // PUSH_PROMISE frame to peer. - virtual void WritePushPromise(QuicStreamId original_stream_id, - QuicStreamId promised_stream_id, - spdy::Http2HeaderBlock headers); - QpackEncoder* qpack_encoder(); QpackDecoder* qpack_decoder(); QuicHeadersStream* headers_stream() { return headers_stream_; }