Add missing QUICHE_EXPORT_PRIVATE at a few places. I'm getting ready to improve the regexp for the presubmit, and these instances were flagged by the new expression. PiperOrigin-RevId: 446793847
diff --git a/quiche/common/balsa/balsa_headers.h b/quiche/common/balsa/balsa_headers.h index d9931e7..3ce1180 100644 --- a/quiche/common/balsa/balsa_headers.h +++ b/quiche/common/balsa/balsa_headers.h
@@ -1134,7 +1134,7 @@ }; // Succinctly describes one header line as indices into a buffer. -struct BalsaHeaders::HeaderLineDescription { +struct QUICHE_EXPORT_PRIVATE BalsaHeaders::HeaderLineDescription { HeaderLineDescription(size_t first_character_index, size_t key_end_index, size_t value_begin_index, size_t last_character_index, size_t buffer_base_index) @@ -1172,7 +1172,7 @@ // Base class for iterating the headers in a BalsaHeaders object, returning a // pair of string_view's for each header. -class BalsaHeaders::iterator_base +class QUICHE_EXPORT_PRIVATE BalsaHeaders::iterator_base : public std::iterator<std::forward_iterator_tag, std::pair<absl::string_view, absl::string_view>> { public: @@ -1268,7 +1268,7 @@ }; // A const iterator for all the header lines. -class BalsaHeaders::const_header_lines_iterator +class QUICHE_EXPORT_PRIVATE BalsaHeaders::const_header_lines_iterator : public BalsaHeaders::iterator_base { public: const_header_lines_iterator() : iterator_base() {} @@ -1287,7 +1287,7 @@ }; // A const iterator that stops only on header lines for a particular key. -class BalsaHeaders::const_header_lines_key_iterator +class QUICHE_EXPORT_PRIVATE BalsaHeaders::const_header_lines_key_iterator : public BalsaHeaders::iterator_base { public: const_header_lines_key_iterator& operator++() {
diff --git a/quiche/http2/decoder/payload_decoders/payload_decoder_base_test_util.h b/quiche/http2/decoder/payload_decoders/payload_decoder_base_test_util.h index 77f53cc..b76f1a0 100644 --- a/quiche/http2/decoder/payload_decoders/payload_decoder_base_test_util.h +++ b/quiche/http2/decoder/payload_decoders/payload_decoder_base_test_util.h
@@ -319,7 +319,7 @@ // means unpadded as there is then no room for the Pad Length field). // The frame type must support padding. template <class Decoder, class DecoderPeer, class Listener> -class AbstractPaddablePayloadDecoderTest +class QUICHE_NO_EXPORT AbstractPaddablePayloadDecoderTest : public AbstractPayloadDecoderTest<Decoder, DecoderPeer, Listener>, public ::testing::WithParamInterface<int> { typedef AbstractPayloadDecoderTest<Decoder, DecoderPeer, Listener> Base;