commit 203627533eb400cd1b2a5a09b36e7cf4eb7963a9
author ianswett <ianswett@google.com> Mon Jul 08 19:34:27 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Jul 09 07:44:13 2019 -0700
tree 775c2b2458f05b842a5f90b8cb6bde2829a1b3c5
parent 7a1c21c4a73eb36fa4ce1c687e29403429d75a52

gfe-relnote: Print out a SPDY_BUG and exit early rather than crash when Http2FrameDecoderAdapter is nullptr.  Not flag protected.

PiperOrigin-RevId: 257106748
Change-Id: I587ccf7a4adc43a2f61c5cf75994e1c56ec3c715

spdy/core/http2_frame_decoder_adapter.cc

diff --git a/spdy/core/http2_frame_decoder_adapter.cc b/spdy/core/http2_frame_decoder_adapter.cc
index 84e083f..ac53496 100644
--- a/spdy/core/http2_frame_decoder_adapter.cc
+++ b/spdy/core/http2_frame_decoder_adapter.cc
@@ -398,6 +398,11 @@
   DCHECK(!on_headers_called_);
   on_headers_called_ = true;
   ReportReceiveCompressedFrame(frame_header_);
+  if (!visitor()) {
+    SPDY_BUG << "Visitor is nullptr, handling priority in headers failed."
+             << " priority:" << priority << " frame_header:" << frame_header_;
+    return;
+  }
   visitor()->OnHeaders(frame_header_.stream_id, kHasPriorityFields,
                        priority.weight, priority.stream_dependency,
                        priority.is_exclusive, frame_header_.IsEndStream(),