gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_batch_writer_flush_after_mtu_probe. PiperOrigin-RevId: 301254788 Change-Id: Ided83b7d8b093ae82dee9a41dac922d3856a86ef
diff --git a/quic/core/quic_connection.cc b/quic/core/quic_connection.cc index c067f7a..daf5031 100644 --- a/quic/core/quic_connection.cc +++ b/quic/core/quic_connection.cc
@@ -331,9 +331,7 @@ max_consecutive_ptos_(0), bytes_received_before_address_validation_(0), bytes_sent_before_address_validation_(0), - address_validated_(false), - batch_writer_flush_after_mtu_probe_( - GetQuicReloadableFlag(quic_batch_writer_flush_after_mtu_probe)) { + address_validated_(false) { QUIC_DLOG(INFO) << ENDPOINT << "Created connection with server connection ID " << server_connection_id << " and version: " << ParsedQuicVersionToString(version()); @@ -2264,9 +2262,7 @@ // be closed. By manually flush the writer here, the MTU probe is sent in // a normal(non-GSO) packet, so the kernel can return EMSGSIZE and we will // not close the connection. - if (batch_writer_flush_after_mtu_probe_ && is_mtu_discovery && - writer_->IsBatchMode()) { - QUIC_RELOADABLE_FLAG_COUNT(quic_batch_writer_flush_after_mtu_probe); + if (is_mtu_discovery && writer_->IsBatchMode()) { result = writer_->Flush(); } break;
diff --git a/quic/core/quic_connection.h b/quic/core/quic_connection.h index 8cb1d37..f35aa05 100644 --- a/quic/core/quic_connection.h +++ b/quic/core/quic_connection.h
@@ -1545,9 +1545,6 @@ QuicCoalescedPacket coalesced_packet_; QuicConnectionMtuDiscoverer mtu_discoverer_; - - // Latched value of quic_batch_writer_flush_after_mtu_probe. - const bool batch_writer_flush_after_mtu_probe_; }; } // namespace quic
diff --git a/quic/core/quic_connection_test.cc b/quic/core/quic_connection_test.cc index 007856b..cb2583e 100644 --- a/quic/core/quic_connection_test.cc +++ b/quic/core/quic_connection_test.cc
@@ -5024,9 +5024,7 @@ const uint32_t prior_flush_attempts = writer_->flush_attempts(); connection_.SendMtuDiscoveryPacket(target_mtu); EXPECT_EQ(target_mtu, mtu_probe_size); - if (GetQuicReloadableFlag(quic_batch_writer_flush_after_mtu_probe)) { - EXPECT_EQ(writer_->flush_attempts(), prior_flush_attempts + 1); - } + EXPECT_EQ(writer_->flush_attempts(), prior_flush_attempts + 1); } // Tests whether MTU discovery does not happen when it is not explicitly enabled