commit 0e4ae21b68e3fb246325606f31d20f8b6bb2e8d4
author David Schinazi <dschinazi@google.com> Wed May 01 13:36:54 2019 -0700
committer David Schinazi <dschinazi@google.com> Wed May 01 13:36:54 2019 -0700
tree 05b30c4f5c91058d81ad396f1ba7a9d190f4c1e0
parent 6b7c2384e3f6cc5bd7517b61eef228ac2734fa2c

Fix bad ack

quic/core/quic_packet_generator.cc

diff --git a/quic/core/quic_packet_generator.cc b/quic/core/quic_packet_generator.cc
index d3d950c..096f06a 100644
--- a/quic/core/quic_packet_generator.cc
+++ b/quic/core/quic_packet_generator.cc
@@ -523,6 +523,10 @@
                                          NOT_HANDSHAKE)) {
       return false;
     }
+    if (frame.type == ACK_FRAME && frame.ack_frame->packets.Empty()) {
+      QUIC_LOG(ERROR) << "Bad ACK!!!";
+      continue;
+    }
     const bool success =
         packet_creator_.AddSavedFrame(frame, next_transmission_type_);
     QUIC_BUG_IF(!success) << "Failed to flush " << frame;