| #include "quiche/http2/adapter/oghttp2_adapter.h" | |
| #include <cstddef> | |
| #include <cstdint> | |
| #include <limits> | |
| #include <memory> | |
| #include <optional> | |
| #include <string> | |
| #include <utility> | |
| #include <vector> | |
| #include "absl/strings/str_join.h" | |
| #include "quiche/http2/adapter/http2_protocol.h" | |
| #include "quiche/http2/adapter/http2_visitor_interface.h" | |
| #include "quiche/http2/adapter/mock_http2_visitor.h" | |
| #include "quiche/http2/adapter/oghttp2_util.h" | |
| #include "quiche/http2/adapter/test_frame_sequence.h" | |
| #include "quiche/http2/adapter/test_utils.h" | |
| #include "quiche/http2/core/spdy_protocol.h" | |
| #include "quiche/common/http/http_header_block.h" | |
| #include "quiche/common/platform/api/quiche_expect_bug.h" | |
| #include "quiche/common/platform/api/quiche_test.h" | |
| namespace http2 { | |
| namespace adapter { | |
| namespace test { | |
| namespace { | |
| using ConnectionError = Http2VisitorInterface::ConnectionError; | |
| using OnHeaderResult = ::http2::adapter::Http2VisitorInterface::OnHeaderResult; | |
| using spdy::SpdyFrameType; | |
| using testing::_; | |
| enum FrameType { | |
| DATA, | |
| HEADERS, | |
| PRIORITY, | |
| RST_STREAM, | |
| SETTINGS, | |
| PUSH_PROMISE, | |
| PING, | |
| GOAWAY, | |
| WINDOW_UPDATE, | |
| CONTINUATION, | |
| }; | |
| TEST(OgHttp2AdapterTest, IsServerSession) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| EXPECT_TRUE(adapter->IsServerSession()); | |
| } | |
| TEST(OgHttp2AdapterTest, ProcessBytes) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence seq; | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, 4, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 8, 6, 0)); | |
| EXPECT_CALL(visitor, OnPing(17, false)); | |
| adapter->ProcessBytes( | |
| TestFrameSequence().ClientPreface().Ping(17).Serialize()); | |
| } | |
| TEST(OgHttp2AdapterTest, HeaderValuesWithObsTextAllowedByDefault) { | |
| TestVisitor visitor; | |
| OgHttp2Session::Options options; | |
| options.perspective = Perspective::kServer; | |
| ASSERT_TRUE(options.allow_obs_text); | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/"}, | |
| {"name", "val\xa1ue"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":method", "GET")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":scheme", "https")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":authority", "example.com")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":path", "/")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, "name", "val\xa1ue")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnEndStream(1)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(frames.size(), static_cast<size_t>(result)); | |
| } | |
| TEST(OgHttp2AdapterTest, HeaderValuesWithObsTextDisallowed) { | |
| TestVisitor visitor; | |
| OgHttp2Session::Options options; | |
| options.allow_obs_text = false; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/"}, | |
| {"name", "val\xa1ue"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":method", "GET")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":scheme", "https")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":authority", "example.com")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":path", "/")); | |
| EXPECT_CALL( | |
| visitor, | |
| OnInvalidFrame(1, Http2VisitorInterface::InvalidFrameError::kHttpHeader)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(frames.size(), static_cast<size_t>(result)); | |
| } | |
| TEST(OgHttp2AdapterTest, RequestPathWithSpaceOrTab) { | |
| TestVisitor visitor; | |
| OgHttp2Session::Options options; | |
| options.allow_obs_text = false; | |
| options.perspective = Perspective::kServer; | |
| ASSERT_EQ(false, options.validate_path); | |
| options.validate_path = true; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/ fragment"}}, | |
| /*fin=*/true) | |
| .Headers(3, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/\tfragment2"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":method", "GET")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":scheme", "https")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":authority", "example.com")); | |
| EXPECT_CALL( | |
| visitor, | |
| OnInvalidFrame(1, Http2VisitorInterface::InvalidFrameError::kHttpHeader)); | |
| // Stream 3 | |
| EXPECT_CALL(visitor, OnFrameHeader(3, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(3)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, ":method", "GET")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, ":scheme", "https")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, ":authority", "example.com")); | |
| EXPECT_CALL( | |
| visitor, | |
| OnInvalidFrame(3, Http2VisitorInterface::InvalidFrameError::kHttpHeader)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(frames.size(), static_cast<size_t>(result)); | |
| } | |
| TEST(OgHttp2AdapterTest, RequestPathWithSpaceOrTabNoPathValidation) { | |
| TestVisitor visitor; | |
| OgHttp2Session::Options options; | |
| options.allow_obs_text = false; | |
| options.perspective = Perspective::kServer; | |
| ASSERT_EQ(false, options.validate_path); | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/ fragment"}}, | |
| /*fin=*/true) | |
| .Headers(3, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/\tfragment2"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":method", "GET")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":scheme", "https")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":authority", "example.com")); | |
| EXPECT_CALL( | |
| visitor, | |
| OnInvalidFrame(1, Http2VisitorInterface::InvalidFrameError::kHttpHeader)); | |
| // Stream 3 | |
| EXPECT_CALL(visitor, OnFrameHeader(3, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(3)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, ":method", "GET")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, ":scheme", "https")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, ":authority", "example.com")); | |
| EXPECT_CALL( | |
| visitor, | |
| OnInvalidFrame(3, Http2VisitorInterface::InvalidFrameError::kHttpHeader)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(frames.size(), static_cast<size_t>(result)); | |
| } | |
| TEST(OgHttp2AdapterTest, InitialSettingsNoExtendedConnect) { | |
| TestVisitor client_visitor; | |
| OgHttp2Adapter::Options client_options; | |
| client_options.perspective = Perspective::kClient; | |
| client_options.max_header_list_bytes = 42; | |
| client_options.allow_extended_connect = false; | |
| auto client_adapter = OgHttp2Adapter::Create(client_visitor, client_options); | |
| TestVisitor server_visitor; | |
| OgHttp2Adapter::Options server_options; | |
| server_options.perspective = Perspective::kServer; | |
| server_options.allow_extended_connect = false; | |
| auto server_adapter = OgHttp2Adapter::Create(server_visitor, server_options); | |
| testing::InSequence s; | |
| // Client sends the connection preface, including the initial SETTINGS. | |
| EXPECT_CALL(client_visitor, OnBeforeFrameSent(SETTINGS, 0, 12, 0x0)); | |
| EXPECT_CALL(client_visitor, OnFrameSent(SETTINGS, 0, 12, 0x0, 0)); | |
| { | |
| int result = client_adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| absl::string_view data = client_visitor.data(); | |
| EXPECT_THAT(data, testing::StartsWith(spdy::kHttp2ConnectionHeaderPrefix)); | |
| data.remove_prefix(strlen(spdy::kHttp2ConnectionHeaderPrefix)); | |
| EXPECT_THAT(data, EqualsFrames({SpdyFrameType::SETTINGS})); | |
| } | |
| // Server sends the connection preface, including the initial SETTINGS. | |
| EXPECT_CALL(server_visitor, OnBeforeFrameSent(SETTINGS, 0, 0, 0x0)); | |
| EXPECT_CALL(server_visitor, OnFrameSent(SETTINGS, 0, 0, 0x0, 0)); | |
| { | |
| int result = server_adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| absl::string_view data = server_visitor.data(); | |
| EXPECT_THAT(data, EqualsFrames({SpdyFrameType::SETTINGS})); | |
| } | |
| // Client processes the server's initial bytes, including initial SETTINGS. | |
| EXPECT_CALL(client_visitor, OnFrameHeader(0, 0, SETTINGS, 0x0)); | |
| EXPECT_CALL(client_visitor, OnSettingsStart()); | |
| EXPECT_CALL(client_visitor, OnSettingsEnd()); | |
| { | |
| const int64_t result = client_adapter->ProcessBytes(server_visitor.data()); | |
| EXPECT_EQ(server_visitor.data().size(), static_cast<size_t>(result)); | |
| } | |
| // Server processes the client's initial bytes, including initial SETTINGS. | |
| EXPECT_CALL(server_visitor, OnFrameHeader(0, 12, SETTINGS, 0x0)); | |
| EXPECT_CALL(server_visitor, OnSettingsStart()); | |
| EXPECT_CALL(server_visitor, | |
| OnSetting(Http2Setting{Http2KnownSettingsId::ENABLE_PUSH, 0u})); | |
| EXPECT_CALL( | |
| server_visitor, | |
| OnSetting(Http2Setting{Http2KnownSettingsId::MAX_HEADER_LIST_SIZE, 42u})); | |
| EXPECT_CALL(server_visitor, OnSettingsEnd()); | |
| { | |
| const int64_t result = server_adapter->ProcessBytes(client_visitor.data()); | |
| EXPECT_EQ(client_visitor.data().size(), static_cast<size_t>(result)); | |
| } | |
| } | |
| TEST(OgHttp2AdapterTest, InitialSettings) { | |
| TestVisitor client_visitor; | |
| OgHttp2Adapter::Options client_options; | |
| client_options.perspective = Perspective::kClient; | |
| client_options.max_header_list_bytes = 42; | |
| ASSERT_TRUE(client_options.allow_extended_connect); | |
| auto client_adapter = OgHttp2Adapter::Create(client_visitor, client_options); | |
| TestVisitor server_visitor; | |
| OgHttp2Adapter::Options server_options; | |
| server_options.perspective = Perspective::kServer; | |
| ASSERT_TRUE(server_options.allow_extended_connect); | |
| auto server_adapter = OgHttp2Adapter::Create(server_visitor, server_options); | |
| testing::InSequence s; | |
| // Client sends the connection preface, including the initial SETTINGS. | |
| EXPECT_CALL(client_visitor, OnBeforeFrameSent(SETTINGS, 0, 12, 0x0)); | |
| EXPECT_CALL(client_visitor, OnFrameSent(SETTINGS, 0, 12, 0x0, 0)); | |
| { | |
| int result = client_adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| absl::string_view data = client_visitor.data(); | |
| EXPECT_THAT(data, testing::StartsWith(spdy::kHttp2ConnectionHeaderPrefix)); | |
| data.remove_prefix(strlen(spdy::kHttp2ConnectionHeaderPrefix)); | |
| EXPECT_THAT(data, EqualsFrames({SpdyFrameType::SETTINGS})); | |
| } | |
| // Server sends the connection preface, including the initial SETTINGS. | |
| EXPECT_CALL(server_visitor, OnBeforeFrameSent(SETTINGS, 0, 6, 0x0)); | |
| EXPECT_CALL(server_visitor, OnFrameSent(SETTINGS, 0, 6, 0x0, 0)); | |
| { | |
| int result = server_adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| absl::string_view data = server_visitor.data(); | |
| EXPECT_THAT(data, EqualsFrames({SpdyFrameType::SETTINGS})); | |
| } | |
| // Client processes the server's initial bytes, including initial SETTINGS. | |
| EXPECT_CALL(client_visitor, OnFrameHeader(0, 6, SETTINGS, 0x0)); | |
| EXPECT_CALL(client_visitor, OnSettingsStart()); | |
| EXPECT_CALL(client_visitor, | |
| OnSetting(Http2Setting{ | |
| Http2KnownSettingsId::ENABLE_CONNECT_PROTOCOL, 1u})); | |
| EXPECT_CALL(client_visitor, OnSettingsEnd()); | |
| { | |
| const int64_t result = client_adapter->ProcessBytes(server_visitor.data()); | |
| EXPECT_EQ(server_visitor.data().size(), static_cast<size_t>(result)); | |
| } | |
| // Server processes the client's initial bytes, including initial SETTINGS. | |
| EXPECT_CALL(server_visitor, OnFrameHeader(0, 12, SETTINGS, 0x0)); | |
| EXPECT_CALL(server_visitor, OnSettingsStart()); | |
| EXPECT_CALL(server_visitor, | |
| OnSetting(Http2Setting{Http2KnownSettingsId::ENABLE_PUSH, 0u})); | |
| EXPECT_CALL( | |
| server_visitor, | |
| OnSetting(Http2Setting{Http2KnownSettingsId::MAX_HEADER_LIST_SIZE, 42u})); | |
| EXPECT_CALL(server_visitor, OnSettingsEnd()); | |
| { | |
| const int64_t result = server_adapter->ProcessBytes(client_visitor.data()); | |
| EXPECT_EQ(client_visitor.data().size(), static_cast<size_t>(result)); | |
| } | |
| } | |
| TEST(OgHttp2AdapterTest, AutomaticSettingsAndPingAcks) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = | |
| TestFrameSequence().ClientPreface().Ping(42).Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // PING | |
| EXPECT_CALL(visitor, OnFrameHeader(0, _, PING, 0)); | |
| EXPECT_CALL(visitor, OnPing(42, false)); | |
| const int64_t read_result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(static_cast<size_t>(read_result), frames.size()); | |
| EXPECT_TRUE(adapter->want_write()); | |
| // Server preface (SETTINGS) | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| // SETTINGS ack | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| // PING ack | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(PING, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(PING, 0, _, ACK_FLAG, 0)); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS, | |
| SpdyFrameType::PING})); | |
| } | |
| TEST(OgHttp2AdapterTest, AutomaticPingAcksDisabled) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| options.auto_ping_ack = false; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = | |
| TestFrameSequence().ClientPreface().Ping(42).Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // PING | |
| EXPECT_CALL(visitor, OnFrameHeader(0, _, PING, 0)); | |
| EXPECT_CALL(visitor, OnPing(42, false)); | |
| const int64_t read_result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(static_cast<size_t>(read_result), frames.size()); | |
| EXPECT_TRUE(adapter->want_write()); | |
| // Server preface (SETTINGS) | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| // SETTINGS ack | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| // No PING ack expected because automatic PING acks are disabled. | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS})); | |
| } | |
| TEST(OgHttp2AdapterTest, InvalidMaxFrameSizeSetting) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = | |
| TestFrameSequence().ClientPreface({{MAX_FRAME_SIZE, 3u}}).Serialize(); | |
| testing::InSequence s; | |
| // Client preface | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 6, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL( | |
| visitor, | |
| OnInvalidFrame(0, Http2VisitorInterface::InvalidFrameError::kProtocol)); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kInvalidSetting)); | |
| const int64_t read_result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(static_cast<size_t>(read_result), frames.size()); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(GOAWAY, 0, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::GOAWAY})); | |
| } | |
| TEST(OgHttp2AdapterTest, InvalidPushSetting) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = | |
| TestFrameSequence().ClientPreface({{ENABLE_PUSH, 3u}}).Serialize(); | |
| testing::InSequence s; | |
| // Client preface | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 6, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL( | |
| visitor, | |
| OnInvalidFrame(0, Http2VisitorInterface::InvalidFrameError::kProtocol)); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kInvalidSetting)); | |
| const int64_t read_result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(static_cast<size_t>(read_result), frames.size()); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(GOAWAY, 0, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::GOAWAY})); | |
| } | |
| TEST(OgHttp2AdapterTest, InvalidConnectProtocolSetting) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface({{ENABLE_CONNECT_PROTOCOL, 3u}}) | |
| .Serialize(); | |
| testing::InSequence s; | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 6, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL( | |
| visitor, | |
| OnInvalidFrame(0, Http2VisitorInterface::InvalidFrameError::kProtocol)); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kInvalidSetting)); | |
| int64_t read_result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(static_cast<size_t>(read_result), frames.size()); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(GOAWAY, 0, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::GOAWAY})); | |
| auto adapter2 = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames2 = TestFrameSequence() | |
| .ClientPreface({{ENABLE_CONNECT_PROTOCOL, 1}}) | |
| .Settings({{ENABLE_CONNECT_PROTOCOL, 0}}) | |
| .Serialize(); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 6, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSetting(Http2Setting{ENABLE_CONNECT_PROTOCOL, 1u})); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 6, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL( | |
| visitor, | |
| OnInvalidFrame(0, Http2VisitorInterface::InvalidFrameError::kProtocol)); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kInvalidSetting)); | |
| read_result = adapter2->ProcessBytes(frames2); | |
| EXPECT_EQ(static_cast<size_t>(read_result), frames2.size()); | |
| EXPECT_TRUE(adapter2->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(GOAWAY, 0, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| adapter2->Send(); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientSetsRemoteMaxStreamOption) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| // Set a lower-than-default initial remote max_concurrent_streams. | |
| options.remote_max_concurrent_streams = 3; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::vector<Header> headers = ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/"}}); | |
| const int32_t stream_id1 = adapter->SubmitRequest(headers, true, nullptr); | |
| const int32_t stream_id2 = adapter->SubmitRequest(headers, true, nullptr); | |
| const int32_t stream_id3 = adapter->SubmitRequest(headers, true, nullptr); | |
| const int32_t stream_id4 = adapter->SubmitRequest(headers, true, nullptr); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id2, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id2, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id3, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id3, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| // The fourth stream is buffered, since only 3 can be in flight to the server. | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| visitor.Clear(); | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .ServerPreface() | |
| .Headers(stream_id1, | |
| {{":status", "200"}, | |
| {"server", "my-fake-server"}, | |
| {"date", "Tue, 6 Apr 2021 12:54:01 GMT"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| // Server preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(stream_id1, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(stream_id1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(stream_id1, ":status", "200")); | |
| EXPECT_CALL(visitor, | |
| OnHeaderForStream(stream_id1, "server", "my-fake-server")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(stream_id1, "date", | |
| "Tue, 6 Apr 2021 12:54:01 GMT")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(stream_id1)); | |
| EXPECT_CALL(visitor, OnEndStream(stream_id1)); | |
| EXPECT_CALL(visitor, | |
| OnCloseStream(stream_id1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(stream_frames.size(), static_cast<size_t>(stream_result)); | |
| ASSERT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x1)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x1, 0)); | |
| // The fourth stream will be started, since the first has completed. | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id4, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id4, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientHandles100Headers) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::vector<Header> headers1 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| const int32_t stream_id1 = adapter->SubmitRequest(headers1, true, nullptr); | |
| ASSERT_GT(stream_id1, 0); | |
| QUICHE_LOG(INFO) << "Created stream: " << stream_id1; | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| visitor.Clear(); | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .ServerPreface() | |
| .Headers(1, {{":status", "100"}}, | |
| /*fin=*/false) | |
| .Ping(101) | |
| .Headers(1, | |
| {{":status", "200"}, | |
| {"server", "my-fake-server"}, | |
| {"date", "Tue, 6 Apr 2021 12:54:01 GMT"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| // Server preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":status", "100")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 8, PING, 0)); | |
| EXPECT_CALL(visitor, OnPing(101, false)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":status", "200")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, "server", "my-fake-server")); | |
| EXPECT_CALL(visitor, | |
| OnHeaderForStream(1, "date", "Tue, 6 Apr 2021 12:54:01 GMT")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnEndStream(1)); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(stream_frames.size(), static_cast<size_t>(stream_result)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(PING, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(PING, 0, _, ACK_FLAG, 0)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::PING})); | |
| } | |
| TEST(OgHttp2AdapterTest, QueuingWindowUpdateAffectsWindow) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| EXPECT_EQ(adapter->GetReceiveWindowSize(), kInitialFlowControlWindowSize); | |
| adapter->SubmitWindowUpdate(0, 10000); | |
| EXPECT_EQ(adapter->GetReceiveWindowSize(), | |
| kInitialFlowControlWindowSize + 10000); | |
| const std::vector<Header> headers = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| const int32_t stream_id = adapter->SubmitRequest(headers, true, nullptr); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(WINDOW_UPDATE, 0, 4, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(WINDOW_UPDATE, 0, 4, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_EQ(adapter->GetStreamReceiveWindowSize(stream_id), | |
| kInitialFlowControlWindowSize); | |
| adapter->SubmitWindowUpdate(1, 20000); | |
| EXPECT_EQ(adapter->GetStreamReceiveWindowSize(stream_id), | |
| kInitialFlowControlWindowSize + 20000); | |
| } | |
| TEST(OgHttp2AdapterTest, AckOfSettingInitialWindowSizeAffectsWindow) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::vector<Header> headers = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| const int32_t stream_id1 = adapter->SubmitRequest(headers, true, nullptr); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| const std::string initial_frames = | |
| TestFrameSequence() | |
| .ServerPreface() | |
| .SettingsAck() // Ack of the client's initial settings. | |
| .Serialize(); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0x0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnSettingsAck); | |
| int64_t parse_result = adapter->ProcessBytes(initial_frames); | |
| EXPECT_EQ(initial_frames.size(), static_cast<size_t>(parse_result)); | |
| EXPECT_EQ(adapter->GetStreamReceiveWindowSize(stream_id1), | |
| kInitialFlowControlWindowSize); | |
| adapter->SubmitSettings({{INITIAL_WINDOW_SIZE, 80000u}}); | |
| // No update for the first stream, yet. | |
| EXPECT_EQ(adapter->GetStreamReceiveWindowSize(stream_id1), | |
| kInitialFlowControlWindowSize); | |
| // Ack of server's initial settings. | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| // Outbound SETTINGS containing INITIAL_WINDOW_SIZE. | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 6, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 6, 0x0, 0)); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| // Still no update, as a SETTINGS ack has not yet been received. | |
| EXPECT_EQ(adapter->GetStreamReceiveWindowSize(stream_id1), | |
| kInitialFlowControlWindowSize); | |
| const std::string settings_ack = | |
| TestFrameSequence().SettingsAck().Serialize(); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnSettingsAck); | |
| parse_result = adapter->ProcessBytes(settings_ack); | |
| EXPECT_EQ(settings_ack.size(), static_cast<size_t>(parse_result)); | |
| // Stream window has been updated. | |
| EXPECT_EQ(adapter->GetStreamReceiveWindowSize(stream_id1), 80000); | |
| const std::vector<Header> headers2 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/two"}}); | |
| const int32_t stream_id2 = adapter->SubmitRequest(headers, true, nullptr); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id2, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id2, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_EQ(adapter->GetStreamReceiveWindowSize(stream_id2), 80000); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientRejects100HeadersWithFin) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::vector<Header> headers1 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| const int32_t stream_id1 = adapter->SubmitRequest(headers1, true, nullptr); | |
| ASSERT_GT(stream_id1, 0); | |
| QUICHE_LOG(INFO) << "Created stream: " << stream_id1; | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| visitor.Clear(); | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .ServerPreface() | |
| .Headers(1, {{":status", "100"}}, /*fin=*/false) | |
| .Headers(1, {{":status", "100"}}, /*fin=*/true) | |
| .Serialize(); | |
| // Server preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":status", "100")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":status", "100")); | |
| EXPECT_CALL(visitor, | |
| OnInvalidFrame( | |
| 1, Http2VisitorInterface::InvalidFrameError::kHttpMessaging)); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(stream_frames.size(), static_cast<size_t>(stream_result)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 1, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(RST_STREAM, 1, _, 0x0, 1)); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::SETTINGS, | |
| SpdyFrameType::RST_STREAM})); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientHandlesFinFollowing100Headers) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::vector<Header> headers1 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| const int32_t stream_id1 = adapter->SubmitRequest(headers1, true, nullptr); | |
| ASSERT_GT(stream_id1, 0); | |
| QUICHE_LOG(INFO) << "Created stream: " << stream_id1; | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| visitor.Clear(); | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .ServerPreface() | |
| .Headers(stream_id1, {{":status", "100"}}, /*fin=*/false) | |
| .Data(stream_id1, "", /*fin=*/true) | |
| .Serialize(); | |
| // Server preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(stream_id1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(stream_id1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(stream_id1, ":status", "100")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(stream_id1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(stream_id1, _, DATA, 1)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(stream_id1, _)); | |
| // Behavior difference: nghttp2 generates a RST_STREAM PROTOCOL_ERROR. | |
| EXPECT_CALL(visitor, OnEndStream(stream_id1)); | |
| EXPECT_CALL(visitor, | |
| OnCloseStream(stream_id1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(stream_frames.size(), static_cast<size_t>(stream_result)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::SETTINGS})); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientRejects100HeadersWithContent) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::vector<Header> headers1 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| const int32_t stream_id1 = adapter->SubmitRequest(headers1, true, nullptr); | |
| ASSERT_GT(stream_id1, 0); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| visitor.Clear(); | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .ServerPreface() | |
| .Headers(1, {{":status", "100"}}, | |
| /*fin=*/false) | |
| .Data(1, "We needed the final headers before data, whoops") | |
| .Serialize(); | |
| // Server preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":status", "100")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, DATA, 0)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(1, _)); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(stream_frames.size(), static_cast<size_t>(stream_result)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 1, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 1, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::SETTINGS, | |
| SpdyFrameType::RST_STREAM})); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientRejects100HeadersWithContentLength) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::vector<Header> headers1 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| const int32_t stream_id1 = adapter->SubmitRequest(headers1, true, nullptr); | |
| ASSERT_GT(stream_id1, 0); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| visitor.Clear(); | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .ServerPreface() | |
| .Headers(1, {{":status", "100"}, {"content-length", "42"}}, | |
| /*fin=*/false) | |
| .Headers(1, | |
| {{":status", "200"}, | |
| {"server", "my-fake-server"}, | |
| {"date", "Tue, 6 Apr 2021 12:54:01 GMT"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| // Server preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":status", "100")); | |
| EXPECT_CALL( | |
| visitor, | |
| OnInvalidFrame(1, Http2VisitorInterface::InvalidFrameError::kHttpHeader)); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(stream_frames.size(), static_cast<size_t>(stream_result)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 1, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 1, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::SETTINGS, | |
| SpdyFrameType::RST_STREAM})); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientHandlesResponseWithContentLengthAndPadding) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::vector<Header> headers1 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| const int32_t stream_id1 = adapter->SubmitRequest(headers1, true, nullptr); | |
| ASSERT_GT(stream_id1, 0); | |
| const std::vector<Header> headers2 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/two"}}); | |
| const int32_t stream_id2 = adapter->SubmitRequest(headers2, true, nullptr); | |
| ASSERT_GT(stream_id2, stream_id1); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id2, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id2, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| visitor.Clear(); | |
| // * Stream 1 sends a response with padding that exceeds the total | |
| // Content-Length in the first DATA frame. | |
| // * Stream 3 sends a response with padding that exceeds the total | |
| // Content-Length in the 2nd frame of 3. | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .ServerPreface() | |
| .Headers(1, {{":status", "200"}, {"content-length", "2"}}, | |
| /*fin=*/false) | |
| .Data(1, "hi", /*fin=*/true, /*padding_length=*/10) | |
| .Headers(3, {{":status", "200"}, {"content-length", "24"}}, | |
| /*fin=*/false) | |
| .Data(3, "hi", false, 11) | |
| .Data(3, " it's nice", false, 12) | |
| .Data(3, " to meet you", true, 13) | |
| .Serialize(); | |
| // Server preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // HEADERS for stream 1 | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":status", "200")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, "content-length", "2")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| // DATA frame with padding for stream 1 | |
| EXPECT_CALL(visitor, OnFrameHeader(1, 2 + 10, DATA, 0x9)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(1, 2 + 10)); | |
| EXPECT_CALL(visitor, OnDataPaddingLength(1, 10)); | |
| EXPECT_CALL(visitor, OnDataForStream(1, "hi")); | |
| // END_STREAM for stream 1 | |
| EXPECT_CALL(visitor, OnEndStream(1)); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| // HEADERS for stream 3 | |
| EXPECT_CALL(visitor, OnFrameHeader(3, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(3)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, ":status", "200")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, "content-length", "24")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(3)); | |
| // DATA frame with padding for stream 3 (1 of 3) | |
| EXPECT_CALL(visitor, OnFrameHeader(3, 2 + 11, DATA, 0x8)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(3, 2 + 11)); | |
| EXPECT_CALL(visitor, OnDataPaddingLength(3, 11)); | |
| EXPECT_CALL(visitor, OnDataForStream(3, "hi")); | |
| // DATA frame with padding for stream 3 (2 of 3) | |
| EXPECT_CALL(visitor, OnFrameHeader(3, 10 + 12, DATA, 0x8)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(3, 10 + 12)); | |
| EXPECT_CALL(visitor, OnDataPaddingLength(3, 12)); | |
| EXPECT_CALL(visitor, OnDataForStream(3, " it's nice")); | |
| // DATA frame with padding for stream 3 (3 of 3) | |
| EXPECT_CALL(visitor, OnFrameHeader(3, 12 + 13, DATA, 0x9)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(3, 12 + 13)); | |
| EXPECT_CALL(visitor, OnDataPaddingLength(3, 13)); | |
| EXPECT_CALL(visitor, OnDataForStream(3, " to meet you")); | |
| // END_STREAM for stream 3 | |
| EXPECT_CALL(visitor, OnEndStream(3)); | |
| EXPECT_CALL(visitor, OnCloseStream(3, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(stream_frames.size(), static_cast<size_t>(stream_result)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({ | |
| SpdyFrameType::SETTINGS, | |
| })); | |
| } | |
| class ResponseCompleteBeforeRequestTest | |
| : public quiche::test::QuicheTestWithParam<std::tuple<bool, bool>> { | |
| public: | |
| bool HasTrailers() const { return std::get<0>(GetParam()); } | |
| bool HasRstStream() const { return std::get<1>(GetParam()); } | |
| }; | |
| INSTANTIATE_TEST_SUITE_P(TrailersAndRstStreamAllCombinations, | |
| ResponseCompleteBeforeRequestTest, | |
| testing::Combine(testing::Bool(), testing::Bool())); | |
| TEST_P(ResponseCompleteBeforeRequestTest, | |
| ClientHandlesResponseBeforeRequestComplete) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::vector<Header> headers1 = | |
| ToHeaders({{":method", "POST"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| const int32_t stream_id1 = adapter->SubmitRequest(headers1, false, nullptr); | |
| ASSERT_GT(stream_id1, 0); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, | |
| OnBeforeFrameSent(HEADERS, stream_id1, _, END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(HEADERS, stream_id1, _, END_HEADERS_FLAG, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| visitor.Clear(); | |
| // * The server sends a complete response on stream 1 before the client has | |
| // finished sending the request. | |
| // * If HasTrailers(), the response ends with trailing HEADERS. | |
| // * If HasRstStream(), the response is followed by a RST_STREAM NO_ERROR, | |
| // as the HTTP/2 spec recommends. | |
| TestFrameSequence response; | |
| response.ServerPreface() | |
| .Headers(1, {{":status", "200"}, {"content-length", "2"}}, | |
| /*fin=*/false) | |
| .Data(1, "hi", /*fin=*/!HasTrailers(), /*padding_length=*/10); | |
| if (HasTrailers()) { | |
| response.Headers(1, {{"my-weird-trailer", "has a value"}}, /*fin=*/true); | |
| } | |
| if (HasRstStream()) { | |
| response.RstStream(1, Http2ErrorCode::HTTP2_NO_ERROR); | |
| } | |
| const std::string stream_frames = response.Serialize(); | |
| // Server preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // HEADERS for stream 1 | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":status", "200")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, "content-length", "2")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| // DATA frame with padding for stream 1 | |
| EXPECT_CALL(visitor, | |
| OnFrameHeader(1, 2 + 10, DATA, HasTrailers() ? 0x8 : 0x9)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(1, 2 + 10)); | |
| EXPECT_CALL(visitor, OnDataPaddingLength(1, 10)); | |
| EXPECT_CALL(visitor, OnDataForStream(1, "hi")); | |
| if (HasTrailers()) { | |
| // Trailers for stream 1 | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, | |
| OnHeaderForStream(1, "my-weird-trailer", "has a value")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| } | |
| // END_STREAM for stream 1 | |
| EXPECT_CALL(visitor, OnEndStream(1)); | |
| if (HasRstStream()) { | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, RST_STREAM, 0)); | |
| EXPECT_CALL(visitor, OnRstStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| } | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(stream_frames.size(), static_cast<size_t>(stream_result)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({ | |
| SpdyFrameType::SETTINGS, | |
| })); | |
| // Stream 1 is done in the request direction. | |
| if (!HasRstStream()) { | |
| visitor.AppendPayloadForStream(1, "final fragment"); | |
| } | |
| visitor.SetEndData(1, true); | |
| adapter->ResumeStream(1); | |
| if (!HasRstStream()) { | |
| EXPECT_CALL(visitor, OnFrameSent(DATA, 1, _, END_STREAM_FLAG, 0)); | |
| // The codec reports Stream 1 as closed. | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| } | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientHandles204WithContent) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::vector<Header> headers1 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| const int32_t stream_id1 = adapter->SubmitRequest(headers1, true, nullptr); | |
| ASSERT_GT(stream_id1, 0); | |
| const std::vector<Header> headers2 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/two"}}); | |
| const int32_t stream_id2 = adapter->SubmitRequest(headers2, true, nullptr); | |
| ASSERT_GT(stream_id2, stream_id1); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id2, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id2, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| visitor.Clear(); | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .ServerPreface() | |
| .Headers(1, {{":status", "204"}, {"content-length", "2"}}, | |
| /*fin=*/false) | |
| .Data(1, "hi") | |
| .Headers(3, {{":status", "204"}}, /*fin=*/false) | |
| .Data(3, "hi") | |
| .Serialize(); | |
| // Server preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":status", "204")); | |
| EXPECT_CALL( | |
| visitor, | |
| OnInvalidFrame(1, Http2VisitorInterface::InvalidFrameError::kHttpHeader)); | |
| EXPECT_CALL(visitor, OnFrameHeader(3, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(3)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, ":status", "204")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(3)); | |
| EXPECT_CALL(visitor, OnFrameHeader(3, _, DATA, 0)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(3, 2)); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(stream_frames.size(), static_cast<size_t>(stream_result)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 1, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 1, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 3, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 3, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(3, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::RST_STREAM, | |
| SpdyFrameType::RST_STREAM})); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientHandles304WithContent) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::vector<Header> headers1 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| const int32_t stream_id1 = adapter->SubmitRequest(headers1, true, nullptr); | |
| ASSERT_GT(stream_id1, 0); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| visitor.Clear(); | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .ServerPreface() | |
| .Headers(1, {{":status", "304"}, {"content-length", "2"}}, | |
| /*fin=*/false) | |
| .Data(1, "hi") | |
| .Serialize(); | |
| // Server preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":status", "304")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, "content-length", "2")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, DATA, 0)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(1, 2)); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(stream_frames.size(), static_cast<size_t>(stream_result)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 1, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 1, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::SETTINGS, | |
| SpdyFrameType::RST_STREAM})); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientHandles304WithContentLength) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::vector<Header> headers = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| const int32_t stream_id = adapter->SubmitRequest(headers, true, nullptr); | |
| ASSERT_GT(stream_id, 0); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| visitor.Clear(); | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .ServerPreface() | |
| .Headers(1, {{":status", "304"}, {"content-length", "2"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| // Server preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":status", "304")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, "content-length", "2")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnEndStream(1)); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(stream_frames.size(), static_cast<size_t>(stream_result)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::SETTINGS})); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientHandlesTrailers) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::vector<Header> headers1 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| const char* kSentinel1 = "arbitrary pointer 1"; | |
| const int32_t stream_id1 = | |
| adapter->SubmitRequest(headers1, true, const_cast<char*>(kSentinel1)); | |
| ASSERT_GT(stream_id1, 0); | |
| QUICHE_LOG(INFO) << "Created stream: " << stream_id1; | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| absl::string_view data = visitor.data(); | |
| EXPECT_THAT(data, testing::StartsWith(spdy::kHttp2ConnectionHeaderPrefix)); | |
| data.remove_prefix(strlen(spdy::kHttp2ConnectionHeaderPrefix)); | |
| EXPECT_THAT(data, | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::HEADERS})); | |
| visitor.Clear(); | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .ServerPreface() | |
| .Headers(1, | |
| {{":status", "200"}, | |
| {"server", "my-fake-server"}, | |
| {"date", "Tue, 6 Apr 2021 12:54:01 GMT"}}, | |
| /*fin=*/false) | |
| .Data(1, "This is the response body.") | |
| .Headers(1, {{"final-status", "A-OK"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| // Server preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":status", "200")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, "server", "my-fake-server")); | |
| EXPECT_CALL(visitor, | |
| OnHeaderForStream(1, "date", "Tue, 6 Apr 2021 12:54:01 GMT")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, 26, DATA, 0)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(1, 26)); | |
| EXPECT_CALL(visitor, OnDataForStream(1, "This is the response body.")); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, "final-status", "A-OK")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnEndStream(1)); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(stream_frames.size(), static_cast<size_t>(stream_result)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::SETTINGS})); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientSendsTrailers) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::vector<Header> headers1 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| const std::string kBody = "This is an example request body."; | |
| visitor.AppendPayloadForStream(1, kBody); | |
| visitor.SetEndData(1, false); | |
| const int32_t stream_id1 = adapter->SubmitRequest(headers1, false, nullptr); | |
| ASSERT_EQ(stream_id1, 1); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id1, _, 0x4)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id1, _, 0x4, 0)); | |
| EXPECT_CALL(visitor, OnFrameSent(DATA, stream_id1, _, 0x0, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| absl::string_view data = visitor.data(); | |
| EXPECT_THAT(data, testing::StartsWith(spdy::kHttp2ConnectionHeaderPrefix)); | |
| data.remove_prefix(strlen(spdy::kHttp2ConnectionHeaderPrefix)); | |
| EXPECT_THAT(data, | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::HEADERS, | |
| SpdyFrameType::DATA})); | |
| visitor.Clear(); | |
| const std::vector<Header> trailers1 = | |
| ToHeaders({{"extra-info", "Trailers are weird but good?"}}); | |
| adapter->SubmitTrailer(stream_id1, trailers1); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| data = visitor.data(); | |
| EXPECT_THAT(data, EqualsFrames({SpdyFrameType::HEADERS})); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientRstStreamWhileHandlingHeaders) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::vector<Header> headers1 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| const char* kSentinel1 = "arbitrary pointer 1"; | |
| const int32_t stream_id1 = | |
| adapter->SubmitRequest(headers1, true, const_cast<char*>(kSentinel1)); | |
| ASSERT_GT(stream_id1, 0); | |
| QUICHE_LOG(INFO) << "Created stream: " << stream_id1; | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| absl::string_view data = visitor.data(); | |
| EXPECT_THAT(data, testing::StartsWith(spdy::kHttp2ConnectionHeaderPrefix)); | |
| data.remove_prefix(strlen(spdy::kHttp2ConnectionHeaderPrefix)); | |
| EXPECT_THAT(data, | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::HEADERS})); | |
| visitor.Clear(); | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .ServerPreface() | |
| .Headers(1, | |
| {{":status", "200"}, | |
| {"server", "my-fake-server"}, | |
| {"date", "Tue, 6 Apr 2021 12:54:01 GMT"}}, | |
| /*fin=*/false) | |
| .Data(1, "This is the response body.") | |
| .Serialize(); | |
| // Server preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":status", "200")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, "server", "my-fake-server")); | |
| EXPECT_CALL(visitor, | |
| OnHeaderForStream(1, "date", "Tue, 6 Apr 2021 12:54:01 GMT")) | |
| .WillOnce(testing::DoAll( | |
| [&adapter]() { | |
| adapter->SubmitRst(1, Http2ErrorCode::REFUSED_STREAM); | |
| }, | |
| testing::Return(OnHeaderResult::HEADER_RST_STREAM))); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(stream_frames.size(), static_cast<size_t>(stream_result)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, stream_id1, 4, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, stream_id1, 4, 0x0, | |
| static_cast<int>(Http2ErrorCode::REFUSED_STREAM))); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::SETTINGS, | |
| SpdyFrameType::RST_STREAM})); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientConnectionErrorWhileHandlingHeaders) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::vector<Header> headers1 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| const char* kSentinel1 = "arbitrary pointer 1"; | |
| const int32_t stream_id1 = | |
| adapter->SubmitRequest(headers1, true, const_cast<char*>(kSentinel1)); | |
| ASSERT_GT(stream_id1, 0); | |
| QUICHE_LOG(INFO) << "Created stream: " << stream_id1; | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| absl::string_view data = visitor.data(); | |
| EXPECT_THAT(data, testing::StartsWith(spdy::kHttp2ConnectionHeaderPrefix)); | |
| data.remove_prefix(strlen(spdy::kHttp2ConnectionHeaderPrefix)); | |
| EXPECT_THAT(data, | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::HEADERS})); | |
| visitor.Clear(); | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .ServerPreface() | |
| .Headers(1, | |
| {{":status", "200"}, | |
| {"server", "my-fake-server"}, | |
| {"date", "Tue, 6 Apr 2021 12:54:01 GMT"}}, | |
| /*fin=*/false) | |
| .Data(1, "This is the response body.") | |
| .Serialize(); | |
| // Server preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":status", "200")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, "server", "my-fake-server")); | |
| EXPECT_CALL(visitor, | |
| OnHeaderForStream(1, "date", "Tue, 6 Apr 2021 12:54:01 GMT")) | |
| .WillOnce(testing::Return(OnHeaderResult::HEADER_CONNECTION_ERROR)); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kHeaderError)); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_LT(stream_result, 0); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(GOAWAY, 0, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::INTERNAL_ERROR))); | |
| EXPECT_TRUE(adapter->want_write()); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::GOAWAY})); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientConnectionErrorWhileHandlingHeadersOnly) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::vector<Header> headers1 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| const char* kSentinel1 = "arbitrary pointer 1"; | |
| const int32_t stream_id1 = | |
| adapter->SubmitRequest(headers1, true, const_cast<char*>(kSentinel1)); | |
| ASSERT_GT(stream_id1, 0); | |
| QUICHE_LOG(INFO) << "Created stream: " << stream_id1; | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| absl::string_view data = visitor.data(); | |
| EXPECT_THAT(data, testing::StartsWith(spdy::kHttp2ConnectionHeaderPrefix)); | |
| data.remove_prefix(strlen(spdy::kHttp2ConnectionHeaderPrefix)); | |
| EXPECT_THAT(data, | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::HEADERS})); | |
| visitor.Clear(); | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .ServerPreface() | |
| .Headers(1, | |
| {{":status", "200"}, | |
| {"server", "my-fake-server"}, | |
| {"date", "Tue, 6 Apr 2021 12:54:01 GMT"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| // Server preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":status", "200")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, "server", "my-fake-server")); | |
| EXPECT_CALL(visitor, | |
| OnHeaderForStream(1, "date", "Tue, 6 Apr 2021 12:54:01 GMT")) | |
| .WillOnce(testing::Return(OnHeaderResult::HEADER_CONNECTION_ERROR)); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kHeaderError)); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_LT(stream_result, 0); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(GOAWAY, 0, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::INTERNAL_ERROR))); | |
| EXPECT_TRUE(adapter->want_write()); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::GOAWAY})); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientRejectsHeaders) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::vector<Header> headers1 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| const char* kSentinel1 = "arbitrary pointer 1"; | |
| const int32_t stream_id1 = | |
| adapter->SubmitRequest(headers1, true, const_cast<char*>(kSentinel1)); | |
| ASSERT_GT(stream_id1, 0); | |
| QUICHE_LOG(INFO) << "Created stream: " << stream_id1; | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| absl::string_view data = visitor.data(); | |
| EXPECT_THAT(data, testing::StartsWith(spdy::kHttp2ConnectionHeaderPrefix)); | |
| data.remove_prefix(strlen(spdy::kHttp2ConnectionHeaderPrefix)); | |
| EXPECT_THAT(data, | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::HEADERS})); | |
| visitor.Clear(); | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .ServerPreface() | |
| .Headers(1, | |
| {{":status", "200"}, | |
| {"server", "my-fake-server"}, | |
| {"date", "Tue, 6 Apr 2021 12:54:01 GMT"}}, | |
| /*fin=*/false) | |
| .Data(1, "This is the response body.") | |
| .Serialize(); | |
| // Server preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)) | |
| .WillOnce(testing::Return(false)); | |
| // Rejecting headers leads to a connection error. | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kHeaderError)); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_LT(stream_result, 0); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(GOAWAY, 0, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::INTERNAL_ERROR))); | |
| EXPECT_TRUE(adapter->want_write()); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::GOAWAY})); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientHandlesSmallerHpackHeaderTableSetting) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::vector<Header> headers1 = ToHeaders({ | |
| {":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}, | |
| {"x-i-do-not-like", "green eggs and ham"}, | |
| {"x-i-will-not-eat-them", "here or there, in a box, with a fox"}, | |
| {"x-like-them-in-a-house", "no"}, | |
| {"x-like-them-with-a-mouse", "no"}, | |
| }); | |
| const int32_t stream_id1 = adapter->SubmitRequest(headers1, true, nullptr); | |
| ASSERT_GT(stream_id1, 0); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| visitor.Clear(); | |
| EXPECT_GT(adapter->GetHpackEncoderDynamicTableSize(), 100); | |
| const std::string stream_frames = | |
| TestFrameSequence().Settings({{HEADER_TABLE_SIZE, 100u}}).Serialize(); | |
| // Server preface (SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 6, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSetting(Http2Setting{HEADER_TABLE_SIZE, 100u})); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(stream_frames.size(), static_cast<size_t>(stream_result)); | |
| EXPECT_EQ(adapter->GetHpackEncoderDynamicTableCapacity(), 100); | |
| EXPECT_LE(adapter->GetHpackEncoderDynamicTableSize(), 100); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientHandlesLargerHpackHeaderTableSetting) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| visitor.Clear(); | |
| EXPECT_EQ(adapter->GetHpackEncoderDynamicTableCapacity(), 4096); | |
| const std::string stream_frames = | |
| TestFrameSequence().Settings({{HEADER_TABLE_SIZE, 40960u}}).Serialize(); | |
| // Server preface (SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 6, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSetting(Http2Setting{HEADER_TABLE_SIZE, 40960u})); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(stream_frames.size(), static_cast<size_t>(stream_result)); | |
| // The increased capacity will not be applied until a SETTINGS ack is | |
| // serialized. | |
| EXPECT_EQ(adapter->GetHpackEncoderDynamicTableCapacity(), 4096); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| visitor.Clear(); | |
| EXPECT_EQ(adapter->GetHpackEncoderDynamicTableCapacity(), 40960); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientSendsHpackHeaderTableSetting) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::vector<Header> headers1 = ToHeaders({ | |
| {":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}, | |
| }); | |
| const int32_t stream_id1 = adapter->SubmitRequest(headers1, true, nullptr); | |
| ASSERT_GT(stream_id1, 0); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| visitor.Clear(); | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .ServerPreface() | |
| .SettingsAck() | |
| .Headers( | |
| 1, | |
| {{":status", "200"}, | |
| {"server", "my-fake-server"}, | |
| {"date", "Tue, 6 Apr 2021 12:54:01 GMT"}, | |
| {"x-i-do-not-like", "green eggs and ham"}, | |
| {"x-i-will-not-eat-them", "here or there, in a box, with a fox"}, | |
| {"x-like-them-in-a-house", "no"}, | |
| {"x-like-them-with-a-mouse", "no"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| // Server preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Server acks client's initial SETTINGS. | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 1)); | |
| EXPECT_CALL(visitor, OnSettingsAck()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, _, _)).Times(7); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnEndStream(1)); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(stream_frames.size(), static_cast<size_t>(stream_result)); | |
| EXPECT_GT(adapter->GetHpackDecoderSizeLimit(), 100); | |
| // Submit settings, check decoder table size. | |
| adapter->SubmitSettings({{HEADER_TABLE_SIZE, 100u}}); | |
| EXPECT_GT(adapter->GetHpackDecoderSizeLimit(), 100); | |
| // Server preface SETTINGS ack | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| // SETTINGS with the new header table size value | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 6, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 6, 0x0, 0)); | |
| // Because the client has not yet seen an ack from the server for the SETTINGS | |
| // with header table size, it has not applied the new value. | |
| EXPECT_GT(adapter->GetHpackDecoderSizeLimit(), 100); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| visitor.Clear(); | |
| const std::vector<Header> headers2 = ToHeaders({ | |
| {":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/two"}, | |
| }); | |
| const int32_t stream_id2 = adapter->SubmitRequest(headers2, true, nullptr); | |
| ASSERT_GT(stream_id2, stream_id1); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id2, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id2, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| visitor.Clear(); | |
| const std::string response_frames = | |
| TestFrameSequence() | |
| .Headers(stream_id2, | |
| {{":status", "200"}, | |
| {"server", "my-fake-server"}, | |
| {"date", "Tue, 6 Apr 2021 12:54:01 GMT"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| EXPECT_CALL(visitor, OnFrameHeader(stream_id2, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(stream_id2)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(stream_id2, _, _)).Times(3); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(stream_id2)); | |
| EXPECT_CALL(visitor, OnEndStream(stream_id2)); | |
| EXPECT_CALL(visitor, | |
| OnCloseStream(stream_id2, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| const int64_t response_result = adapter->ProcessBytes(response_frames); | |
| EXPECT_EQ(response_frames.size(), static_cast<size_t>(response_result)); | |
| // Still no ack for the outbound settings. | |
| EXPECT_GT(adapter->GetHpackDecoderSizeLimit(), 100); | |
| const std::string settings_ack = | |
| TestFrameSequence().SettingsAck().Serialize(); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 1)); | |
| EXPECT_CALL(visitor, OnSettingsAck()); | |
| const int64_t ack_result = adapter->ProcessBytes(settings_ack); | |
| EXPECT_EQ(settings_ack.size(), static_cast<size_t>(ack_result)); | |
| // Ack has finally arrived. | |
| EXPECT_EQ(adapter->GetHpackDecoderSizeLimit(), 100); | |
| } | |
| // TODO(birenroy): Validate headers and re-enable this test. The library should | |
| // invoke OnErrorDebug() with an error message for the invalid header. The | |
| // library should also invoke OnInvalidFrame() for the invalid HEADERS frame. | |
| TEST(OgHttp2AdapterTest, DISABLED_ClientHandlesInvalidTrailers) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::vector<Header> headers1 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| const char* kSentinel1 = "arbitrary pointer 1"; | |
| const int32_t stream_id1 = | |
| adapter->SubmitRequest(headers1, true, const_cast<char*>(kSentinel1)); | |
| ASSERT_GT(stream_id1, 0); | |
| QUICHE_LOG(INFO) << "Created stream: " << stream_id1; | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| absl::string_view data = visitor.data(); | |
| EXPECT_THAT(data, testing::StartsWith(spdy::kHttp2ConnectionHeaderPrefix)); | |
| data.remove_prefix(strlen(spdy::kHttp2ConnectionHeaderPrefix)); | |
| EXPECT_THAT(data, | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::HEADERS})); | |
| visitor.Clear(); | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .ServerPreface() | |
| .Headers(1, | |
| {{":status", "200"}, | |
| {"server", "my-fake-server"}, | |
| {"date", "Tue, 6 Apr 2021 12:54:01 GMT"}}, | |
| /*fin=*/false) | |
| .Data(1, "This is the response body.") | |
| .Headers(1, {{":bad-status", "9000"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| // Server preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":status", "200")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, "server", "my-fake-server")); | |
| EXPECT_CALL(visitor, | |
| OnHeaderForStream(1, "date", "Tue, 6 Apr 2021 12:54:01 GMT")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, 26, DATA, 0)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(1, 26)); | |
| EXPECT_CALL(visitor, OnDataForStream(1, "This is the response body.")); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| // Bad status trailer will cause a PROTOCOL_ERROR. The header is never | |
| // delivered in an OnHeaderForStream callback. | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(stream_frames.size(), static_cast<size_t>(stream_result)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, stream_id1, 4, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(RST_STREAM, stream_id1, 4, 0x0, 1)); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::PROTOCOL_ERROR)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::SETTINGS, | |
| SpdyFrameType::RST_STREAM})); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientStartsShutdown) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| EXPECT_FALSE(adapter->want_write()); | |
| // No-op (except for logging) for a client implementation. | |
| adapter->SubmitShutdownNotice(); | |
| EXPECT_FALSE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| absl::string_view serialized = visitor.data(); | |
| EXPECT_THAT(serialized, | |
| testing::StartsWith(spdy::kHttp2ConnectionHeaderPrefix)); | |
| serialized.remove_prefix(strlen(spdy::kHttp2ConnectionHeaderPrefix)); | |
| EXPECT_THAT(serialized, EqualsFrames({SpdyFrameType::SETTINGS})); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientSubmitsGoAwayAfterRequestOptionEnabled) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| options.send_goaway_as_client = true; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::vector<Header> headers = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| const int32_t stream_id = adapter->SubmitRequest(headers, true, nullptr); | |
| ASSERT_GT(stream_id, 0); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| absl::string_view data = visitor.data(); | |
| EXPECT_THAT(data, testing::StartsWith(spdy::kHttp2ConnectionHeaderPrefix)); | |
| data.remove_prefix(strlen(spdy::kHttp2ConnectionHeaderPrefix)); | |
| EXPECT_THAT(data, | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::HEADERS})); | |
| visitor.Clear(); | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .ServerPreface() | |
| .Headers(stream_id, {{":status", "200"}}, /*fin=*/true) | |
| .Serialize(); | |
| // Server preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(stream_id, _, HEADERS, | |
| END_HEADERS_FLAG | END_STREAM_FLAG)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(stream_id)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(stream_id, ":status", "200")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(stream_id)); | |
| EXPECT_CALL(visitor, OnEndStream(stream_id)); | |
| EXPECT_CALL(visitor, | |
| OnCloseStream(stream_id, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(stream_frames.size(), static_cast<size_t>(stream_result)); | |
| // Now that the stream has been processed, the highest stream ID should be | |
| // updated. Send a GOAWAY with this stream ID. | |
| EXPECT_EQ(adapter->GetHighestReceivedStreamId(), stream_id); | |
| adapter->SubmitGoAway(adapter->GetHighestReceivedStreamId(), | |
| Http2ErrorCode::HTTP2_NO_ERROR, "opaque_data"); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(GOAWAY, 0, _, 0x0, 0)); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::GOAWAY})); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientSubmitsGoAwayAfterRequestOptionDisabled) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| options.send_goaway_as_client = false; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::vector<Header> headers = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| const int32_t stream_id = adapter->SubmitRequest(headers, true, nullptr); | |
| ASSERT_GT(stream_id, 0); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| absl::string_view data = visitor.data(); | |
| EXPECT_THAT(data, testing::StartsWith(spdy::kHttp2ConnectionHeaderPrefix)); | |
| data.remove_prefix(strlen(spdy::kHttp2ConnectionHeaderPrefix)); | |
| EXPECT_THAT(data, | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::HEADERS})); | |
| visitor.Clear(); | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .ServerPreface() | |
| .Headers(stream_id, {{":status", "200"}}, /*fin=*/true) | |
| .Serialize(); | |
| // Server preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(stream_id, _, HEADERS, | |
| END_HEADERS_FLAG | END_STREAM_FLAG)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(stream_id)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(stream_id, ":status", "200")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(stream_id)); | |
| EXPECT_CALL(visitor, OnEndStream(stream_id)); | |
| EXPECT_CALL(visitor, | |
| OnCloseStream(stream_id, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(stream_frames.size(), static_cast<size_t>(stream_result)); | |
| // Now that the stream has been processed, the highest stream ID should be | |
| // updated. Attempting to send a GOAWAY with this stream ID should be a no-op | |
| // because the option is disabled. | |
| EXPECT_EQ(adapter->GetHighestReceivedStreamId(), stream_id); | |
| adapter->SubmitGoAway(adapter->GetHighestReceivedStreamId(), | |
| Http2ErrorCode::HTTP2_NO_ERROR, "opaque_data"); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::SETTINGS})); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientReceivesGoAway) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::vector<Header> headers1 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| const int32_t stream_id1 = adapter->SubmitRequest(headers1, true, nullptr); | |
| ASSERT_GT(stream_id1, 0); | |
| const std::vector<Header> headers2 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/two"}}); | |
| const int32_t stream_id2 = adapter->SubmitRequest(headers2, true, nullptr); | |
| ASSERT_GT(stream_id2, stream_id1); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id2, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id2, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| absl::string_view data = visitor.data(); | |
| EXPECT_THAT(data, testing::StartsWith(spdy::kHttp2ConnectionHeaderPrefix)); | |
| data.remove_prefix(strlen(spdy::kHttp2ConnectionHeaderPrefix)); | |
| EXPECT_THAT(data, | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::HEADERS, | |
| SpdyFrameType::HEADERS})); | |
| visitor.Clear(); | |
| // Submit a pending WINDOW_UPDATE for a stream that will be closed due to | |
| // GOAWAY. The WINDOW_UPDATE should not be sent. | |
| adapter->SubmitWindowUpdate(3, 42); | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .ServerPreface() | |
| .RstStream(1, Http2ErrorCode::ENHANCE_YOUR_CALM) | |
| .GoAway(1, Http2ErrorCode::INTERNAL_ERROR, "indigestion") | |
| .WindowUpdate(0, 42) | |
| .WindowUpdate(1, 42) | |
| .Serialize(); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, 4, RST_STREAM, 0)); | |
| EXPECT_CALL(visitor, OnRstStream(1, Http2ErrorCode::ENHANCE_YOUR_CALM)); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::ENHANCE_YOUR_CALM)); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, _, GOAWAY, 0)); | |
| // Currently, oghttp2 does not pass the opaque data to the visitor. | |
| EXPECT_CALL(visitor, OnGoAway(1, Http2ErrorCode::INTERNAL_ERROR, "")); | |
| EXPECT_CALL(visitor, OnCloseStream(3, Http2ErrorCode::REFUSED_STREAM)); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 4, WINDOW_UPDATE, 0)); | |
| EXPECT_CALL(visitor, OnWindowUpdate(0, 42)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, 4, WINDOW_UPDATE, 0)); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(stream_frames.size(), static_cast<size_t>(stream_result)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::SETTINGS})); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientReceivesMultipleGoAways) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::vector<Header> headers1 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| const int32_t stream_id1 = adapter->SubmitRequest(headers1, true, nullptr); | |
| ASSERT_GT(stream_id1, 0); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| absl::string_view data = visitor.data(); | |
| EXPECT_THAT(data, testing::StartsWith(spdy::kHttp2ConnectionHeaderPrefix)); | |
| data.remove_prefix(strlen(spdy::kHttp2ConnectionHeaderPrefix)); | |
| EXPECT_THAT(data, | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::HEADERS})); | |
| visitor.Clear(); | |
| const std::string initial_frames = | |
| TestFrameSequence() | |
| .ServerPreface() | |
| .GoAway(kMaxStreamId, Http2ErrorCode::INTERNAL_ERROR, "indigestion") | |
| .Serialize(); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, _, GOAWAY, 0)); | |
| // Currently, oghttp2 does not pass the opaque data to the visitor. | |
| EXPECT_CALL(visitor, | |
| OnGoAway(kMaxStreamId, Http2ErrorCode::INTERNAL_ERROR, "")); | |
| const int64_t initial_result = adapter->ProcessBytes(initial_frames); | |
| EXPECT_EQ(initial_frames.size(), static_cast<size_t>(initial_result)); | |
| // Submit a WINDOW_UPDATE for the open stream. Because the stream is below the | |
| // GOAWAY's last_stream_id, it should be sent. | |
| adapter->SubmitWindowUpdate(1, 42); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(WINDOW_UPDATE, 1, 4, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(WINDOW_UPDATE, 1, 4, 0x0, 0)); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::SETTINGS, | |
| SpdyFrameType::WINDOW_UPDATE})); | |
| visitor.Clear(); | |
| const std::string final_frames = | |
| TestFrameSequence() | |
| .GoAway(0, Http2ErrorCode::INTERNAL_ERROR, "indigestion") | |
| .Serialize(); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, _, GOAWAY, 0)); | |
| // Currently, oghttp2 does not pass the opaque data to the visitor. | |
| EXPECT_CALL(visitor, OnGoAway(0, Http2ErrorCode::INTERNAL_ERROR, "")); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::REFUSED_STREAM)); | |
| const int64_t final_result = adapter->ProcessBytes(final_frames); | |
| EXPECT_EQ(final_frames.size(), static_cast<size_t>(final_result)); | |
| EXPECT_FALSE(adapter->want_write()); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), testing::IsEmpty()); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientReceivesMultipleGoAwaysWithIncreasingStreamId) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::vector<Header> headers1 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| const int32_t stream_id1 = adapter->SubmitRequest(headers1, true, nullptr); | |
| ASSERT_GT(stream_id1, 0); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| absl::string_view data = visitor.data(); | |
| EXPECT_THAT(data, testing::StartsWith(spdy::kHttp2ConnectionHeaderPrefix)); | |
| data.remove_prefix(strlen(spdy::kHttp2ConnectionHeaderPrefix)); | |
| EXPECT_THAT(data, | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::HEADERS})); | |
| visitor.Clear(); | |
| const std::string frames = | |
| TestFrameSequence() | |
| .ServerPreface() | |
| .GoAway(0, Http2ErrorCode::HTTP2_NO_ERROR, "") | |
| .GoAway(0, Http2ErrorCode::ENHANCE_YOUR_CALM, "") | |
| .GoAway(1, Http2ErrorCode::INTERNAL_ERROR, "") | |
| .Serialize(); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, _, GOAWAY, 0)); | |
| EXPECT_CALL(visitor, OnGoAway(0, Http2ErrorCode::HTTP2_NO_ERROR, "")); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::REFUSED_STREAM)); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, _, GOAWAY, 0)); | |
| EXPECT_CALL(visitor, OnGoAway(0, Http2ErrorCode::ENHANCE_YOUR_CALM, "")); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, _, GOAWAY, 0)); | |
| EXPECT_CALL( | |
| visitor, | |
| OnInvalidFrame(0, Http2VisitorInterface::InvalidFrameError::kProtocol)); | |
| // The oghttp2 stack also signals the error via OnConnectionError(). | |
| EXPECT_CALL(visitor, | |
| OnConnectionError(ConnectionError::kInvalidGoAwayLastStreamId)); | |
| const int64_t frames_result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(frames.size(), static_cast<size_t>(frames_result)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(GOAWAY, 0, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| EXPECT_TRUE(adapter->want_write()); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::GOAWAY})); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientReceivesGoAwayWithPendingStreams) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| absl::string_view data = visitor.data(); | |
| EXPECT_THAT(data, testing::StartsWith(spdy::kHttp2ConnectionHeaderPrefix)); | |
| data.remove_prefix(strlen(spdy::kHttp2ConnectionHeaderPrefix)); | |
| EXPECT_THAT(data, EqualsFrames({SpdyFrameType::SETTINGS})); | |
| visitor.Clear(); | |
| const std::string initial_frames = | |
| TestFrameSequence() | |
| .ServerPreface({{MAX_CONCURRENT_STREAMS, 1}}) | |
| .Serialize(); | |
| // Server preface (SETTINGS with MAX_CONCURRENT_STREAMS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 6, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSetting); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| const int64_t initial_result = adapter->ProcessBytes(initial_frames); | |
| EXPECT_EQ(initial_frames.size(), static_cast<size_t>(initial_result)); | |
| const std::vector<Header> headers1 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| const int32_t stream_id1 = adapter->SubmitRequest(headers1, true, nullptr); | |
| ASSERT_GT(stream_id1, 0); | |
| const std::vector<Header> headers2 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/two"}}); | |
| const int32_t stream_id2 = adapter->SubmitRequest(headers2, true, nullptr); | |
| ASSERT_GT(stream_id2, stream_id1); | |
| // The second request should be pending because of | |
| // SETTINGS_MAX_CONCURRENT_STREAMS. | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::HEADERS})); | |
| visitor.Clear(); | |
| // Let the client receive a GOAWAY and raise MAX_CONCURRENT_STREAMS. Even | |
| // though the GOAWAY last_stream_id is higher than the pending request's | |
| // stream ID, pending request should not be sent. | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .GoAway(kMaxStreamId, Http2ErrorCode::INTERNAL_ERROR, "indigestion") | |
| .Settings({{MAX_CONCURRENT_STREAMS, 42u}}) | |
| .Serialize(); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, _, GOAWAY, 0)); | |
| EXPECT_CALL(visitor, | |
| OnGoAway(kMaxStreamId, Http2ErrorCode::INTERNAL_ERROR, "")); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 6, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSetting(Http2Setting{MAX_CONCURRENT_STREAMS, 42u})); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(stream_frames.size(), static_cast<size_t>(stream_result)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| // We close the pending stream on the next write attempt. | |
| EXPECT_CALL(visitor, OnCloseStream(3, Http2ErrorCode::REFUSED_STREAM)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::SETTINGS})); | |
| visitor.Clear(); | |
| // Requests submitted after receiving the GOAWAY should not be sent. | |
| const std::vector<Header> headers3 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/three"}}); | |
| const int32_t stream_id3 = adapter->SubmitRequest(headers3, true, nullptr); | |
| ASSERT_GT(stream_id3, stream_id2); | |
| // We close the pending stream on the next write attempt. | |
| EXPECT_CALL(visitor, OnCloseStream(5, Http2ErrorCode::REFUSED_STREAM)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), testing::IsEmpty()); | |
| EXPECT_FALSE(adapter->want_write()); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientFailsOnGoAway) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::vector<Header> headers1 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| const char* kSentinel1 = "arbitrary pointer 1"; | |
| const int32_t stream_id1 = | |
| adapter->SubmitRequest(headers1, true, const_cast<char*>(kSentinel1)); | |
| ASSERT_GT(stream_id1, 0); | |
| QUICHE_LOG(INFO) << "Created stream: " << stream_id1; | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| absl::string_view data = visitor.data(); | |
| EXPECT_THAT(data, testing::StartsWith(spdy::kHttp2ConnectionHeaderPrefix)); | |
| data.remove_prefix(strlen(spdy::kHttp2ConnectionHeaderPrefix)); | |
| EXPECT_THAT(data, | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::HEADERS})); | |
| visitor.Clear(); | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .ServerPreface() | |
| .Headers(1, | |
| {{":status", "200"}, | |
| {"server", "my-fake-server"}, | |
| {"date", "Tue, 6 Apr 2021 12:54:01 GMT"}}, | |
| /*fin=*/false) | |
| .GoAway(1, Http2ErrorCode::INTERNAL_ERROR, "indigestion") | |
| .Data(1, "This is the response body.") | |
| .Serialize(); | |
| // Server preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":status", "200")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, "server", "my-fake-server")); | |
| EXPECT_CALL(visitor, | |
| OnHeaderForStream(1, "date", "Tue, 6 Apr 2021 12:54:01 GMT")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, _, GOAWAY, 0)); | |
| // TODO(birenroy): Pass the GOAWAY opaque data through the oghttp2 stack. | |
| EXPECT_CALL(visitor, OnGoAway(1, Http2ErrorCode::INTERNAL_ERROR, "")) | |
| .WillOnce(testing::Return(false)); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kParseError)); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_LT(stream_result, 0); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(GOAWAY, 0, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::INTERNAL_ERROR))); | |
| EXPECT_TRUE(adapter->want_write()); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::GOAWAY})); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientRejects101Response) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::vector<Header> headers1 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}, | |
| {"upgrade", "new-protocol"}}); | |
| const int32_t stream_id1 = adapter->SubmitRequest(headers1, true, nullptr); | |
| ASSERT_GT(stream_id1, 0); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| absl::string_view data = visitor.data(); | |
| EXPECT_THAT(data, testing::StartsWith(spdy::kHttp2ConnectionHeaderPrefix)); | |
| data.remove_prefix(strlen(spdy::kHttp2ConnectionHeaderPrefix)); | |
| EXPECT_THAT(data, | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::HEADERS})); | |
| visitor.Clear(); | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .ServerPreface() | |
| .Headers(1, | |
| {{":status", "101"}, | |
| {"server", "my-fake-server"}, | |
| {"date", "Tue, 6 Apr 2021 12:54:01 GMT"}}, | |
| /*fin=*/false) | |
| .Serialize(); | |
| // Server preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL( | |
| visitor, | |
| OnInvalidFrame(1, Http2VisitorInterface::InvalidFrameError::kHttpHeader)); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(static_cast<int64_t>(stream_frames.size()), stream_result); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 1, 4, 0x0)); | |
| EXPECT_CALL( | |
| visitor, | |
| OnFrameSent(RST_STREAM, 1, 4, 0x0, | |
| static_cast<uint32_t>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::SETTINGS, | |
| SpdyFrameType::RST_STREAM})); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientObeysMaxConcurrentStreams) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| EXPECT_FALSE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| // Even though the user has not queued any frames for the session, it should | |
| // still send the connection preface. | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| absl::string_view serialized = visitor.data(); | |
| EXPECT_THAT(serialized, | |
| testing::StartsWith(spdy::kHttp2ConnectionHeaderPrefix)); | |
| serialized.remove_prefix(strlen(spdy::kHttp2ConnectionHeaderPrefix)); | |
| // Initial SETTINGS. | |
| EXPECT_THAT(serialized, EqualsFrames({SpdyFrameType::SETTINGS})); | |
| visitor.Clear(); | |
| const std::string initial_frames = | |
| TestFrameSequence() | |
| .ServerPreface({{MAX_CONCURRENT_STREAMS, 1}}) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Server preface (SETTINGS with MAX_CONCURRENT_STREAMS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 6, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSetting); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| const int64_t initial_result = adapter->ProcessBytes(initial_frames); | |
| EXPECT_EQ(initial_frames.size(), static_cast<size_t>(initial_result)); | |
| // Session will want to write a SETTINGS ack. | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::SETTINGS})); | |
| visitor.Clear(); | |
| const std::string kBody = "This is an example request body."; | |
| visitor.AppendPayloadForStream(1, kBody); | |
| visitor.SetEndData(1, true); | |
| const int stream_id = | |
| adapter->SubmitRequest(ToHeaders({{":method", "POST"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}), | |
| false, nullptr); | |
| ASSERT_EQ(stream_id, 1); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, | |
| OnBeforeFrameSent(HEADERS, stream_id, _, END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id, _, END_HEADERS_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnFrameSent(DATA, stream_id, _, END_STREAM_FLAG, 0)); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::HEADERS, SpdyFrameType::DATA})); | |
| EXPECT_THAT(visitor.data(), testing::HasSubstr(kBody)); | |
| visitor.Clear(); | |
| EXPECT_FALSE(adapter->want_write()); | |
| const int next_stream_id = | |
| adapter->SubmitRequest(ToHeaders({{":method", "POST"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/two"}}), | |
| true, nullptr); | |
| // A new pending stream is created, but because of MAX_CONCURRENT_STREAMS, the | |
| // session should not want to write it at the moment. | |
| EXPECT_GT(next_stream_id, stream_id); | |
| EXPECT_FALSE(adapter->want_write()); | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .Headers(stream_id, | |
| {{":status", "200"}, | |
| {"server", "my-fake-server"}, | |
| {"date", "Tue, 6 Apr 2021 12:54:01 GMT"}}, | |
| /*fin=*/false) | |
| .Data(stream_id, "This is the response body.", /*fin=*/true) | |
| .Serialize(); | |
| EXPECT_CALL(visitor, OnFrameHeader(stream_id, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(stream_id)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(stream_id, ":status", "200")); | |
| EXPECT_CALL(visitor, | |
| OnHeaderForStream(stream_id, "server", "my-fake-server")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(stream_id, "date", | |
| "Tue, 6 Apr 2021 12:54:01 GMT")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(stream_id)); | |
| EXPECT_CALL(visitor, OnFrameHeader(stream_id, 26, DATA, END_STREAM_FLAG)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(stream_id, 26)); | |
| EXPECT_CALL(visitor, | |
| OnDataForStream(stream_id, "This is the response body.")); | |
| EXPECT_CALL(visitor, OnEndStream(stream_id)); | |
| EXPECT_CALL(visitor, | |
| OnCloseStream(stream_id, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| // The first stream should close, which should make the session want to write | |
| // the next stream. | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(stream_frames.size(), static_cast<size_t>(stream_result)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, next_stream_id, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, next_stream_id, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::HEADERS})); | |
| visitor.Clear(); | |
| EXPECT_FALSE(adapter->want_write()); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientReceivesInitialWindowSetting) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::string initial_frames = | |
| TestFrameSequence() | |
| .Settings({{INITIAL_WINDOW_SIZE, 80000u}}) | |
| .WindowUpdate(0, 65536) | |
| .Serialize(); | |
| // Server preface (SETTINGS with INITIAL_STREAM_WINDOW) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 6, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSetting(Http2Setting{INITIAL_WINDOW_SIZE, 80000u})); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 4, WINDOW_UPDATE, 0)); | |
| EXPECT_CALL(visitor, OnWindowUpdate(0, 65536)); | |
| const int64_t initial_result = adapter->ProcessBytes(initial_frames); | |
| EXPECT_EQ(initial_frames.size(), static_cast<size_t>(initial_result)); | |
| // Session will want to write a SETTINGS ack. | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| int64_t result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| absl::string_view serialized = visitor.data(); | |
| EXPECT_THAT(serialized, | |
| testing::StartsWith(spdy::kHttp2ConnectionHeaderPrefix)); | |
| serialized.remove_prefix(strlen(spdy::kHttp2ConnectionHeaderPrefix)); | |
| EXPECT_THAT(serialized, | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS})); | |
| visitor.Clear(); | |
| const std::string kLongBody = std::string(81000, 'c'); | |
| visitor.AppendPayloadForStream(1, kLongBody); | |
| visitor.SetEndData(1, true); | |
| const int stream_id = | |
| adapter->SubmitRequest(ToHeaders({{":method", "POST"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}), | |
| false, nullptr); | |
| EXPECT_GT(stream_id, 0); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id, _, 0x4)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id, _, 0x4, 0)); | |
| // The client can send more than 4 frames (65536 bytes) of data. | |
| EXPECT_CALL(visitor, OnFrameSent(DATA, stream_id, 16384, 0x0, 0)).Times(4); | |
| EXPECT_CALL(visitor, OnFrameSent(DATA, stream_id, 14464, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnLocalFlowControlExhausted(stream_id)); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::HEADERS, SpdyFrameType::DATA, | |
| SpdyFrameType::DATA, SpdyFrameType::DATA, | |
| SpdyFrameType::DATA, SpdyFrameType::DATA})); | |
| } | |
| TEST(OgHttp2AdapterTest, MaxOutboundDataFramePayload) { | |
| struct TestCase { | |
| std::optional<uint32_t> max_outbound_data_frame_payload; | |
| size_t expected_data_frame_size; | |
| }; | |
| // SETTINGS_MAX_FRAME_SIZE advertised by the client. | |
| const uint32_t kPeerMaxFrameSize = 64 * 1024; | |
| const size_t kBodySize = 48 * 1024; | |
| const std::vector<TestCase> test_cases = { | |
| // Without the option, DATA frames are limited only by the peer max. | |
| {std::nullopt, 48 * 1024}, | |
| // Zero is treated as unset. | |
| {0u, 48 * 1024}, | |
| // The option caps DATA frames below the peer's MAX_FRAME_SIZE. | |
| {16 * 1024, 16 * 1024}, | |
| {24 * 1024, 24 * 1024}, | |
| }; | |
| for (const TestCase& test_case : test_cases) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| options.max_outbound_data_frame_payload = | |
| test_case.max_outbound_data_frame_payload; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::string frames = | |
| TestFrameSequence() | |
| .ClientPreface({{MAX_FRAME_SIZE, kPeerMaxFrameSize}}) | |
| .Headers(1, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| // Client preface (SETTINGS with MAX_FRAME_SIZE) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 6, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, | |
| OnSetting(Http2Setting{MAX_FRAME_SIZE, kPeerMaxFrameSize})); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":method", "GET")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":scheme", "https")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":authority", "example.com")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":path", "/this/is/request/one")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnEndStream(1)); | |
| const int64_t read_result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(frames.size(), static_cast<size_t>(read_result)); | |
| // Server SETTINGS and SETTINGS ack. | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| visitor.Clear(); | |
| visitor.AppendPayloadForStream(1, std::string(kBodySize, 'c')); | |
| visitor.SetEndData(1, true); | |
| const int submit_result = | |
| adapter->SubmitResponse(1, ToHeaders({{":status", "200"}}), false); | |
| EXPECT_EQ(0, submit_result); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, 1, _, 0x4)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, 1, _, 0x4, 0)); | |
| const size_t num_data_frames = | |
| kBodySize / test_case.expected_data_frame_size; | |
| // Only the last DATA frame carries END_STREAM. | |
| EXPECT_CALL( | |
| visitor, | |
| OnFrameSent(DATA, 1, test_case.expected_data_frame_size, 0x0, 0)) | |
| .Times(static_cast<int>(num_data_frames) - 1); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(DATA, 1, test_case.expected_data_frame_size, | |
| END_STREAM_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| // The serialized bytes are HEADERS followed by the expected DATA frames. | |
| std::vector<std::pair<SpdyFrameType, std::optional<size_t>>> | |
| expected_frames = {{SpdyFrameType::HEADERS, std::nullopt}}; | |
| expected_frames.insert( | |
| expected_frames.end(), num_data_frames, | |
| {SpdyFrameType::DATA, test_case.expected_data_frame_size}); | |
| EXPECT_THAT(visitor.data(), EqualsFrames(expected_frames)); | |
| } | |
| } | |
| TEST(OgHttp2AdapterTest, ClientReceivesInitialWindowSettingAfterStreamStart) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::string initial_frames = | |
| TestFrameSequence().ServerPreface().WindowUpdate(0, 65536).Serialize(); | |
| // Server preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 4, WINDOW_UPDATE, 0)); | |
| EXPECT_CALL(visitor, OnWindowUpdate(0, 65536)); | |
| const int64_t initial_result = adapter->ProcessBytes(initial_frames); | |
| EXPECT_EQ(initial_frames.size(), static_cast<size_t>(initial_result)); | |
| // Session will want to write a SETTINGS ack. | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| int64_t result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| visitor.Clear(); | |
| const std::string kLongBody = std::string(81000, 'c'); | |
| visitor.AppendPayloadForStream(1, kLongBody); | |
| visitor.SetEndData(1, true); | |
| const int stream_id = | |
| adapter->SubmitRequest(ToHeaders({{":method", "POST"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}), | |
| false, nullptr); | |
| EXPECT_GT(stream_id, 0); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id, _, 0x4)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id, _, 0x4, 0)); | |
| // The client can only send 65535 bytes of data, as the stream window has not | |
| // yet been increased. | |
| EXPECT_CALL(visitor, OnFrameSent(DATA, stream_id, 16384, 0x0, 0)).Times(3); | |
| EXPECT_CALL(visitor, OnFrameSent(DATA, stream_id, 16383, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnLocalFlowControlExhausted(stream_id)); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::HEADERS, SpdyFrameType::DATA, | |
| SpdyFrameType::DATA, SpdyFrameType::DATA, | |
| SpdyFrameType::DATA})); | |
| visitor.Clear(); | |
| // Can't write any more due to flow control. | |
| EXPECT_FALSE(adapter->want_write()); | |
| const std::string settings_frame = | |
| TestFrameSequence().Settings({{INITIAL_WINDOW_SIZE, 80000u}}).Serialize(); | |
| // SETTINGS with INITIAL_STREAM_WINDOW | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 6, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSetting(Http2Setting{INITIAL_WINDOW_SIZE, 80000u})); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| const int64_t settings_result = adapter->ProcessBytes(settings_frame); | |
| EXPECT_EQ(settings_frame.size(), static_cast<size_t>(settings_result)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| // The client can write more after receiving the INITIAL_WINDOW_SIZE setting. | |
| EXPECT_CALL(visitor, OnFrameSent(DATA, stream_id, 14465, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnLocalFlowControlExhausted(stream_id)); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::DATA})); | |
| } | |
| TEST(OgHttp2AdapterTest, InvalidInitialWindowSetting) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const uint32_t kTooLargeInitialWindow = 1u << 31; | |
| const std::string initial_frames = | |
| TestFrameSequence() | |
| .Settings({{INITIAL_WINDOW_SIZE, kTooLargeInitialWindow}}) | |
| .Serialize(); | |
| // Server preface (SETTINGS with INITIAL_STREAM_WINDOW) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 6, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, | |
| OnInvalidFrame( | |
| 0, Http2VisitorInterface::InvalidFrameError::kFlowControl)); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kFlowControlError)); | |
| const int64_t initial_result = adapter->ProcessBytes(initial_frames); | |
| EXPECT_EQ(initial_frames.size(), static_cast<size_t>(initial_result)); | |
| // Session will want to write a GOAWAY. | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL( | |
| visitor, | |
| OnFrameSent(GOAWAY, 0, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::FLOW_CONTROL_ERROR))); | |
| int64_t result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| absl::string_view serialized = visitor.data(); | |
| EXPECT_THAT(serialized, | |
| testing::StartsWith(spdy::kHttp2ConnectionHeaderPrefix)); | |
| serialized.remove_prefix(strlen(spdy::kHttp2ConnectionHeaderPrefix)); | |
| EXPECT_THAT(serialized, | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::GOAWAY})); | |
| visitor.Clear(); | |
| } | |
| TEST(OggHttp2AdapterClientTest, InitialWindowSettingCausesOverflow) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::vector<Header> headers = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| const int32_t stream_id = adapter->SubmitRequest(headers, true, nullptr); | |
| ASSERT_GT(stream_id, 0); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| int64_t write_result = adapter->Send(); | |
| EXPECT_EQ(0, write_result); | |
| absl::string_view data = visitor.data(); | |
| EXPECT_THAT(data, testing::StartsWith(spdy::kHttp2ConnectionHeaderPrefix)); | |
| data.remove_prefix(strlen(spdy::kHttp2ConnectionHeaderPrefix)); | |
| EXPECT_THAT(data, | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::HEADERS})); | |
| visitor.Clear(); | |
| const uint32_t kLargeInitialWindow = (1u << 31) - 1; | |
| const std::string frames = | |
| TestFrameSequence() | |
| .ServerPreface() | |
| .Headers(stream_id, {{":status", "200"}}, /*fin=*/false) | |
| .WindowUpdate(stream_id, 65536u) | |
| .Settings({{INITIAL_WINDOW_SIZE, kLargeInitialWindow}}) | |
| .Serialize(); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(stream_id, _, HEADERS, 0x4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(stream_id)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(stream_id, ":status", "200")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(stream_id)); | |
| EXPECT_CALL(visitor, OnFrameHeader(stream_id, 4, WINDOW_UPDATE, 0x0)); | |
| EXPECT_CALL(visitor, OnWindowUpdate(stream_id, 65536)); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 6, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSetting(Http2Setting{INITIAL_WINDOW_SIZE, | |
| kLargeInitialWindow})); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| const int64_t read_result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(static_cast<size_t>(read_result), frames.size()); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| // The stream window update plus the SETTINGS frame with INITIAL_WINDOW_SIZE | |
| // pushes the stream's flow control window outside of the acceptable range. | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, stream_id, 4, 0x0)); | |
| EXPECT_CALL( | |
| visitor, | |
| OnFrameSent(RST_STREAM, stream_id, 4, 0x0, | |
| static_cast<int>(Http2ErrorCode::FLOW_CONTROL_ERROR))); | |
| EXPECT_CALL(visitor, | |
| OnCloseStream(stream_id, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS, | |
| SpdyFrameType::RST_STREAM})); | |
| } | |
| TEST(OgHttp2AdapterTest, FailureSendingConnectionPreface) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| visitor.set_has_write_error(); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kSendError)); | |
| int result = adapter->Send(); | |
| EXPECT_LT(result, 0); | |
| } | |
| TEST(OgHttp2AdapterTest, MaxFrameSizeSettingNotAppliedBeforeAck) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const uint32_t large_frame_size = kDefaultFramePayloadSizeLimit + 42; | |
| adapter->SubmitSettings({{MAX_FRAME_SIZE, large_frame_size}}); | |
| const int32_t stream_id = | |
| adapter->SubmitRequest(ToHeaders({{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}), | |
| true, /*user_data=*/nullptr); | |
| EXPECT_GT(stream_id, 0); | |
| EXPECT_TRUE(adapter->want_write()); | |
| testing::InSequence s; | |
| // Client preface (SETTINGS with MAX_FRAME_SIZE) and request HEADERS | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 6, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 6, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| absl::string_view data = visitor.data(); | |
| EXPECT_THAT(data, testing::StartsWith(spdy::kHttp2ConnectionHeaderPrefix)); | |
| data.remove_prefix(strlen(spdy::kHttp2ConnectionHeaderPrefix)); | |
| EXPECT_THAT(data, | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::HEADERS})); | |
| visitor.Clear(); | |
| const std::string server_frames = | |
| TestFrameSequence() | |
| .ServerPreface() | |
| .Headers(1, {{":status", "200"}}, /*fin=*/false) | |
| .Data(1, std::string(large_frame_size, 'a')) | |
| .Serialize(); | |
| // Server preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Response HEADERS. Because the SETTINGS with MAX_FRAME_SIZE was not | |
| // acknowledged, the large DATA is treated as a connection error. Note that | |
| // oghttp2 delivers the DATA frame header and connection error events. | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":status", "200")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, large_frame_size, DATA, 0x0)); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kParseError)); | |
| const int64_t process_result = adapter->ProcessBytes(server_frames); | |
| EXPECT_EQ(server_frames.size(), static_cast<size_t>(process_result)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(GOAWAY, 0, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::FRAME_SIZE_ERROR))); | |
| send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::GOAWAY})); | |
| } | |
| TEST(OgHttp2AdapterTest, MaxFrameSizeSettingAppliedAfterAck) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const uint32_t large_frame_size = kDefaultFramePayloadSizeLimit + 42; | |
| adapter->SubmitSettings({{MAX_FRAME_SIZE, large_frame_size}}); | |
| const int32_t stream_id = | |
| adapter->SubmitRequest(ToHeaders({{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}), | |
| true, /*user_data=*/nullptr); | |
| EXPECT_GT(stream_id, 0); | |
| EXPECT_TRUE(adapter->want_write()); | |
| testing::InSequence s; | |
| // Client preface (SETTINGS with MAX_FRAME_SIZE) and request HEADERS | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 6, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 6, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| absl::string_view data = visitor.data(); | |
| EXPECT_THAT(data, testing::StartsWith(spdy::kHttp2ConnectionHeaderPrefix)); | |
| data.remove_prefix(strlen(spdy::kHttp2ConnectionHeaderPrefix)); | |
| EXPECT_THAT(data, | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::HEADERS})); | |
| visitor.Clear(); | |
| const std::string server_frames = | |
| TestFrameSequence() | |
| .ServerPreface() | |
| .SettingsAck() | |
| .Headers(1, {{":status", "200"}}, /*fin=*/false) | |
| .Data(1, std::string(large_frame_size, 'a')) | |
| .Serialize(); | |
| // Server preface (empty SETTINGS) and ack of SETTINGS. | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnSettingsAck()); | |
| // Response HEADERS and DATA. Because the SETTINGS with MAX_FRAME_SIZE was | |
| // acknowledged, the large DATA is accepted without any error. | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":status", "200")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, large_frame_size, DATA, 0x0)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(1, large_frame_size)); | |
| EXPECT_CALL(visitor, OnDataForStream(1, _)); | |
| const int64_t process_result = adapter->ProcessBytes(server_frames); | |
| EXPECT_EQ(server_frames.size(), static_cast<size_t>(process_result)); | |
| // Client ack of SETTINGS. | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::SETTINGS})); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientForbidsPushPromise) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| int write_result = adapter->Send(); | |
| EXPECT_EQ(0, write_result); | |
| absl::string_view data = visitor.data(); | |
| EXPECT_THAT(data, testing::StartsWith(spdy::kHttp2ConnectionHeaderPrefix)); | |
| data.remove_prefix(strlen(spdy::kHttp2ConnectionHeaderPrefix)); | |
| EXPECT_THAT(data, EqualsFrames({SpdyFrameType::SETTINGS})); | |
| visitor.Clear(); | |
| const std::vector<Header> headers = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| const int32_t stream_id = adapter->SubmitRequest(headers, true, nullptr); | |
| ASSERT_GT(stream_id, 0); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| write_result = adapter->Send(); | |
| EXPECT_EQ(0, write_result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::HEADERS})); | |
| visitor.Clear(); | |
| const std::vector<Header> push_headers = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/push"}}); | |
| const std::string frames = TestFrameSequence() | |
| .ServerPreface() | |
| .SettingsAck() | |
| .PushPromise(stream_id, 2, push_headers) | |
| .Serialize(); | |
| // Server preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // SETTINGS ack (to acknowledge PUSH_ENABLED=0, though this is not explicitly | |
| // required for OgHttp2: should it be?) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnSettingsAck); | |
| // The PUSH_PROMISE is treated as an invalid frame. | |
| EXPECT_CALL(visitor, OnFrameHeader(stream_id, _, PUSH_PROMISE, _)); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kInvalidPushPromise)); | |
| const int64_t read_result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(static_cast<size_t>(read_result), frames.size()); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(GOAWAY, 0, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::GOAWAY})); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientForbidsPushStream) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| int write_result = adapter->Send(); | |
| EXPECT_EQ(0, write_result); | |
| absl::string_view data = visitor.data(); | |
| EXPECT_THAT(data, testing::StartsWith(spdy::kHttp2ConnectionHeaderPrefix)); | |
| data.remove_prefix(strlen(spdy::kHttp2ConnectionHeaderPrefix)); | |
| EXPECT_THAT(data, EqualsFrames({SpdyFrameType::SETTINGS})); | |
| visitor.Clear(); | |
| const std::vector<Header> headers = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| const int32_t stream_id = adapter->SubmitRequest(headers, true, nullptr); | |
| ASSERT_GT(stream_id, 0); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| write_result = adapter->Send(); | |
| EXPECT_EQ(0, write_result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::HEADERS})); | |
| visitor.Clear(); | |
| const std::string frames = | |
| TestFrameSequence() | |
| .ServerPreface() | |
| .SettingsAck() | |
| .Headers(2, | |
| {{":status", "200"}, | |
| {"server", "my-fake-server"}, | |
| {"date", "Tue, 6 Apr 2021 12:54:01 GMT"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| // Server preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // SETTINGS ack (to acknowledge PUSH_ENABLED=0, though this is not explicitly | |
| // required for OgHttp2: should it be?) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnSettingsAck); | |
| // The push HEADERS are invalid. | |
| EXPECT_CALL(visitor, OnFrameHeader(2, _, HEADERS, _)); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kInvalidNewStreamId)); | |
| const int64_t read_result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(static_cast<size_t>(read_result), frames.size()); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(GOAWAY, 0, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::GOAWAY})); | |
| } | |
| // This test verifies how oghttp2 behaves when a connection becomes | |
| // write-blocked while sending HEADERS. | |
| TEST(OgHttp2AdapterTest, ClientSubmitRequestWithWriteBlock) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| // Flushes the connection preface. | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| absl::string_view serialized = visitor.data(); | |
| EXPECT_THAT(serialized, | |
| testing::StartsWith(spdy::kHttp2ConnectionHeaderPrefix)); | |
| serialized.remove_prefix(strlen(spdy::kHttp2ConnectionHeaderPrefix)); | |
| EXPECT_THAT(serialized, EqualsFrames({SpdyFrameType::SETTINGS})); | |
| visitor.Clear(); | |
| const absl::string_view kBody = "This is an example request body."; | |
| visitor.AppendPayloadForStream(1, kBody); | |
| visitor.SetEndData(1, true); | |
| int stream_id = | |
| adapter->SubmitRequest(ToHeaders({{":method", "POST"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}), | |
| false, nullptr); | |
| EXPECT_GT(stream_id, 0); | |
| EXPECT_TRUE(adapter->want_write()); | |
| visitor.set_is_write_blocked(true); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id, _, 0x4)); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), testing::IsEmpty()); | |
| EXPECT_TRUE(adapter->want_write()); | |
| // BUG: OnBeforeFrameSent() called twice. | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id, _, 0x4)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id, _, 0x4, 0)); | |
| EXPECT_CALL(visitor, OnFrameSent(DATA, stream_id, _, 0x1, 0)); | |
| visitor.set_is_write_blocked(false); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::HEADERS, SpdyFrameType::DATA})); | |
| EXPECT_FALSE(adapter->want_write()); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientReceivesDataOnClosedStream) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| absl::string_view data = visitor.data(); | |
| EXPECT_THAT(data, testing::StartsWith(spdy::kHttp2ConnectionHeaderPrefix)); | |
| data.remove_prefix(strlen(spdy::kHttp2ConnectionHeaderPrefix)); | |
| EXPECT_THAT(data, EqualsFrames({SpdyFrameType::SETTINGS})); | |
| visitor.Clear(); | |
| const std::string initial_frames = | |
| TestFrameSequence().ServerPreface().Serialize(); | |
| testing::InSequence s; | |
| // Server preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| const int64_t initial_result = adapter->ProcessBytes(initial_frames); | |
| EXPECT_EQ(initial_frames.size(), static_cast<size_t>(initial_result)); | |
| // Client SETTINGS ack | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::SETTINGS})); | |
| visitor.Clear(); | |
| // Let the client open a stream with a request. | |
| int stream_id = | |
| adapter->SubmitRequest(ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}), | |
| true, nullptr); | |
| EXPECT_GT(stream_id, 0); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::HEADERS})); | |
| visitor.Clear(); | |
| // Let the client RST_STREAM the stream it opened. | |
| adapter->SubmitRst(stream_id, Http2ErrorCode::CANCEL); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, stream_id, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(RST_STREAM, stream_id, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::CANCEL))); | |
| EXPECT_CALL(visitor, | |
| OnCloseStream(stream_id, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::RST_STREAM})); | |
| visitor.Clear(); | |
| // Let the server send a response on the stream. (It might not have received | |
| // the RST_STREAM yet.) | |
| const std::string response_frames = | |
| TestFrameSequence() | |
| .Headers(stream_id, | |
| {{":status", "200"}, | |
| {"server", "my-fake-server"}, | |
| {"date", "Tue, 6 Apr 2021 12:54:01 GMT"}}, | |
| /*fin=*/false) | |
| .Data(stream_id, "This is the response body.", /*fin=*/true) | |
| .Serialize(); | |
| // The visitor gets notified about the HEADERS frame and DATA frame for the | |
| // closed stream with no further processing on either frame. | |
| EXPECT_CALL(visitor, OnFrameHeader(stream_id, _, HEADERS, 0x4)); | |
| EXPECT_CALL(visitor, OnFrameHeader(stream_id, _, DATA, END_STREAM_FLAG)); | |
| const int64_t response_result = adapter->ProcessBytes(response_frames); | |
| EXPECT_EQ(response_frames.size(), static_cast<size_t>(response_result)); | |
| EXPECT_FALSE(adapter->want_write()); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientEncountersFlowControlBlock) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::vector<Header> headers1 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| const std::string kBody = std::string(100 * 1024, 'a'); | |
| visitor.AppendPayloadForStream(1, kBody); | |
| visitor.SetEndData(1, false); | |
| const int32_t stream_id1 = adapter->SubmitRequest(headers1, false, nullptr); | |
| ASSERT_GT(stream_id1, 0); | |
| const std::vector<Header> headers2 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/two"}}); | |
| visitor.AppendPayloadForStream(3, kBody); | |
| visitor.SetEndData(3, false); | |
| const int32_t stream_id2 = adapter->SubmitRequest(headers2, false, nullptr); | |
| ASSERT_EQ(stream_id2, 3); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id1, _, 0x4)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id1, _, 0x4, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id2, _, 0x4)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id2, _, 0x4, 0)); | |
| // 4 DATA frames should saturate the default 64kB stream/connection flow | |
| // control window. | |
| EXPECT_CALL(visitor, OnFrameSent(DATA, stream_id1, _, 0x0, 0)).Times(4); | |
| EXPECT_CALL(visitor, OnLocalFlowControlExhausted(0)); | |
| EXPECT_CALL(visitor, OnLocalFlowControlExhausted(stream_id1)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_EQ(0, adapter->GetSendWindowSize()); | |
| const std::string stream_frames = TestFrameSequence() | |
| .ServerPreface() | |
| .WindowUpdate(0, 80000) | |
| .WindowUpdate(stream_id1, 20000) | |
| .Serialize(); | |
| // Server preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 4, WINDOW_UPDATE, 0)); | |
| EXPECT_CALL(visitor, OnWindowUpdate(0, 80000)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, 4, WINDOW_UPDATE, 0)); | |
| EXPECT_CALL(visitor, OnWindowUpdate(1, 20000)); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(stream_frames.size(), static_cast<size_t>(stream_result)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnFrameSent(DATA, stream_id2, _, 0x0, 0)) | |
| .Times(testing::AtLeast(1)); | |
| EXPECT_CALL(visitor, OnLocalFlowControlExhausted(stream_id2)); | |
| EXPECT_CALL(visitor, OnFrameSent(DATA, stream_id1, _, 0x0, 0)) | |
| .Times(testing::AtLeast(1)); | |
| // Connection level flow control is exhausted. | |
| EXPECT_CALL(visitor, OnLocalFlowControlExhausted(0)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientSendsTrailersAfterFlowControlBlock) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::vector<Header> headers1 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| visitor.AppendPayloadForStream(1, "Really small body."); | |
| visitor.SetEndData(1, false); | |
| const int32_t stream_id1 = adapter->SubmitRequest(headers1, false, nullptr); | |
| ASSERT_GT(stream_id1, 0); | |
| const std::vector<Header> headers2 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/two"}}); | |
| const std::string kBody = std::string(100 * 1024, 'a'); | |
| visitor.AppendPayloadForStream(3, kBody); | |
| visitor.SetEndData(3, false); | |
| const int32_t stream_id2 = adapter->SubmitRequest(headers2, false, nullptr); | |
| ASSERT_GT(stream_id2, 0); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id1, _, 0x4)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id1, _, 0x4, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id2, _, 0x4)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id2, _, 0x4, 0)); | |
| EXPECT_CALL(visitor, OnFrameSent(DATA, stream_id1, _, 0x0, 0)).Times(1); | |
| // 4 DATA frames should saturate the default 64kB connection flow | |
| // control window. | |
| EXPECT_CALL(visitor, OnFrameSent(DATA, stream_id2, _, 0x0, 0)).Times(4); | |
| // The connection flow control window has been exhausted, but both streams | |
| // still have flow control window available. | |
| EXPECT_CALL(visitor, OnLocalFlowControlExhausted(0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_FALSE(adapter->want_write()); | |
| EXPECT_EQ(0, adapter->GetSendWindowSize()); | |
| const std::vector<Header> trailers1 = | |
| ToHeaders({{"extra-info", "Trailers are weird but good?"}}); | |
| adapter->SubmitTrailer(stream_id1, trailers1); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientQueuesRequests) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| adapter->Send(); | |
| const std::string initial_frames = | |
| TestFrameSequence() | |
| .ServerPreface({{MAX_CONCURRENT_STREAMS, 2}}) | |
| .SettingsAck() | |
| .Serialize(); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 6, SETTINGS, 0x0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSetting(Http2Setting{ | |
| Http2KnownSettingsId::MAX_CONCURRENT_STREAMS, 2u})); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnSettingsAck()); | |
| adapter->ProcessBytes(initial_frames); | |
| const std::vector<Header> headers = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/example/request"}}); | |
| std::vector<int32_t> stream_ids; | |
| // Start two, which hits the limit. | |
| int32_t stream_id = adapter->SubmitRequest(headers, true, nullptr); | |
| stream_ids.push_back(stream_id); | |
| stream_id = adapter->SubmitRequest(headers, true, nullptr); | |
| stream_ids.push_back(stream_id); | |
| // Start two more, which must be queued. | |
| stream_id = adapter->SubmitRequest(headers, true, nullptr); | |
| stream_ids.push_back(stream_id); | |
| stream_id = adapter->SubmitRequest(headers, true, nullptr); | |
| stream_ids.push_back(stream_id); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_ids[0], _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_ids[0], _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_ids[1], _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_ids[1], _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| adapter->Send(); | |
| const std::string update_streams = | |
| TestFrameSequence().Settings({{MAX_CONCURRENT_STREAMS, 5}}).Serialize(); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 6, SETTINGS, 0x0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSetting(Http2Setting{ | |
| Http2KnownSettingsId::MAX_CONCURRENT_STREAMS, 5u})); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| adapter->ProcessBytes(update_streams); | |
| stream_id = adapter->SubmitRequest(headers, true, nullptr); | |
| stream_ids.push_back(stream_id); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_ids[2], _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_ids[2], _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_ids[3], _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_ids[3], _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_ids[4], _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_ids[4], _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| // Header frames should all have been sent in order, regardless of any | |
| // queuing. | |
| adapter->Send(); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientAcceptsHeadResponseWithContentLength) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::vector<Header> headers = ToHeaders({{":method", "HEAD"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/"}}); | |
| const int32_t stream_id = adapter->SubmitRequest(headers, true, nullptr); | |
| testing::InSequence s; | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, stream_id, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, stream_id, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| adapter->Send(); | |
| const std::string initial_frames = | |
| TestFrameSequence() | |
| .ServerPreface() | |
| .SettingsAck() | |
| .Headers(stream_id, {{":status", "200"}, {"content-length", "101"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, _, SETTINGS, 0x0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnSettingsAck()); | |
| EXPECT_CALL(visitor, OnFrameHeader(stream_id, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(stream_id)); | |
| EXPECT_CALL(visitor, OnHeaderForStream).Times(2); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(stream_id)); | |
| EXPECT_CALL(visitor, OnEndStream(stream_id)); | |
| EXPECT_CALL(visitor, | |
| OnCloseStream(stream_id, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| adapter->ProcessBytes(initial_frames); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| adapter->Send(); | |
| } | |
| TEST(OgHttp2AdapterTest, GetSendWindowSize) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const int peer_window = adapter->GetSendWindowSize(); | |
| EXPECT_EQ(peer_window, kInitialFlowControlWindowSize); | |
| } | |
| TEST(OgHttp2AdapterTest, WindowUpdateZeroDelta) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string data_chunk(kDefaultFramePayloadSizeLimit, 'a'); | |
| const std::string request = | |
| TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/"}}, | |
| /*fin=*/false) | |
| .WindowUpdate(1, 0) | |
| .Data(1, "Subsequent frames on stream 1 are not delivered.") | |
| .Serialize(); | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream).Times(4); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, 4, WINDOW_UPDATE, 0)); | |
| adapter->ProcessBytes(request); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 6, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 6, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 1, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 1, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(1, _)); | |
| adapter->Send(); | |
| const std::string window_update = | |
| TestFrameSequence().WindowUpdate(0, 0).Serialize(); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 4, WINDOW_UPDATE, 0)); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kFlowControlError)); | |
| adapter->ProcessBytes(window_update); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(GOAWAY, 0, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| adapter->Send(); | |
| } | |
| TEST(OgHttp2AdapterTest, WindowUpdateCausesWindowOverflow) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string data_chunk(kDefaultFramePayloadSizeLimit, 'a'); | |
| const std::string request = | |
| TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/"}}, | |
| /*fin=*/false) | |
| .WindowUpdate(1, std::numeric_limits<int>::max()) | |
| .Data(1, "Subsequent frames on stream 1 are not delivered.") | |
| .Serialize(); | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream).Times(4); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, 4, WINDOW_UPDATE, 0)); | |
| adapter->ProcessBytes(request); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 6, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 6, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 1, _, 0x0)); | |
| EXPECT_CALL( | |
| visitor, | |
| OnFrameSent(RST_STREAM, 1, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::FLOW_CONTROL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(1, _)); | |
| adapter->Send(); | |
| const std::string window_update = | |
| TestFrameSequence() | |
| .WindowUpdate(0, std::numeric_limits<int>::max()) | |
| .Serialize(); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 4, WINDOW_UPDATE, 0)); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kFlowControlError)); | |
| adapter->ProcessBytes(window_update); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL( | |
| visitor, | |
| OnFrameSent(GOAWAY, 0, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::FLOW_CONTROL_ERROR))); | |
| adapter->Send(); | |
| } | |
| TEST(OgHttp2AdapterTest, WindowUpdateRaisesFlowControlWindowLimit) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string data_chunk(kDefaultFramePayloadSizeLimit, 'a'); | |
| const std::string request = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/"}}, | |
| /*fin=*/false) | |
| .Serialize(); | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream).Times(4); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| adapter->ProcessBytes(request); | |
| // Updates the advertised window for the connection and stream 1. | |
| adapter->SubmitWindowUpdate(0, 2 * kDefaultFramePayloadSizeLimit); | |
| adapter->SubmitWindowUpdate(1, 2 * kDefaultFramePayloadSizeLimit); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 6, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 6, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(WINDOW_UPDATE, 0, 4, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(WINDOW_UPDATE, 0, 4, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(WINDOW_UPDATE, 1, 4, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(WINDOW_UPDATE, 1, 4, 0x0, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| // Verifies the advertised window. | |
| EXPECT_EQ(kInitialFlowControlWindowSize + 2 * kDefaultFramePayloadSizeLimit, | |
| adapter->GetReceiveWindowSize()); | |
| EXPECT_EQ(kInitialFlowControlWindowSize + 2 * kDefaultFramePayloadSizeLimit, | |
| adapter->GetStreamReceiveWindowSize(1)); | |
| const std::string request_body = TestFrameSequence() | |
| .Data(1, data_chunk) | |
| .Data(1, data_chunk) | |
| .Data(1, data_chunk) | |
| .Data(1, data_chunk) | |
| .Data(1, data_chunk) | |
| .Serialize(); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, DATA, 0)).Times(5); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(1, _)).Times(5); | |
| EXPECT_CALL(visitor, OnDataForStream(1, _)).Times(5); | |
| // DATA frames on stream 1 consume most of the window. | |
| adapter->ProcessBytes(request_body); | |
| EXPECT_EQ(kInitialFlowControlWindowSize - 3 * kDefaultFramePayloadSizeLimit, | |
| adapter->GetReceiveWindowSize()); | |
| EXPECT_EQ(kInitialFlowControlWindowSize - 3 * kDefaultFramePayloadSizeLimit, | |
| adapter->GetStreamReceiveWindowSize(1)); | |
| // Marking the data consumed should result in an advertised window larger than | |
| // the initial window. | |
| adapter->MarkDataConsumedForStream(1, 4 * kDefaultFramePayloadSizeLimit); | |
| EXPECT_GT(adapter->GetReceiveWindowSize(), kInitialFlowControlWindowSize); | |
| EXPECT_GT(adapter->GetStreamReceiveWindowSize(1), | |
| kInitialFlowControlWindowSize); | |
| } | |
| TEST(OgHttp2AdapterTest, MarkDataConsumedForNonexistentStream) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| // Send some data on stream 1 so the connection window manager doesn't | |
| // underflow later. | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}, | |
| /*fin=*/false) | |
| .Data(1, "Some data on stream 1") | |
| .Serialize(); | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream).Times(4); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, DATA, 0)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(1, _)); | |
| EXPECT_CALL(visitor, OnDataForStream(1, _)); | |
| adapter->ProcessBytes(frames); | |
| // This should not cause a crash or QUICHE_BUG. | |
| adapter->MarkDataConsumedForStream(3, 11); | |
| } | |
| TEST(OgHttp2AdapterTest, TestSerialize) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| EXPECT_TRUE(adapter->want_read()); | |
| EXPECT_FALSE(adapter->want_write()); | |
| adapter->SubmitSettings( | |
| {{HEADER_TABLE_SIZE, 128}, {MAX_FRAME_SIZE, 128 << 10}}); | |
| EXPECT_TRUE(adapter->want_write()); | |
| const Http2StreamId accepted_stream = 3; | |
| const Http2StreamId rejected_stream = 7; | |
| adapter->SubmitPriorityForStream(accepted_stream, 1, 255, true); | |
| adapter->SubmitRst(rejected_stream, Http2ErrorCode::CANCEL); | |
| adapter->SubmitPing(42); | |
| adapter->SubmitGoAway(13, Http2ErrorCode::HTTP2_NO_ERROR, ""); | |
| adapter->SubmitWindowUpdate(accepted_stream, 127); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(PRIORITY, accepted_stream, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(PRIORITY, accepted_stream, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, rejected_stream, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(RST_STREAM, rejected_stream, _, 0x0, 0x8)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(PING, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(PING, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(GOAWAY, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, | |
| OnBeforeFrameSent(WINDOW_UPDATE, accepted_stream, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(WINDOW_UPDATE, accepted_stream, _, 0x0, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT( | |
| visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::PRIORITY, | |
| SpdyFrameType::RST_STREAM, SpdyFrameType::PING, | |
| SpdyFrameType::GOAWAY, SpdyFrameType::WINDOW_UPDATE})); | |
| EXPECT_FALSE(adapter->want_write()); | |
| } | |
| TEST(OgHttp2AdapterTest, TestPartialSerialize) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| EXPECT_FALSE(adapter->want_write()); | |
| adapter->SubmitSettings( | |
| {{HEADER_TABLE_SIZE, 128}, {MAX_FRAME_SIZE, 128 << 10}}); | |
| adapter->SubmitGoAway(13, Http2ErrorCode::HTTP2_NO_ERROR, | |
| "And don't come back!"); | |
| adapter->SubmitPing(42); | |
| EXPECT_TRUE(adapter->want_write()); | |
| visitor.set_send_limit(20); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(GOAWAY, 0, _, 0x0, 0)); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(PING, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(PING, 0, _, 0x0, 0)); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_FALSE(adapter->want_write()); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::GOAWAY, | |
| SpdyFrameType::PING})); | |
| } | |
| TEST(OgHttp2AdapterTest, TestStreamInitialWindowSizeUpdates) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| adapter->SubmitSettings({{INITIAL_WINDOW_SIZE, 80000}}); | |
| EXPECT_TRUE(adapter->want_write()); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}, | |
| /*fin=*/false) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 0x4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, _, _)).Times(4); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| const int64_t read_result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(static_cast<size_t>(read_result), frames.size()); | |
| // New stream window size has not yet been applied. | |
| EXPECT_EQ(adapter->GetStreamReceiveWindowSize(1), 65535); | |
| // Server initial SETTINGS | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 6, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 6, 0x0, 0)); | |
| // SETTINGS ack | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| // New stream window size has still not been applied. | |
| EXPECT_EQ(adapter->GetStreamReceiveWindowSize(1), 65535); | |
| const std::string ack = TestFrameSequence().SettingsAck().Serialize(); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnSettingsAck()); | |
| adapter->ProcessBytes(ack); | |
| // New stream window size has finally been applied upon SETTINGS ack. | |
| EXPECT_EQ(adapter->GetStreamReceiveWindowSize(1), 80000); | |
| // Update the stream window size again. | |
| adapter->SubmitSettings({{INITIAL_WINDOW_SIZE, 90000}}); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 6, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 6, 0x0, 0)); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| // New stream window size has not yet been applied. | |
| EXPECT_EQ(adapter->GetStreamReceiveWindowSize(1), 80000); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnSettingsAck()); | |
| adapter->ProcessBytes(ack); | |
| // New stream window size is applied after the ack. | |
| EXPECT_EQ(adapter->GetStreamReceiveWindowSize(1), 90000); | |
| } | |
| TEST(OgHttp2AdapterTest, ConnectionErrorOnControlFrameSent) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = | |
| TestFrameSequence().ClientPreface().Ping(42).Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // PING | |
| EXPECT_CALL(visitor, OnFrameHeader(0, _, PING, 0)); | |
| EXPECT_CALL(visitor, OnPing(42, false)); | |
| const int64_t read_result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(static_cast<size_t>(read_result), frames.size()); | |
| EXPECT_TRUE(adapter->want_write()); | |
| // Server preface (SETTINGS) | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| // SETTINGS ack | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)) | |
| .WillOnce(testing::Return(-902)); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kSendError)); | |
| int send_result = adapter->Send(); | |
| EXPECT_LT(send_result, 0); | |
| EXPECT_FALSE(adapter->want_write()); | |
| send_result = adapter->Send(); | |
| EXPECT_LT(send_result, 0); | |
| } | |
| TEST(OgHttp2AdapterTest, ConnectionErrorOnDataFrameSent) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| EXPECT_CALL(visitor, | |
| OnFrameHeader(1, _, HEADERS, END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, _, _)).Times(4); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnEndStream(1)); | |
| const int64_t read_result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(static_cast<size_t>(read_result), frames.size()); | |
| visitor.AppendPayloadForStream( | |
| 1, "Here is some data, which will lead to a fatal error"); | |
| int submit_result = | |
| adapter->SubmitResponse(1, ToHeaders({{":status", "200"}}), false); | |
| ASSERT_EQ(0, submit_result); | |
| EXPECT_TRUE(adapter->want_write()); | |
| // Server preface (SETTINGS) | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| // SETTINGS ack | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| // Stream 1, with doomed DATA | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, 1, _, 0x4)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, 1, _, 0x4, 0)); | |
| EXPECT_CALL(visitor, OnFrameSent(DATA, 1, _, 0x0, 0)) | |
| .WillOnce(testing::Return(-902)); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kSendError)); | |
| int send_result = adapter->Send(); | |
| EXPECT_LT(send_result, 0); | |
| visitor.AppendPayloadForStream( | |
| 1, "After the fatal error, data will be sent no more"); | |
| EXPECT_FALSE(adapter->want_write()); | |
| send_result = adapter->Send(); | |
| EXPECT_LT(send_result, 0); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientSendsContinuation) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| EXPECT_FALSE(adapter->want_write()); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}, | |
| /*fin=*/true, | |
| /*add_continuation=*/true) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 1)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":method", "GET")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":scheme", "https")); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, CONTINUATION, 4)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":authority", "example.com")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":path", "/this/is/request/one")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnEndStream(1)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(frames.size(), static_cast<size_t>(result)); | |
| } | |
| TEST(OgHttp2AdapterTest, RepeatedHeaderNames) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| EXPECT_FALSE(adapter->want_write()); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}, | |
| {"accept", "text/plain"}, | |
| {"accept", "text/html"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":method", "GET")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":scheme", "https")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":authority", "example.com")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":path", "/this/is/request/one")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, "accept", "text/plain")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, "accept", "text/html")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnEndStream(1)); | |
| int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(frames.size(), static_cast<size_t>(result)); | |
| const std::vector<Header> headers1 = ToHeaders( | |
| {{":status", "200"}, {"content-length", "10"}, {"content-length", "10"}}); | |
| visitor.AppendPayloadForStream(1, "perfection"); | |
| visitor.SetEndData(1, true); | |
| int submit_result = adapter->SubmitResponse(1, headers1, false); | |
| ASSERT_EQ(0, submit_result); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, 1, _, 0x4)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, 1, _, 0x4, 0)); | |
| EXPECT_CALL(visitor, OnFrameSent(DATA, 1, 10, END_STREAM, 0)); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS, | |
| SpdyFrameType::HEADERS, SpdyFrameType::DATA})); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerRespondsToRequestWithTrailers) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| EXPECT_FALSE(adapter->want_write()); | |
| const std::string frames = | |
| TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}) | |
| .Data(1, "Example data, woohoo.") | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":method", "GET")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":scheme", "https")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":authority", "example.com")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":path", "/this/is/request/one")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, DATA, 0)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(1, _)); | |
| EXPECT_CALL(visitor, OnDataForStream(1, _)); | |
| int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(frames.size(), static_cast<size_t>(result)); | |
| const std::vector<Header> headers1 = ToHeaders({{":status", "200"}}); | |
| int submit_result = adapter->SubmitResponse(1, headers1, false); | |
| ASSERT_EQ(0, submit_result); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, 1, _, 0x4)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, 1, _, 0x4, 0)); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS, | |
| SpdyFrameType::HEADERS})); | |
| visitor.Clear(); | |
| const std::string more_frames = | |
| TestFrameSequence() | |
| .Headers(1, {{"extra-info", "Trailers are weird but good?"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, "extra-info", | |
| "Trailers are weird but good?")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnEndStream(1)); | |
| result = adapter->ProcessBytes(more_frames); | |
| EXPECT_EQ(more_frames.size(), static_cast<size_t>(result)); | |
| visitor.SetEndData(1, true); | |
| EXPECT_EQ(true, adapter->ResumeStream(1)); | |
| EXPECT_CALL(visitor, OnFrameSent(DATA, 1, 0, END_STREAM, 0)); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::DATA})); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerReceivesMoreHeaderBytesThanConfigured) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| options.max_header_list_bytes = 42; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| EXPECT_FALSE(adapter->want_write()); | |
| const std::string frames = | |
| TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}, | |
| {"from-douglas-de-fermat", | |
| "I have discovered a truly marvelous answer to the life, " | |
| "the universe, and everything that the header setting is " | |
| "too narrow to contain."}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| EXPECT_CALL(visitor, | |
| OnFrameHeader(1, _, HEADERS, END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kParseError)); | |
| int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(static_cast<size_t>(result), frames.size()); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(GOAWAY, 0, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::COMPRESSION_ERROR))); | |
| int send_result = adapter->Send(); | |
| // Some bytes should have been serialized. | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::GOAWAY})); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerVisitorRejectsHeaders) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| EXPECT_FALSE(adapter->want_write()); | |
| const std::string frames = | |
| TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}, | |
| {"header1", "ok"}, | |
| {"header2", "rejected"}, | |
| {"header3", "not processed"}, // CONTINUATION starts here | |
| {"header4", "not processed"}, | |
| {"header5", "not processed"}, | |
| {"header6", "not processed"}, | |
| {"header7", "not processed"}, | |
| {"header8", "not processed"}}, | |
| /*fin=*/false, /*add_continuation=*/true) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 0x0)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, _, _)).Times(5); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, "header2", _)) | |
| .WillOnce(testing::Return(OnHeaderResult::HEADER_RST_STREAM)); | |
| // The CONTINUATION frame header and header fields are not processed. | |
| int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(static_cast<size_t>(result), frames.size()); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x1)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x1, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 1, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 1, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::INTERNAL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| int send_result = adapter->Send(); | |
| // Some bytes should have been serialized. | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS, | |
| SpdyFrameType::RST_STREAM})); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerSubmitsResponseWithDataSourceError) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| EXPECT_FALSE(adapter->want_write()); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":method", "GET")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":scheme", "https")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":authority", "example.com")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":path", "/this/is/request/one")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnEndStream(1)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(frames.size(), static_cast<size_t>(result)); | |
| visitor.SimulateError(1); | |
| int submit_result = adapter->SubmitResponse( | |
| 1, ToHeaders({{":status", "200"}, {"x-comment", "Sure, sounds good."}}), | |
| false); | |
| EXPECT_EQ(submit_result, 0); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, 1, _, 0x4)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, 1, _, 0x4, 0)); | |
| // TODO(birenroy): Send RST_STREAM INTERNAL_ERROR to the client as well. | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::INTERNAL_ERROR)); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS, | |
| SpdyFrameType::HEADERS})); | |
| visitor.Clear(); | |
| EXPECT_FALSE(adapter->want_write()); | |
| // Since the stream has been closed, it is not possible to submit trailers for | |
| // the stream. | |
| int trailer_result = | |
| adapter->SubmitTrailer(1, ToHeaders({{":final-status", "a-ok"}})); | |
| ASSERT_LT(trailer_result, 0); | |
| EXPECT_FALSE(adapter->want_write()); | |
| } | |
| TEST(OgHttp2AdapterTest, CompleteRequestWithServerResponse) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| EXPECT_FALSE(adapter->want_write()); | |
| const std::string frames = | |
| TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}, | |
| /*fin=*/false) | |
| .Data(1, "This is the response body.", /*fin=*/true) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, _, _)).Times(4); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, DATA, 1)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(1, _)); | |
| EXPECT_CALL(visitor, OnDataForStream(1, _)); | |
| EXPECT_CALL(visitor, OnEndStream(1)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(frames.size(), static_cast<size_t>(result)); | |
| int submit_result = | |
| adapter->SubmitResponse(1, ToHeaders({{":status", "200"}}), true); | |
| EXPECT_EQ(submit_result, 0); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, 1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, 1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS, | |
| SpdyFrameType::HEADERS})); | |
| EXPECT_FALSE(adapter->want_write()); | |
| } | |
| TEST(OgHttp2AdapterTest, IncompleteRequestWithServerResponse) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| EXPECT_FALSE(adapter->want_write()); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}, | |
| /*fin=*/false) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, _, _)).Times(4); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(frames.size(), static_cast<size_t>(result)); | |
| int submit_result = | |
| adapter->SubmitResponse(1, ToHeaders({{":status", "200"}}), true); | |
| EXPECT_EQ(submit_result, 0); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, 1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, 1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| // RST_STREAM NO_ERROR option is disabled. | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS, | |
| SpdyFrameType::HEADERS})); | |
| EXPECT_FALSE(adapter->want_write()); | |
| } | |
| TEST(OgHttp2AdapterTest, IncompleteRequestWithServerResponseRstStreamEnabled) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| options.rst_stream_no_error_when_incomplete = true; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| EXPECT_FALSE(adapter->want_write()); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}, | |
| /*fin=*/false) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, _, _)).Times(4); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(frames.size(), static_cast<size_t>(result)); | |
| int submit_result = | |
| adapter->SubmitResponse(1, ToHeaders({{":status", "200"}}), true); | |
| EXPECT_EQ(submit_result, 0); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, 1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, 1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 1, 4, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(RST_STREAM, 1, 4, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT( | |
| visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS, | |
| SpdyFrameType::HEADERS, SpdyFrameType::RST_STREAM})); | |
| EXPECT_FALSE(adapter->want_write()); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerHandlesMultipleContentLength) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| EXPECT_FALSE(adapter->want_write()); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/1"}, | |
| {"content-length", "7"}, | |
| {"content-length", "7"}}, | |
| /*fin=*/false) | |
| .Headers(3, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/3"}, | |
| {"content-length", "11"}, | |
| {"content-length", "13"}}, | |
| /*fin=*/false) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":method", "POST")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":scheme", "https")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":authority", "example.com")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":path", "/1")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, "content-length", "7")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| // Stream 3 | |
| EXPECT_CALL(visitor, OnFrameHeader(3, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(3)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, ":method", "POST")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, ":scheme", "https")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, ":authority", "example.com")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, ":path", "/3")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, "content-length", "11")); | |
| EXPECT_CALL( | |
| visitor, | |
| OnInvalidFrame(3, Http2VisitorInterface::InvalidFrameError::kHttpHeader)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(frames.size(), static_cast<size_t>(result)); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerSendsInvalidTrailers) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| EXPECT_FALSE(adapter->want_write()); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":method", "GET")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":scheme", "https")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":authority", "example.com")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":path", "/this/is/request/one")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnEndStream(1)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(frames.size(), static_cast<size_t>(result)); | |
| const absl::string_view kBody = "This is an example response body."; | |
| // The body source must indicate that the end of the body is not the end of | |
| // the stream. | |
| visitor.AppendPayloadForStream(1, kBody); | |
| visitor.SetEndData(1, false); | |
| int submit_result = adapter->SubmitResponse( | |
| 1, ToHeaders({{":status", "200"}, {"x-comment", "Sure, sounds good."}}), | |
| false); | |
| EXPECT_EQ(submit_result, 0); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, 1, _, 0x4)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, 1, _, 0x4, 0)); | |
| EXPECT_CALL(visitor, OnFrameSent(DATA, 1, _, 0x0, 0)); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS, | |
| SpdyFrameType::HEADERS, SpdyFrameType::DATA})); | |
| EXPECT_THAT(visitor.data(), testing::HasSubstr(kBody)); | |
| visitor.Clear(); | |
| EXPECT_FALSE(adapter->want_write()); | |
| // The body source has been exhausted by the call to Send() above. | |
| int trailer_result = | |
| adapter->SubmitTrailer(1, ToHeaders({{":final-status", "a-ok"}})); | |
| ASSERT_EQ(trailer_result, 0); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, 1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, 1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::HEADERS})); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerHandlesDataWithPadding) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}, | |
| /*fin=*/false) | |
| .Data(1, "This is the request body.", | |
| /*fin=*/true, /*padding_length=*/39) | |
| .Headers(3, | |
| {{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/two"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, _, _)).Times(4); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, 25 + 39, DATA, 0x9)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(1, 25 + 39)); | |
| // Note: oghttp2 passes padding information before the actual data. | |
| EXPECT_CALL(visitor, OnDataPaddingLength(1, 39)); | |
| EXPECT_CALL(visitor, OnDataForStream(1, "This is the request body.")); | |
| EXPECT_CALL(visitor, OnEndStream(1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(3, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(3)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, _, _)).Times(4); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(3)); | |
| EXPECT_CALL(visitor, OnEndStream(3)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(static_cast<int64_t>(frames.size()), result); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS})); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerHandlesHostHeader) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":path", "/this/is/request/one"}, | |
| {"host", "example.com"}}, | |
| /*fin=*/true) | |
| .Headers(3, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}, | |
| {"host", "example.com"}}, | |
| /*fin=*/true) | |
| .Headers(5, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":authority", "foo.com"}, | |
| {":path", "/this/is/request/one"}, | |
| {"host", "bar.com"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, _, _)).Times(4); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnEndStream(1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(3, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(3)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, _, _)).Times(5); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(3)); | |
| EXPECT_CALL(visitor, OnEndStream(3)); | |
| EXPECT_CALL(visitor, OnFrameHeader(5, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(5)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(5, _, _)).Times(4); | |
| EXPECT_CALL( | |
| visitor, | |
| OnInvalidFrame(5, Http2VisitorInterface::InvalidFrameError::kHttpHeader)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(frames.size(), static_cast<size_t>(result)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 5, 4, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 5, 4, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(5, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| visitor.Clear(); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerHandlesHostHeaderWithLaxValidation) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| options.allow_different_host_and_authority = true; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":path", "/this/is/request/one"}, | |
| {"host", "example.com"}}, | |
| /*fin=*/true) | |
| .Headers(3, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}, | |
| {"host", "example.com"}}, | |
| /*fin=*/true) | |
| .Headers(5, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":authority", "foo.com"}, | |
| {":path", "/this/is/request/one"}, | |
| {"host", "bar.com"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, _, _)).Times(4); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnEndStream(1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(3, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(3)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, _, _)).Times(5); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(3)); | |
| EXPECT_CALL(visitor, OnEndStream(3)); | |
| EXPECT_CALL(visitor, OnFrameHeader(5, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(5)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(5, _, _)).Times(5); | |
| // No error, because the option is set to allow different host and authority | |
| // values. | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(5)); | |
| EXPECT_CALL(visitor, OnEndStream(5)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(frames.size(), static_cast<size_t>(result)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| visitor.Clear(); | |
| } | |
| // Tests the case where the response body is in the progress of being sent while | |
| // trailers are queued. | |
| TEST(OgHttp2AdapterTest, ServerSubmitsTrailersWhileDataDeferred) { | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| for (const bool add_more_body_data : {true, false}) { | |
| TestVisitor visitor; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}, | |
| /*fin=*/false) | |
| .WindowUpdate(1, 2000) | |
| .Data(1, "This is the request body.") | |
| .WindowUpdate(0, 2000) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, _, _)).Times(4); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, 4, WINDOW_UPDATE, 0)); | |
| EXPECT_CALL(visitor, OnWindowUpdate(1, 2000)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, DATA, 0)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(1, _)); | |
| EXPECT_CALL(visitor, OnDataForStream(1, "This is the request body.")); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 4, WINDOW_UPDATE, 0)); | |
| EXPECT_CALL(visitor, OnWindowUpdate(0, 2000)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(frames.size(), static_cast<size_t>(result)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| visitor.Clear(); | |
| const absl::string_view kBody = "This is an example response body."; | |
| // The body source must indicate that the end of the body is not the end of | |
| // the stream. | |
| visitor.AppendPayloadForStream(1, kBody); | |
| int submit_result = adapter->SubmitResponse( | |
| 1, ToHeaders({{":status", "200"}, {"x-comment", "Sure, sounds good."}}), | |
| false); | |
| EXPECT_EQ(submit_result, 0); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, 1, _, 0x4)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, 1, _, 0x4, 0)); | |
| EXPECT_CALL(visitor, OnFrameSent(DATA, 1, _, 0x0, 0)); | |
| send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| visitor.Clear(); | |
| EXPECT_FALSE(adapter->want_write()); | |
| if (add_more_body_data) { | |
| visitor.AppendPayloadForStream(1, " More body! This is ignored."); | |
| } | |
| int trailer_result = | |
| adapter->SubmitTrailer(1, ToHeaders({{"final-status", "a-ok"}})); | |
| ASSERT_EQ(trailer_result, 0); | |
| // Even though the data source has not finished sending data, the library | |
| // will write the trailers anyway. | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, 1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, 1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::HEADERS})); | |
| EXPECT_FALSE(adapter->want_write()); | |
| } | |
| } | |
| // Tests the case where the response body and trailers become blocked by flow | |
| // control while the stream is writing. Regression test for | |
| // https://github.com/envoyproxy/envoy/issues/31710 | |
| TEST(OgHttp2AdapterTest, ServerSubmitsTrailersWithFlowControlBlockage) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}, | |
| /*fin=*/false) | |
| .WindowUpdate(0, 2000) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, _, _)).Times(4); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 4, WINDOW_UPDATE, 0)); | |
| EXPECT_CALL(visitor, OnWindowUpdate(0, 2000)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(frames.size(), static_cast<size_t>(result)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| visitor.Clear(); | |
| EXPECT_EQ(kInitialFlowControlWindowSize, adapter->GetStreamSendWindowSize(1)); | |
| const std::string kBody(60000, 'a'); | |
| // The body source must indicate that the end of the body is not the end of | |
| // the stream. | |
| visitor.AppendPayloadForStream(1, kBody); | |
| int submit_result = adapter->SubmitResponse( | |
| 1, ToHeaders({{":status", "200"}, {"x-comment", "Sure, sounds good."}}), | |
| false); | |
| EXPECT_EQ(submit_result, 0); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, 1, _, 0x4)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, 1, _, 0x4, 0)); | |
| EXPECT_CALL(visitor, OnFrameSent(DATA, 1, _, 0x0, 0)).Times(4); | |
| send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::HEADERS, SpdyFrameType::DATA, | |
| SpdyFrameType::DATA, SpdyFrameType::DATA, | |
| SpdyFrameType::DATA})); | |
| visitor.Clear(); | |
| EXPECT_FALSE(adapter->want_write()); | |
| visitor.AppendPayloadForStream(1, std::string(6000, 'b')); | |
| // The next response body data payload is larger than the available stream | |
| // flow control window. | |
| EXPECT_LT(adapter->GetStreamSendWindowSize(1), 6000); | |
| // There is more than enough connection flow control window. | |
| EXPECT_GT(adapter->GetSendWindowSize(), 6000); | |
| adapter->ResumeStream(1); | |
| int trailer_result = | |
| adapter->SubmitTrailer(1, ToHeaders({{"final-status", "a-ok"}})); | |
| ASSERT_EQ(trailer_result, 0); | |
| EXPECT_TRUE(adapter->want_write()); | |
| // This will send data but not trailers, because the data source hasn't | |
| // finished sending. | |
| EXPECT_CALL(visitor, OnFrameSent(DATA, 1, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnLocalFlowControlExhausted(1)); | |
| send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::DATA})); | |
| visitor.Clear(); | |
| // Stream flow control window is exhausted. | |
| EXPECT_EQ(adapter->GetStreamSendWindowSize(1), 0); | |
| // Connection flow control window is available. | |
| EXPECT_GT(adapter->GetSendWindowSize(), 0); | |
| // After a window update, the adapter will send the last data, followed by | |
| // trailers. | |
| EXPECT_CALL(visitor, OnFrameHeader(1, 4, WINDOW_UPDATE, 0)); | |
| EXPECT_CALL(visitor, OnWindowUpdate(1, 2000)); | |
| adapter->ProcessBytes(TestFrameSequence().WindowUpdate(1, 2000).Serialize()); | |
| EXPECT_CALL(visitor, OnFrameSent(DATA, 1, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, 1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, 1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::DATA, SpdyFrameType::HEADERS})); | |
| EXPECT_FALSE(adapter->want_write()); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerSubmitsTrailersWithDataEndStream) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = | |
| TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}) | |
| .Data(1, "Example data, woohoo.") | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":method", "GET")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":scheme", "https")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":authority", "example.com")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":path", "/this/is/request/one")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, DATA, 0)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(1, _)); | |
| EXPECT_CALL(visitor, OnDataForStream(1, _)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(static_cast<size_t>(result), frames.size()); | |
| // Send a body that will end with the END_STREAM flag. | |
| const absl::string_view kBody = "This is an example response body."; | |
| visitor.AppendPayloadForStream(1, kBody); | |
| visitor.SetEndData(1, true); | |
| int submit_result = | |
| adapter->SubmitResponse(1, ToHeaders({{":status", "200"}}), false); | |
| ASSERT_EQ(submit_result, 0); | |
| const std::vector<Header> trailers = | |
| ToHeaders({{"extra-info", "Trailers are weird but good?"}}); | |
| submit_result = adapter->SubmitTrailer(1, trailers); | |
| ASSERT_EQ(submit_result, 0); | |
| // The data should be sent, but because it has END_STREAM, it would not be | |
| // correct to send trailers afterward. The stream should be closed. | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, 1, _, END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, 1, _, END_HEADERS_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnFrameSent(DATA, 1, _, END_STREAM_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::INTERNAL_ERROR)); | |
| const int send_result = adapter->Send(); | |
| EXPECT_EQ(send_result, 0); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS, | |
| SpdyFrameType::HEADERS, SpdyFrameType::DATA})); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerSubmitsTrailersWithDataEndStreamAndDeferral) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = | |
| TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}) | |
| .Data(1, "Example data, woohoo.") | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":method", "GET")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":scheme", "https")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":authority", "example.com")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":path", "/this/is/request/one")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, DATA, 0)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(1, _)); | |
| EXPECT_CALL(visitor, OnDataForStream(1, _)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(static_cast<size_t>(result), frames.size()); | |
| // Send a body that will end with the END_STREAM flag. Don't end the body here | |
| // so that more body can be added later. | |
| const absl::string_view kBody = "This is an example response body."; | |
| visitor.AppendPayloadForStream(1, kBody); | |
| int submit_result = | |
| adapter->SubmitResponse(1, ToHeaders({{":status", "200"}}), false); | |
| ASSERT_EQ(submit_result, 0); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, 1, _, END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, 1, _, END_HEADERS_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnFrameSent(DATA, 1, _, 0x0, 0)); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(send_result, 0); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS, | |
| SpdyFrameType::HEADERS, SpdyFrameType::DATA})); | |
| visitor.Clear(); | |
| const std::vector<Header> trailers = | |
| ToHeaders({{"extra-info", "Trailers are weird but good?"}}); | |
| submit_result = adapter->SubmitTrailer(1, trailers); | |
| ASSERT_EQ(submit_result, 0); | |
| // Add more body and signal the end of data. Resuming the stream should allow | |
| // the new body to be sent. | |
| visitor.AppendPayloadForStream(1, kBody); | |
| visitor.SetEndData(1, true); | |
| adapter->ResumeStream(1); | |
| // The new body should be sent, but because it has END_STREAM, it would not be | |
| // correct to send trailers afterward. The stream should be closed. | |
| EXPECT_CALL(visitor, OnFrameSent(DATA, 1, _, END_STREAM_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::INTERNAL_ERROR)); | |
| send_result = adapter->Send(); | |
| EXPECT_EQ(send_result, 0); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::DATA})); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientDisobeysConnectionFlowControl) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}, | |
| {"accept", "some bogus value!"}}, | |
| /*fin=*/false) | |
| // 70000 bytes of data | |
| .Data(1, std::string(16384, 'a')) | |
| .Data(1, std::string(16384, 'a')) | |
| .Data(1, std::string(16384, 'a')) | |
| .Data(1, std::string(16384, 'a')) | |
| .Data(1, std::string(4464, 'a')) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream).Times(5); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, 16384, DATA, 0x0)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(1, 16384)); | |
| EXPECT_CALL(visitor, OnDataForStream(1, _)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, 16384, DATA, 0x0)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(1, 16384)); | |
| EXPECT_CALL(visitor, OnDataForStream(1, _)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, 16384, DATA, 0x0)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(1, 16384)); | |
| EXPECT_CALL(visitor, OnDataForStream(1, _)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, 16384, DATA, 0x0)); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kFlowControlError)); | |
| // No further frame data or headers are delivered. | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(frames.size(), static_cast<size_t>(result)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL( | |
| visitor, | |
| OnFrameSent(GOAWAY, 0, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::FLOW_CONTROL_ERROR))); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::GOAWAY})); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientDisobeysConnectionFlowControlWithOneDataFrame) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| // Allow the client to send a DATA frame that exceeds the connection flow | |
| // control window. | |
| const uint32_t window_overflow_bytes = kInitialFlowControlWindowSize + 1; | |
| adapter->SubmitSettings({{MAX_FRAME_SIZE, window_overflow_bytes}}); | |
| const std::string initial_frames = | |
| TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}, | |
| /*fin=*/false) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream).Times(4); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| int64_t process_result = adapter->ProcessBytes(initial_frames); | |
| EXPECT_EQ(initial_frames.size(), static_cast<size_t>(process_result)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| // Outbound SETTINGS containing MAX_FRAME_SIZE. | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 6, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 6, 0x0, 0)); | |
| // Ack of client's initial settings. | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS})); | |
| visitor.Clear(); | |
| // Now let the client ack the MAX_FRAME_SIZE SETTINGS and send a DATA frame to | |
| // overflow the connection-level window. The result should be a GOAWAY. | |
| const std::string overflow_frames = | |
| TestFrameSequence() | |
| .SettingsAck() | |
| .Data(1, std::string(window_overflow_bytes, 'a')) | |
| .Serialize(); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnSettingsAck()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, window_overflow_bytes, DATA, 0x0)); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kFlowControlError)); | |
| // No further frame data is delivered. | |
| process_result = adapter->ProcessBytes(overflow_frames); | |
| EXPECT_EQ(overflow_frames.size(), static_cast<size_t>(process_result)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL( | |
| visitor, | |
| OnFrameSent(GOAWAY, 0, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::FLOW_CONTROL_ERROR))); | |
| send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::GOAWAY})); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientDisobeysConnectionFlowControlAcrossReads) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| // Allow the client to send a DATA frame that exceeds the connection flow | |
| // control window. | |
| const uint32_t window_overflow_bytes = kInitialFlowControlWindowSize + 1; | |
| adapter->SubmitSettings({{MAX_FRAME_SIZE, window_overflow_bytes}}); | |
| const std::string initial_frames = | |
| TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}, | |
| /*fin=*/false) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream).Times(4); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| int64_t process_result = adapter->ProcessBytes(initial_frames); | |
| EXPECT_EQ(initial_frames.size(), static_cast<size_t>(process_result)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| // Outbound SETTINGS containing MAX_FRAME_SIZE. | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 6, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 6, 0x0, 0)); | |
| // Ack of client's initial settings. | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS})); | |
| visitor.Clear(); | |
| // Now let the client ack the MAX_FRAME_SIZE SETTINGS and send a DATA frame to | |
| // overflow the connection-level window. The result should be a GOAWAY. | |
| const std::string overflow_frames = | |
| TestFrameSequence() | |
| .SettingsAck() | |
| .Data(1, std::string(window_overflow_bytes, 'a')) | |
| .Serialize(); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnSettingsAck()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, window_overflow_bytes, DATA, 0x0)); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kFlowControlError)); | |
| const size_t chunk_length = 16384; | |
| ASSERT_GE(overflow_frames.size(), chunk_length); | |
| process_result = | |
| adapter->ProcessBytes(overflow_frames.substr(0, chunk_length)); | |
| EXPECT_EQ(chunk_length, static_cast<size_t>(process_result)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL( | |
| visitor, | |
| OnFrameSent(GOAWAY, 0, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::FLOW_CONTROL_ERROR))); | |
| send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::GOAWAY})); | |
| } | |
| TEST(OgHttp2AdapterTest, ClientDisobeysStreamFlowControl) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}, | |
| {"accept", "some bogus value!"}}, | |
| /*fin=*/false) | |
| .Serialize(); | |
| const std::string more_frames = TestFrameSequence() | |
| // 70000 bytes of data | |
| .Data(1, std::string(16384, 'a')) | |
| .Data(1, std::string(16384, 'a')) | |
| .Data(1, std::string(16384, 'a')) | |
| .Data(1, std::string(16384, 'a')) | |
| .Data(1, std::string(4464, 'a')) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream).Times(5); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(frames.size(), static_cast<size_t>(result)); | |
| adapter->SubmitWindowUpdate(0, 20000); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(WINDOW_UPDATE, 0, 4, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(WINDOW_UPDATE, 0, 4, 0x0, 0)); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS, | |
| SpdyFrameType::WINDOW_UPDATE})); | |
| visitor.Clear(); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, 16384, DATA, 0x0)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(1, 16384)); | |
| EXPECT_CALL(visitor, OnDataForStream(1, _)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, 16384, DATA, 0x0)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(1, 16384)); | |
| EXPECT_CALL(visitor, OnDataForStream(1, _)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, 16384, DATA, 0x0)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(1, 16384)); | |
| EXPECT_CALL(visitor, OnDataForStream(1, _)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, 16384, DATA, 0x0)); | |
| EXPECT_CALL(visitor, OnRemoteFlowControlExhausted(1)).Times(2); | |
| // No further frame data or headers are delivered. | |
| result = adapter->ProcessBytes(more_frames); | |
| EXPECT_EQ(more_frames.size(), static_cast<size_t>(result)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 1, 4, 0x0)); | |
| EXPECT_CALL( | |
| visitor, | |
| OnFrameSent(RST_STREAM, 1, 4, 0x0, | |
| static_cast<int>(Http2ErrorCode::FLOW_CONTROL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::RST_STREAM})); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerErrorWhileHandlingHeaders) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}, | |
| {"accept", "some bogus value!"}}, | |
| /*fin=*/false) | |
| .WindowUpdate(1, 2000) | |
| .Data(1, "This is the request body.") | |
| .WindowUpdate(0, 2000) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":method", "POST")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":scheme", "https")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":authority", "example.com")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":path", "/this/is/request/one")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, "accept", "some bogus value!")) | |
| .WillOnce(testing::Return(OnHeaderResult::HEADER_RST_STREAM)); | |
| // Stream WINDOW_UPDATE and DATA frames are not delivered to the visitor. | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 4, WINDOW_UPDATE, 0)); | |
| EXPECT_CALL(visitor, OnWindowUpdate(0, 2000)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(frames.size(), static_cast<size_t>(result)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 1, 4, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 1, 4, 0x0, | |
| static_cast<int>(Http2ErrorCode::INTERNAL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| int send_result = adapter->Send(); | |
| // Some bytes should have been serialized. | |
| EXPECT_EQ(0, send_result); | |
| // SETTINGS ack | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS, | |
| SpdyFrameType::RST_STREAM})); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerErrorWhileHandlingHeadersDropsFrames) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}, | |
| {"accept", "some bogus value!"}}, | |
| /*fin=*/false) | |
| .WindowUpdate(1, 2000) | |
| .Data(1, "This is the request body.") | |
| .Metadata(1, "This is the request metadata.") | |
| .RstStream(1, Http2ErrorCode::CANCEL) | |
| .WindowUpdate(0, 2000) | |
| .Headers(3, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/two"}}, | |
| /*fin=*/false) | |
| .Metadata(3, "This is the request metadata.", | |
| /*multiple_frames=*/true) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, _, _)).Times(4); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, "accept", "some bogus value!")) | |
| .WillOnce(testing::Return(OnHeaderResult::HEADER_RST_STREAM)); | |
| // Frames for the RST_STREAM-marked stream are not delivered to the visitor. | |
| // Note: nghttp2 still delivers control frames and metadata for the stream. | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 4, WINDOW_UPDATE, 0)); | |
| EXPECT_CALL(visitor, OnWindowUpdate(0, 2000)); | |
| EXPECT_CALL(visitor, OnFrameHeader(3, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(3)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, _, _)).Times(4); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(3)); | |
| EXPECT_CALL(visitor, OnFrameHeader(3, _, kMetadataFrameType, 0)); | |
| EXPECT_CALL(visitor, OnBeginMetadataForStream(3, _)); | |
| EXPECT_CALL(visitor, OnMetadataForStream(3, "This is the re")) | |
| .WillOnce(testing::DoAll( | |
| [&adapter]() { | |
| adapter->SubmitRst(3, Http2ErrorCode::REFUSED_STREAM); | |
| }, | |
| testing::Return(true))); | |
| // The rest of the metadata is not delivered to the visitor. | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(frames.size(), static_cast<size_t>(result)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 1, 4, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 1, 4, 0x0, | |
| static_cast<int>(Http2ErrorCode::INTERNAL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 3, 4, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 3, 4, 0x0, | |
| static_cast<int>(Http2ErrorCode::REFUSED_STREAM))); | |
| EXPECT_CALL(visitor, OnCloseStream(3, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| int send_result = adapter->Send(); | |
| // Some bytes should have been serialized. | |
| EXPECT_EQ(0, send_result); | |
| // SETTINGS ack | |
| EXPECT_THAT( | |
| visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS, | |
| SpdyFrameType::RST_STREAM, SpdyFrameType::RST_STREAM})); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerConnectionErrorWhileHandlingHeaders) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}, | |
| {"Accept", "uppercase, oh boy!"}}, | |
| /*fin=*/false) | |
| .WindowUpdate(1, 2000) | |
| .Data(1, "This is the request body.") | |
| .WindowUpdate(0, 2000) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":method", "POST")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":scheme", "https")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":authority", "example.com")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":path", "/this/is/request/one")); | |
| EXPECT_CALL( | |
| visitor, | |
| OnInvalidFrame(1, Http2VisitorInterface::InvalidFrameError::kHttpHeader)) | |
| .WillOnce(testing::Return(false)); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kHeaderError)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_LT(result, 0); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 1, 4, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 1, 4, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(GOAWAY, 0, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| int send_result = adapter->Send(); | |
| // Some bytes should have been serialized. | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::RST_STREAM, | |
| SpdyFrameType::GOAWAY})); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerErrorAfterHandlingHeaders) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}, | |
| /*fin=*/false) | |
| .WindowUpdate(1, 2000) | |
| .Data(1, "This is the request body.") | |
| .WindowUpdate(0, 2000) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":method", "POST")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":scheme", "https")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":authority", "example.com")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":path", "/this/is/request/one")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)) | |
| .WillOnce(testing::Return(false)); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kParseError)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_LT(result, 0); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(GOAWAY, 0, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::INTERNAL_ERROR))); | |
| int send_result = adapter->Send(); | |
| // Some bytes should have been serialized. | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::GOAWAY})); | |
| } | |
| // Exercises the case when a visitor chooses to reject a frame based solely on | |
| // the frame header, which is a fatal error for the connection. | |
| TEST(OgHttp2AdapterTest, ServerRejectsFrameHeader) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Ping(64) | |
| .Headers(1, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}, | |
| /*fin=*/false) | |
| .WindowUpdate(1, 2000) | |
| .Data(1, "This is the request body.") | |
| .WindowUpdate(0, 2000) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 8, PING, 0)) | |
| .WillOnce(testing::Return(false)); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kParseError)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_LT(result, 0); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(GOAWAY, 0, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::INTERNAL_ERROR))); | |
| int send_result = adapter->Send(); | |
| // Some bytes should have been serialized. | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::GOAWAY})); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerRejectsBeginningOfData) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}, | |
| /*fin=*/false) | |
| .Data(1, "This is the request body.") | |
| .Headers(3, | |
| {{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/two"}}, | |
| /*fin=*/true) | |
| .RstStream(3, Http2ErrorCode::CANCEL) | |
| .Ping(47) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":method", "POST")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":scheme", "https")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":authority", "example.com")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":path", "/this/is/request/one")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, 25, DATA, 0)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(1, 25)) | |
| .WillOnce(testing::Return(false)); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kParseError)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_LT(result, 0); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(GOAWAY, 0, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::INTERNAL_ERROR))); | |
| int send_result = adapter->Send(); | |
| // Some bytes should have been serialized. | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::GOAWAY})); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerReceivesTooLargeHeader) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| options.max_header_list_bytes = 64 * 1024; | |
| options.max_header_field_size = 64 * 1024; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| // Due to configuration, the library will accept a maximum of 64kB of huffman | |
| // encoded data per header field. | |
| const std::string too_large_value = std::string(80 * 1024, 'q'); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}, | |
| {"x-toobig", too_large_value}}, | |
| /*fin=*/true) | |
| .Headers(3, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/two"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, END_STREAM_FLAG)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":method", "POST")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":scheme", "https")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":authority", "example.com")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":path", "/this/is/request/one")); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, CONTINUATION, 0)).Times(3); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, CONTINUATION, END_HEADERS_FLAG)); | |
| // Further header processing is skipped, as the header field is too large. | |
| EXPECT_CALL(visitor, | |
| OnFrameHeader(3, _, HEADERS, END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(3)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, _, _)).Times(4); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(3)); | |
| EXPECT_CALL(visitor, OnEndStream(3)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(static_cast<int64_t>(frames.size()), result); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 1, 4, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 1, 4, 0x0, | |
| static_cast<int>(Http2ErrorCode::INTERNAL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS, | |
| SpdyFrameType::RST_STREAM})); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerReceivesInvalidAuthority) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":authority", "ex|ample.com"}, | |
| {":path", "/this/is/request/one"}}, | |
| /*fin=*/false) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":method", "POST")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":scheme", "https")); | |
| EXPECT_CALL( | |
| visitor, | |
| OnInvalidFrame(1, Http2VisitorInterface::InvalidFrameError::kHttpHeader)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(static_cast<int64_t>(frames.size()), result); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0x0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0x0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 1, 4, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 1, 4, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS, | |
| SpdyFrameType::RST_STREAM})); | |
| } | |
| TEST(OgHttpAdapterTest, ServerReceivesGoAway) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}, | |
| /*fin=*/true) | |
| .GoAway(0, Http2ErrorCode::HTTP2_NO_ERROR, "") | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, | |
| OnFrameHeader(1, _, HEADERS, END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, _, _)).Times(4); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnEndStream(1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, _, GOAWAY, 0x0)); | |
| EXPECT_CALL(visitor, OnGoAway(0, Http2ErrorCode::HTTP2_NO_ERROR, "")); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(static_cast<int64_t>(frames.size()), result); | |
| // The server should still be able to send a response after receiving a GOAWAY | |
| // with a lower last-stream-ID field, as the stream was client-initiated. | |
| const int submit_result = | |
| adapter->SubmitResponse(1, ToHeaders({{":status", "200"}}), true); | |
| ASSERT_EQ(0, submit_result); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0x0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0x0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, 1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, 1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS, | |
| SpdyFrameType::HEADERS})); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerSubmitResponse) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| EXPECT_FALSE(adapter->want_write()); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| testing::InSequence s; | |
| const char* kSentinel1 = "arbitrary pointer 1"; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":method", "GET")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":scheme", "https")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":authority", "example.com")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":path", "/this/is/request/one")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)) | |
| .WillOnce([&adapter, kSentinel1]() { | |
| adapter->SetStreamUserData(1, const_cast<char*>(kSentinel1)); | |
| return true; | |
| }); | |
| EXPECT_CALL(visitor, OnEndStream(1)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(frames.size(), result); | |
| EXPECT_EQ(1, adapter->GetHighestReceivedStreamId()); | |
| // Server will want to send a SETTINGS and a SETTINGS ack. | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 6, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 6, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS})); | |
| visitor.Clear(); | |
| EXPECT_EQ(0, adapter->GetHpackEncoderDynamicTableSize()); | |
| EXPECT_FALSE(adapter->want_write()); | |
| const absl::string_view kBody = "This is an example response body."; | |
| // A data fin is not sent so that the stream remains open, and the flow | |
| // control state can be verified. | |
| visitor.AppendPayloadForStream(1, kBody); | |
| int submit_result = adapter->SubmitResponse( | |
| 1, | |
| ToHeaders({{":status", "404"}, | |
| {"x-comment", "I have no idea what you're talking about."}}), | |
| false); | |
| EXPECT_EQ(submit_result, 0); | |
| EXPECT_TRUE(adapter->want_write()); | |
| // Stream user data should have been set successfully after receiving headers. | |
| EXPECT_EQ(kSentinel1, adapter->GetStreamUserData(1)); | |
| adapter->SetStreamUserData(1, nullptr); | |
| EXPECT_EQ(nullptr, adapter->GetStreamUserData(1)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, 1, _, 0x4)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, 1, _, 0x4, 0)); | |
| EXPECT_CALL(visitor, OnFrameSent(DATA, 1, _, 0x0, 0)); | |
| send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::HEADERS, SpdyFrameType::DATA})); | |
| EXPECT_THAT(visitor.data(), testing::HasSubstr(kBody)); | |
| EXPECT_FALSE(adapter->want_write()); | |
| // Some data was sent, so the remaining send window size should be less than | |
| // the default. | |
| EXPECT_LT(adapter->GetStreamSendWindowSize(1), kInitialFlowControlWindowSize); | |
| EXPECT_GT(adapter->GetStreamSendWindowSize(1), 0); | |
| // Send window for a nonexistent stream is not available. | |
| EXPECT_EQ(adapter->GetStreamSendWindowSize(3), -1); | |
| EXPECT_GT(adapter->GetHpackEncoderDynamicTableSize(), 0); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerSubmitResponseWithResetFromClient) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| EXPECT_FALSE(adapter->want_write()); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream).Times(4); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnEndStream(1)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(frames.size(), result); | |
| EXPECT_EQ(1, adapter->GetHighestReceivedStreamId()); | |
| // Server will want to send a SETTINGS and a SETTINGS ack. | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 6, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 6, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS})); | |
| visitor.Clear(); | |
| EXPECT_FALSE(adapter->want_write()); | |
| const absl::string_view kBody = "This is an example response body."; | |
| visitor.AppendPayloadForStream(1, kBody); | |
| int submit_result = adapter->SubmitResponse( | |
| 1, | |
| ToHeaders({{":status", "404"}, | |
| {"x-comment", "I have no idea what you're talking about."}}), | |
| false); | |
| EXPECT_EQ(submit_result, 0); | |
| EXPECT_TRUE(adapter->want_write()); | |
| // Client resets the stream before the server can send the response. | |
| const std::string reset = | |
| TestFrameSequence().RstStream(1, Http2ErrorCode::CANCEL).Serialize(); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, 4, RST_STREAM, 0)); | |
| EXPECT_CALL(visitor, OnRstStream(1, Http2ErrorCode::CANCEL)); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::CANCEL)); | |
| const int64_t reset_result = adapter->ProcessBytes(reset); | |
| EXPECT_EQ(reset.size(), static_cast<size_t>(reset_result)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, 1, _, _)).Times(0); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, 1, _, _, _)).Times(0); | |
| EXPECT_CALL(visitor, OnFrameSent(DATA, 1, _, _, _)).Times(0); | |
| send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), testing::IsEmpty()); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerRejectsStreamData) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}, | |
| /*fin=*/false) | |
| .Data(1, "This is the request body.") | |
| .Headers(3, | |
| {{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/two"}}, | |
| /*fin=*/true) | |
| .RstStream(3, Http2ErrorCode::CANCEL) | |
| .Ping(47) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":method", "POST")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":scheme", "https")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":authority", "example.com")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":path", "/this/is/request/one")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, 25, DATA, 0)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(1, 25)); | |
| EXPECT_CALL(visitor, OnDataForStream(1, _)).WillOnce(testing::Return(false)); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kParseError)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_LT(result, 0); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(GOAWAY, 0, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::INTERNAL_ERROR))); | |
| int send_result = adapter->Send(); | |
| // Some bytes should have been serialized. | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::GOAWAY})); | |
| } | |
| // Exercises a naive mutually recursive test client and server. This test fails | |
| // without recursion guards in OgHttp2Session. | |
| TEST(OgHttp2AdapterInteractionTest, ClientServerInteractionTest) { | |
| TestVisitor client_visitor; | |
| OgHttp2Adapter::Options client_options; | |
| client_options.perspective = Perspective::kClient; | |
| auto client_adapter = OgHttp2Adapter::Create(client_visitor, client_options); | |
| TestVisitor server_visitor; | |
| OgHttp2Adapter::Options server_options; | |
| server_options.perspective = Perspective::kServer; | |
| auto server_adapter = OgHttp2Adapter::Create(server_visitor, server_options); | |
| EXPECT_CALL(client_visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(client_visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0x0)); | |
| EXPECT_CALL(client_visitor, OnBeforeFrameSent(HEADERS, 1, _, 0x5)); | |
| EXPECT_CALL(client_visitor, OnFrameSent(HEADERS, 1, _, 0x5, 0x0)); | |
| // Feeds bytes sent from the client into the server's ProcessBytes. | |
| EXPECT_CALL(client_visitor, OnReadyToSend(_)) | |
| .WillRepeatedly( | |
| testing::Invoke(server_adapter.get(), &OgHttp2Adapter::ProcessBytes)); | |
| // Feeds bytes sent from the server into the client's ProcessBytes. | |
| EXPECT_CALL(server_visitor, OnReadyToSend(_)) | |
| .WillRepeatedly( | |
| testing::Invoke(client_adapter.get(), &OgHttp2Adapter::ProcessBytes)); | |
| // Sets up the server to respond automatically to a request from a client. | |
| EXPECT_CALL(server_visitor, OnEndHeadersForStream(_)) | |
| .WillRepeatedly([&server_adapter](Http2StreamId stream_id) { | |
| server_adapter->SubmitResponse(stream_id, | |
| ToHeaders({{":status", "200"}}), true); | |
| server_adapter->Send(); | |
| return true; | |
| }); | |
| // Sets up the client to create a new stream automatically when receiving a | |
| // response. | |
| EXPECT_CALL(client_visitor, OnEndHeadersForStream(_)) | |
| .WillRepeatedly([&client_adapter, | |
| &client_visitor](Http2StreamId stream_id) { | |
| if (stream_id < 10) { | |
| const Http2StreamId new_stream_id = stream_id + 2; | |
| client_visitor.AppendPayloadForStream( | |
| new_stream_id, "This is an example request body."); | |
| client_visitor.SetEndData(new_stream_id, true); | |
| const int created_stream_id = client_adapter->SubmitRequest( | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", | |
| absl::StrCat("/this/is/request/", new_stream_id)}}), | |
| false, nullptr); | |
| EXPECT_EQ(new_stream_id, created_stream_id); | |
| client_adapter->Send(); | |
| } | |
| return true; | |
| }); | |
| // Submit a request to ensure the first stream is created. | |
| int stream_id = client_adapter->SubmitRequest( | |
| ToHeaders({{":method", "POST"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}), | |
| true, nullptr); | |
| EXPECT_EQ(stream_id, 1); | |
| client_adapter->Send(); | |
| } | |
| TEST(OgHttp2AdapterInteractionTest, | |
| ClientServerInteractionRepeatedHeaderNames) { | |
| TestVisitor client_visitor; | |
| OgHttp2Adapter::Options client_options; | |
| client_options.perspective = Perspective::kClient; | |
| auto client_adapter = OgHttp2Adapter::Create(client_visitor, client_options); | |
| const std::vector<Header> headers1 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}, | |
| {"accept", "text/plain"}, | |
| {"accept", "text/html"}}); | |
| const int32_t stream_id1 = | |
| client_adapter->SubmitRequest(headers1, true, nullptr); | |
| ASSERT_GT(stream_id1, 0); | |
| EXPECT_CALL(client_visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(client_visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(client_visitor, | |
| OnBeforeFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(client_visitor, | |
| OnFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| int send_result = client_adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| TestVisitor server_visitor; | |
| OgHttp2Adapter::Options server_options; | |
| server_options.perspective = Perspective::kServer; | |
| auto server_adapter = OgHttp2Adapter::Create(server_visitor, server_options); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(server_visitor, OnFrameHeader(0, _, SETTINGS, 0)); | |
| EXPECT_CALL(server_visitor, OnSettingsStart()); | |
| EXPECT_CALL(server_visitor, OnSetting).Times(testing::AnyNumber()); | |
| EXPECT_CALL(server_visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| EXPECT_CALL(server_visitor, OnFrameHeader(1, _, HEADERS, 5)); | |
| EXPECT_CALL(server_visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(server_visitor, OnHeaderForStream(1, ":method", "GET")); | |
| EXPECT_CALL(server_visitor, OnHeaderForStream(1, ":scheme", "http")); | |
| EXPECT_CALL(server_visitor, | |
| OnHeaderForStream(1, ":authority", "example.com")); | |
| EXPECT_CALL(server_visitor, | |
| OnHeaderForStream(1, ":path", "/this/is/request/one")); | |
| EXPECT_CALL(server_visitor, OnHeaderForStream(1, "accept", "text/plain")); | |
| EXPECT_CALL(server_visitor, OnHeaderForStream(1, "accept", "text/html")); | |
| EXPECT_CALL(server_visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(server_visitor, OnEndStream(1)); | |
| int64_t result = server_adapter->ProcessBytes(client_visitor.data()); | |
| EXPECT_EQ(client_visitor.data().size(), static_cast<size_t>(result)); | |
| } | |
| TEST(OgHttp2AdapterInteractionTest, ClientServerInteractionWithCookies) { | |
| TestVisitor client_visitor; | |
| OgHttp2Adapter::Options client_options; | |
| client_options.perspective = Perspective::kClient; | |
| auto client_adapter = OgHttp2Adapter::Create(client_visitor, client_options); | |
| // The Cookie header field value will be consolidated during HEADERS frame | |
| // serialization. | |
| const std::vector<Header> headers1 = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}, | |
| {"cookie", "a; b=2; c"}, | |
| {"cookie", "d=e, f, g; h"}}); | |
| const int32_t stream_id1 = | |
| client_adapter->SubmitRequest(headers1, true, nullptr); | |
| ASSERT_GT(stream_id1, 0); | |
| EXPECT_CALL(client_visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(client_visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(client_visitor, | |
| OnBeforeFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(client_visitor, | |
| OnFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| int send_result = client_adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| TestVisitor server_visitor; | |
| OgHttp2Adapter::Options server_options; | |
| server_options.perspective = Perspective::kServer; | |
| auto server_adapter = OgHttp2Adapter::Create(server_visitor, server_options); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(server_visitor, OnFrameHeader(0, _, SETTINGS, 0)); | |
| EXPECT_CALL(server_visitor, OnSettingsStart()); | |
| EXPECT_CALL(server_visitor, OnSetting).Times(testing::AnyNumber()); | |
| EXPECT_CALL(server_visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| EXPECT_CALL(server_visitor, OnFrameHeader(1, _, HEADERS, 5)); | |
| EXPECT_CALL(server_visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(server_visitor, OnHeaderForStream(1, ":method", "GET")); | |
| EXPECT_CALL(server_visitor, OnHeaderForStream(1, ":scheme", "http")); | |
| EXPECT_CALL(server_visitor, | |
| OnHeaderForStream(1, ":authority", "example.com")); | |
| EXPECT_CALL(server_visitor, | |
| OnHeaderForStream(1, ":path", "/this/is/request/one")); | |
| EXPECT_CALL(server_visitor, OnHeaderForStream(1, "cookie", "a; b=2; c")); | |
| EXPECT_CALL(server_visitor, OnHeaderForStream(1, "cookie", "d=e, f, g; h")); | |
| EXPECT_CALL(server_visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(server_visitor, OnEndStream(1)); | |
| int64_t result = server_adapter->ProcessBytes(client_visitor.data()); | |
| EXPECT_EQ(client_visitor.data().size(), static_cast<size_t>(result)); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerForbidsNewStreamBelowWatermark) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| EXPECT_EQ(0, adapter->GetHighestReceivedStreamId()); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(3, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}, | |
| /*fin=*/false) | |
| .Data(3, "This is the request body.") | |
| .Headers(1, | |
| {{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/two"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(3, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(3)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, ":method", "POST")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, ":scheme", "https")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, ":authority", "example.com")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, ":path", "/this/is/request/one")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(3)); | |
| EXPECT_CALL(visitor, OnFrameHeader(3, 25, DATA, 0)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(3, 25)); | |
| EXPECT_CALL(visitor, OnDataForStream(3, "This is the request body.")); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kInvalidNewStreamId)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(static_cast<size_t>(result), frames.size()); | |
| EXPECT_EQ(3, adapter->GetHighestReceivedStreamId()); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(GOAWAY, 0, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| int send_result = adapter->Send(); | |
| // Some bytes should have been serialized. | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::GOAWAY})); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerForbidsWindowUpdateOnIdleStream) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| EXPECT_EQ(0, adapter->GetHighestReceivedStreamId()); | |
| const std::string frames = | |
| TestFrameSequence().ClientPreface().WindowUpdate(1, 42).Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, 4, WINDOW_UPDATE, 0)); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kWrongFrameSequence)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(static_cast<size_t>(result), frames.size()); | |
| EXPECT_EQ(1, adapter->GetHighestReceivedStreamId()); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(GOAWAY, 0, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| int send_result = adapter->Send(); | |
| // Some bytes should have been serialized. | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::GOAWAY})); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerForbidsDataOnIdleStream) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| EXPECT_EQ(0, adapter->GetHighestReceivedStreamId()); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Data(1, "Sorry, out of order") | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, DATA, 0)); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kWrongFrameSequence)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(static_cast<size_t>(result), frames.size()); | |
| EXPECT_EQ(1, adapter->GetHighestReceivedStreamId()); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(GOAWAY, 0, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| int send_result = adapter->Send(); | |
| // Some bytes should have been serialized. | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::GOAWAY})); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerForbidsRstStreamOnIdleStream) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| EXPECT_EQ(0, adapter->GetHighestReceivedStreamId()); | |
| const std::string frames = | |
| TestFrameSequence() | |
| .ClientPreface() | |
| .RstStream(1, Http2ErrorCode::ENHANCE_YOUR_CALM) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, RST_STREAM, 0)); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kWrongFrameSequence)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(static_cast<size_t>(result), frames.size()); | |
| EXPECT_EQ(1, adapter->GetHighestReceivedStreamId()); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(GOAWAY, 0, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| int send_result = adapter->Send(); | |
| // Some bytes should have been serialized. | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::GOAWAY})); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerForbidsNewStreamAboveStreamLimit) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| adapter->SubmitSettings({{MAX_CONCURRENT_STREAMS, 1}}); | |
| const std::string initial_frames = | |
| TestFrameSequence().ClientPreface().Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| const int64_t initial_result = adapter->ProcessBytes(initial_frames); | |
| EXPECT_EQ(static_cast<size_t>(initial_result), initial_frames.size()); | |
| EXPECT_TRUE(adapter->want_write()); | |
| // Server initial SETTINGS (with MAX_CONCURRENT_STREAMS) and SETTINGS ack. | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 6, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 6, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS})); | |
| visitor.Clear(); | |
| // Let the client send a SETTINGS ack and then attempt to open more than the | |
| // advertised number of streams. The overflow stream should be rejected. | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .SettingsAck() | |
| .Headers(1, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}, | |
| /*fin=*/true) | |
| .Headers(3, | |
| {{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/two"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnSettingsAck()); | |
| EXPECT_CALL(visitor, | |
| OnFrameHeader(1, _, HEADERS, END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, _, _)).Times(4); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnEndStream(1)); | |
| EXPECT_CALL(visitor, | |
| OnFrameHeader(3, _, HEADERS, END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL( | |
| visitor, | |
| OnInvalidFrame(3, Http2VisitorInterface::InvalidFrameError::kProtocol)); | |
| // The oghttp2 stack also signals the error via OnConnectionError(). | |
| EXPECT_CALL(visitor, OnConnectionError( | |
| ConnectionError::kExceededMaxConcurrentStreams)); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(static_cast<size_t>(stream_result), stream_frames.size()); | |
| // The server should send a GOAWAY for this error, even though | |
| // OnInvalidFrame() returns true. | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(GOAWAY, 0, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::GOAWAY})); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerRstStreamsNewStreamAboveStreamLimitBeforeAck) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| adapter->SubmitSettings({{MAX_CONCURRENT_STREAMS, 1}}); | |
| const std::string initial_frames = | |
| TestFrameSequence().ClientPreface().Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| const int64_t initial_result = adapter->ProcessBytes(initial_frames); | |
| EXPECT_EQ(static_cast<size_t>(initial_result), initial_frames.size()); | |
| EXPECT_TRUE(adapter->want_write()); | |
| // Server initial SETTINGS (with MAX_CONCURRENT_STREAMS) and SETTINGS ack. | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 6, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 6, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS})); | |
| visitor.Clear(); | |
| // Let the client avoid sending a SETTINGS ack and attempt to open more than | |
| // the advertised number of streams. The server should still reject the | |
| // overflow stream, albeit with RST_STREAM REFUSED_STREAM instead of GOAWAY. | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .Headers(1, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}, | |
| /*fin=*/true) | |
| .Headers(3, | |
| {{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/two"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| EXPECT_CALL(visitor, | |
| OnFrameHeader(1, _, HEADERS, END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, _, _)).Times(4); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnEndStream(1)); | |
| EXPECT_CALL(visitor, | |
| OnFrameHeader(3, _, HEADERS, END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, | |
| OnInvalidFrame( | |
| 3, Http2VisitorInterface::InvalidFrameError::kRefusedStream)); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(static_cast<size_t>(stream_result), stream_frames.size()); | |
| // The server sends a RST_STREAM for the offending stream. | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 3, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 3, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::REFUSED_STREAM))); | |
| send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), EqualsFrames({SpdyFrameType::RST_STREAM})); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerForbidsProtocolPseudoheaderBeforeAck) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| options.allow_extended_connect = false; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string initial_frames = | |
| TestFrameSequence().ClientPreface().Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| const int64_t initial_result = adapter->ProcessBytes(initial_frames); | |
| EXPECT_EQ(static_cast<size_t>(initial_result), initial_frames.size()); | |
| // The client attempts to send a CONNECT request with the `:protocol` | |
| // pseudoheader before receiving the server's SETTINGS frame. | |
| const std::string stream1_frames = | |
| TestFrameSequence() | |
| .Headers(1, | |
| {{":method", "CONNECT"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}, | |
| {":protocol", "websocket"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| EXPECT_CALL(visitor, | |
| OnFrameHeader(1, _, HEADERS, END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, _, _)).Times(5); | |
| EXPECT_CALL(visitor, | |
| OnInvalidFrame( | |
| 1, Http2VisitorInterface::InvalidFrameError::kHttpMessaging)); | |
| int64_t stream_result = adapter->ProcessBytes(stream1_frames); | |
| EXPECT_EQ(static_cast<size_t>(stream_result), stream1_frames.size()); | |
| // Server initial SETTINGS and SETTINGS ack. | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| // The server sends a RST_STREAM for the offending stream. | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 1, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 1, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| // Server settings with ENABLE_CONNECT_PROTOCOL. | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 6, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 6, 0x0, 0)); | |
| adapter->SubmitSettings({{ENABLE_CONNECT_PROTOCOL, 1}}); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT( | |
| visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS, | |
| SpdyFrameType::RST_STREAM, SpdyFrameType::SETTINGS})); | |
| visitor.Clear(); | |
| // The client attempts to send a CONNECT request with the `:protocol` | |
| // pseudoheader before acking the server's SETTINGS frame. | |
| const std::string stream3_frames = | |
| TestFrameSequence() | |
| .Headers(3, | |
| {{":method", "CONNECT"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/two"}, | |
| {":protocol", "websocket"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| // After sending SETTINGS with `ENABLE_CONNECT_PROTOCOL`, oghttp2 matches | |
| // nghttp2 in allowing this, even though the `allow_extended_connect` option | |
| // is false. | |
| EXPECT_CALL(visitor, | |
| OnFrameHeader(3, _, HEADERS, END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(3)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, _, _)).Times(5); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(3)); | |
| EXPECT_CALL(visitor, OnEndStream(3)); | |
| stream_result = adapter->ProcessBytes(stream3_frames); | |
| EXPECT_EQ(static_cast<size_t>(stream_result), stream3_frames.size()); | |
| EXPECT_FALSE(adapter->want_write()); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerAllowsProtocolPseudoheaderAfterAck) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| adapter->SubmitSettings({{ENABLE_CONNECT_PROTOCOL, 1}}); | |
| const std::string initial_frames = | |
| TestFrameSequence().ClientPreface().Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| const int64_t initial_result = adapter->ProcessBytes(initial_frames); | |
| EXPECT_EQ(static_cast<size_t>(initial_result), initial_frames.size()); | |
| // Server initial SETTINGS (with ENABLE_CONNECT_PROTOCOL) and SETTINGS ack. | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 6, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 6, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| visitor.Clear(); | |
| // The client attempts to send a CONNECT request with the `:protocol` | |
| // pseudoheader after acking the server's SETTINGS frame. | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .SettingsAck() | |
| .Headers(1, | |
| {{":method", "CONNECT"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}, | |
| {":protocol", "websocket"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, _, SETTINGS, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnSettingsAck()); | |
| EXPECT_CALL(visitor, | |
| OnFrameHeader(1, _, HEADERS, END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, _, _)).Times(5); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnEndStream(1)); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(static_cast<size_t>(stream_result), stream_frames.size()); | |
| EXPECT_FALSE(adapter->want_write()); | |
| } | |
| TEST(OgHttp2AdapterTest, SkipsSendingFramesForRejectedStream) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string initial_frames = | |
| TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, | |
| OnFrameHeader(1, _, HEADERS, END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, _, _)).Times(4); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnEndStream(1)); | |
| const int64_t initial_result = adapter->ProcessBytes(initial_frames); | |
| EXPECT_EQ(static_cast<size_t>(initial_result), initial_frames.size()); | |
| visitor.AppendPayloadForStream( | |
| 1, "Here is some data, which will be completely ignored!"); | |
| int submit_result = | |
| adapter->SubmitResponse(1, ToHeaders({{":status", "200"}}), false); | |
| ASSERT_EQ(0, submit_result); | |
| auto source = std::make_unique<TestMetadataSource>(ToHeaderBlock(ToHeaders( | |
| {{"query-cost", "is too darn high"}, {"secret-sauce", "hollandaise"}}))); | |
| adapter->SubmitMetadata(1, 16384u, std::move(source)); | |
| adapter->SubmitWindowUpdate(1, 1024); | |
| adapter->SubmitRst(1, Http2ErrorCode::INTERNAL_ERROR); | |
| // Server initial SETTINGS and SETTINGS ack. | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| // The server sends a RST_STREAM for the offending stream. | |
| // The response HEADERS, DATA and WINDOW_UPDATE are all ignored. | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 1, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 1, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::INTERNAL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS, | |
| SpdyFrameType::RST_STREAM})); | |
| } | |
| TEST(OgHttpAdapterServerTest, ServerStartsShutdown) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| EXPECT_FALSE(adapter->want_write()); | |
| adapter->SubmitShutdownNotice(); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(GOAWAY, 0, _, 0x0, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::GOAWAY})); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerStartsShutdownAfterGoaway) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| EXPECT_FALSE(adapter->want_write()); | |
| adapter->SubmitGoAway(1, Http2ErrorCode::HTTP2_NO_ERROR, | |
| "and don't come back!"); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(GOAWAY, 0, _, 0x0, 0)); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::GOAWAY})); | |
| // No-op, since a GOAWAY has previously been enqueued. | |
| adapter->SubmitShutdownNotice(); | |
| EXPECT_FALSE(adapter->want_write()); | |
| } | |
| // Verifies that a connection-level processing error results in repeatedly | |
| // returning a positive value for ProcessBytes() to mark all data as consumed | |
| // when the blackhole option is enabled. | |
| TEST(OgHttp2AdapterTest, ConnectionErrorWithBlackholingData) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| options.blackhole_data_on_connection_error = true; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = | |
| TestFrameSequence().ClientPreface().WindowUpdate(1, 42).Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, 4, WINDOW_UPDATE, 0)); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kWrongFrameSequence)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(static_cast<size_t>(result), frames.size()); | |
| // Ask the connection to process more bytes. Because the option is enabled, | |
| // the data should be marked as consumed. | |
| const std::string next_frame = TestFrameSequence().Ping(42).Serialize(); | |
| const int64_t next_result = adapter->ProcessBytes(next_frame); | |
| EXPECT_EQ(static_cast<size_t>(next_result), next_frame.size()); | |
| } | |
| // Verifies that a connection-level processing error results in returning a | |
| // negative value for ProcessBytes() when the blackhole option is disabled. | |
| TEST(OgHttp2AdapterTest, ConnectionErrorWithoutBlackholingData) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| options.blackhole_data_on_connection_error = false; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = | |
| TestFrameSequence().ClientPreface().WindowUpdate(1, 42).Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, 4, WINDOW_UPDATE, 0)); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kWrongFrameSequence)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_LT(result, 0); | |
| // Ask the connection to process more bytes. Because the option is disabled, | |
| // ProcessBytes() should continue to return an error. | |
| const std::string next_frame = TestFrameSequence().Ping(42).Serialize(); | |
| const int64_t next_result = adapter->ProcessBytes(next_frame); | |
| EXPECT_LT(next_result, 0); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerDoesNotSendFramesAfterImmediateGoAway) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| // Submit a custom initial SETTINGS frame with one setting. | |
| adapter->SubmitSettings({{HEADER_TABLE_SIZE, 100u}}); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| EXPECT_CALL(visitor, | |
| OnFrameHeader(1, _, HEADERS, END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, _, _)).Times(4); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnEndStream(1)); | |
| const int64_t read_result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(static_cast<size_t>(read_result), frames.size()); | |
| // Submit a response for the stream. | |
| visitor.AppendPayloadForStream(1, "This data is doomed to never be written."); | |
| int submit_result = | |
| adapter->SubmitResponse(1, ToHeaders({{":status", "200"}}), false); | |
| ASSERT_EQ(0, submit_result); | |
| // Submit a WINDOW_UPDATE frame. | |
| adapter->SubmitWindowUpdate(kConnectionStreamId, 42); | |
| // Submit another SETTINGS frame. | |
| adapter->SubmitSettings({}); | |
| // Submit some metadata. | |
| auto source = std::make_unique<TestMetadataSource>(ToHeaderBlock(ToHeaders( | |
| {{"query-cost", "is too darn high"}, {"secret-sauce", "hollandaise"}}))); | |
| adapter->SubmitMetadata(1, 16384u, std::move(source)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| // Trigger a connection error. Only the response headers will be written. | |
| const std::string connection_error_frames = | |
| TestFrameSequence().WindowUpdate(3, 42).Serialize(); | |
| EXPECT_CALL(visitor, OnFrameHeader(3, 4, WINDOW_UPDATE, 0)); | |
| EXPECT_CALL(visitor, OnConnectionError(ConnectionError::kWrongFrameSequence)); | |
| const int64_t result = adapter->ProcessBytes(connection_error_frames); | |
| EXPECT_EQ(static_cast<size_t>(result), connection_error_frames.size()); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 6, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 6, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(GOAWAY, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(GOAWAY, 0, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| int send_result = adapter->Send(); | |
| // Some bytes should have been serialized. | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::GOAWAY})); | |
| visitor.Clear(); | |
| // Try to submit more frames for writing. They should not be written. | |
| adapter->SubmitPing(42); | |
| // TODO(diannahu): Enable the below expectation. | |
| // EXPECT_FALSE(adapter->want_write()); | |
| send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), testing::IsEmpty()); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerHandlesContentLength) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}, | |
| {"content-length", "2"}}) | |
| .Data(1, "hi", /*fin=*/true) | |
| .Headers(3, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/three"}, | |
| {"content-length", "nan"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1: content-length is correct | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, _, _)).Times(5); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, DATA, 1)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(1, 2)); | |
| EXPECT_CALL(visitor, OnDataForStream(1, "hi")); | |
| EXPECT_CALL(visitor, OnEndStream(1)); | |
| // Stream 3: content-length is not a number | |
| EXPECT_CALL(visitor, OnFrameHeader(3, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(3)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, _, _)).Times(4); | |
| EXPECT_CALL( | |
| visitor, | |
| OnInvalidFrame(3, Http2VisitorInterface::InvalidFrameError::kHttpHeader)); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(stream_frames.size(), static_cast<size_t>(stream_result)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 3, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 3, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(3, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS, | |
| SpdyFrameType::RST_STREAM})); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerHandlesContentLengthMismatch) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/two"}, | |
| {"content-length", "2"}}) | |
| .Data(1, "h", /*fin=*/true) | |
| .Headers(3, {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/three"}, | |
| {"content-length", "2"}}) | |
| .Data(3, "howdy", /*fin=*/true) | |
| .Headers(5, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/four"}, | |
| {"content-length", "2"}}, | |
| /*fin=*/true) | |
| .Headers(7, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/four"}, | |
| {"content-length", "2"}}, | |
| /*fin=*/false) | |
| .Data(7, "h", /*fin=*/false) | |
| .Headers(7, {{"extra-info", "Trailers with content-length mismatch"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1: content-length is larger than actual data | |
| // All data is delivered to the visitor. Note that neither oghttp2 nor | |
| // nghttp2 delivers OnInvalidFrame(). | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, _, _)).Times(5); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, DATA, 1)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(1, 1)); | |
| EXPECT_CALL(visitor, OnDataForStream(1, "h")); | |
| // Stream 3: content-length is smaller than actual data | |
| // The beginning of data is delivered to the visitor, but not the actual data. | |
| // Again, neither oghttp2 nor nghttp2 delivers OnInvalidFrame(). | |
| EXPECT_CALL(visitor, OnFrameHeader(3, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(3)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, _, _)).Times(5); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(3)); | |
| EXPECT_CALL(visitor, OnFrameHeader(3, _, DATA, 1)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(3, 5)); | |
| // Stream 5: content-length is invalid and HEADERS ends the stream | |
| // Only oghttp2 invokes OnEndHeadersForStream(). Both invoke | |
| // OnInvalidFrame(). | |
| EXPECT_CALL(visitor, OnFrameHeader(5, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(5)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(5, _, _)).Times(5); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(5)); | |
| EXPECT_CALL(visitor, | |
| OnInvalidFrame( | |
| 5, Http2VisitorInterface::InvalidFrameError::kHttpMessaging)); | |
| // Stream 7: content-length is invalid and trailers end the stream | |
| // Only oghttp2 invokes OnEndHeadersForStream(). Both invoke | |
| // OnInvalidFrame(). | |
| EXPECT_CALL(visitor, OnFrameHeader(7, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(7)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(7, _, _)).Times(5); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(7)); | |
| EXPECT_CALL(visitor, OnFrameHeader(7, _, DATA, 0)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(7, 1)); | |
| EXPECT_CALL(visitor, OnDataForStream(7, "h")); | |
| EXPECT_CALL(visitor, OnFrameHeader(7, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(7)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(7, _, _)); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(7)); | |
| EXPECT_CALL(visitor, | |
| OnInvalidFrame( | |
| 7, Http2VisitorInterface::InvalidFrameError::kHttpMessaging)); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(stream_frames.size(), static_cast<size_t>(stream_result)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 1, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 1, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 3, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 3, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(3, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 5, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 5, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(5, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 7, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 7, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(7, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT( | |
| visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS, | |
| SpdyFrameType::RST_STREAM, SpdyFrameType::RST_STREAM, | |
| SpdyFrameType::RST_STREAM, SpdyFrameType::RST_STREAM})); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerHandlesContentLengthMismatchWithDataPending) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}, | |
| {"content-length", "4"}}) | |
| .Data(1, "ok", /*fin=*/false) | |
| .Headers(3, {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/three"}, | |
| {"content-length", "4"}}) | |
| .Data(3, "ok", /*fin=*/false) | |
| .Serialize(); | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| // Headers and the beginning of data is delivered to the visitor. | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, _, _)).Times(5); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, 2, DATA, 0)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(1, 2)); | |
| EXPECT_CALL(visitor, OnDataForStream(1, _)); | |
| // Stream 3 | |
| // Headers and the beginning of data is delivered to the visitor. | |
| EXPECT_CALL(visitor, OnFrameHeader(3, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(3)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, _, _)).Times(5); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(3)); | |
| EXPECT_CALL(visitor, OnFrameHeader(3, 2, DATA, 0)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(3, 2)); | |
| EXPECT_CALL(visitor, OnDataForStream(3, _)); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(stream_frames.size(), static_cast<size_t>(stream_result)); | |
| // Initial response data for stream 1. | |
| visitor.AppendPayloadForStream( | |
| 1, "Here is some response data, and there will be more. "); | |
| adapter->SubmitResponse(1, ToHeaders({{":status", "200"}}), false); | |
| // Initial response data for stream 3. | |
| visitor.AppendPayloadForStream( | |
| 3, "Here is some response data, and there will be more. "); | |
| adapter->SubmitResponse(3, ToHeaders({{":status", "200"}}), false); | |
| // Server preface (SETTINGS) | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| // SETTINGS ack | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| // Stream 1 HEADERS | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, 1, _, 0x4)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, 1, _, 0x4, 0)); | |
| // Stream 3 HEADERS | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, 3, _, 0x4)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, 3, _, 0x4, 0)); | |
| // DATA | |
| EXPECT_CALL(visitor, OnFrameSent(DATA, 1, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnFrameSent(DATA, 3, _, 0x0, 0)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS, | |
| SpdyFrameType::HEADERS, SpdyFrameType::HEADERS, | |
| SpdyFrameType::DATA, SpdyFrameType::DATA})); | |
| visitor.Clear(); | |
| // Final response data and fin for stream 1. | |
| visitor.AppendPayloadForStream(1, "Last data!"); | |
| visitor.SetEndData(1, true); | |
| adapter->ResumeStream(1); | |
| // Final response data and fin for stream 3. | |
| visitor.AppendPayloadForStream(3, "Last data!"); | |
| visitor.SetEndData(3, true); | |
| adapter->ResumeStream(3); | |
| // Stream 1: actual data overshoots the content-length from request headers. | |
| // Stream 3: actual data undershoots the content-length from request headers. | |
| const std::string client_fin = TestFrameSequence() | |
| .Data(1, "ay!", /*fin=*/true) | |
| .Data(3, "", /*fin=*/true) | |
| .Serialize(); | |
| // The library does not deliver the actual data or fin from the client to the | |
| // visitor. | |
| EXPECT_CALL(visitor, OnFrameHeader(1, 3, DATA, 0x1)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(1, 3)); | |
| // The library does not deliver the actual data or fin from the client to the | |
| // visitor. | |
| EXPECT_CALL(visitor, OnFrameHeader(3, 0, DATA, 0x1)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(3, 0)); | |
| const int64_t fin_result = adapter->ProcessBytes(client_fin); | |
| ASSERT_EQ(client_fin.size(), fin_result); | |
| // The library sends the RST_STREAM but not the end of data. | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 1, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 1, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| // The library sends the RST_STREAM but not the end of data. | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 3, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 3, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(3, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerHandlesAsteriskPathForOptions) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::string stream_frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "*"}, | |
| {":method", "OPTIONS"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, _, _)).Times(4); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnEndStream(1)); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(stream_frames.size(), static_cast<size_t>(stream_result)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS})); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerHandlesInvalidPath) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "*"}, | |
| {":method", "GET"}}, | |
| /*fin=*/true) | |
| .Headers(3, | |
| {{":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "other/non/slash/starter"}, | |
| {":method", "GET"}}, | |
| /*fin=*/true) | |
| .Headers(5, | |
| {{":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", ""}, | |
| {":method", "GET"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, _, _)).Times(4); | |
| EXPECT_CALL(visitor, | |
| OnInvalidFrame( | |
| 1, Http2VisitorInterface::InvalidFrameError::kHttpMessaging)); | |
| EXPECT_CALL(visitor, OnFrameHeader(3, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(3)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, _, _)).Times(4); | |
| EXPECT_CALL(visitor, | |
| OnInvalidFrame( | |
| 3, Http2VisitorInterface::InvalidFrameError::kHttpMessaging)); | |
| EXPECT_CALL(visitor, OnFrameHeader(5, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(5)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(5, _, _)).Times(2); | |
| EXPECT_CALL( | |
| visitor, | |
| OnInvalidFrame(5, Http2VisitorInterface::InvalidFrameError::kHttpHeader)); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(stream_frames.size(), static_cast<size_t>(stream_result)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 1, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 1, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 3, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 3, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(3, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 5, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 5, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(5, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT( | |
| visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS, | |
| SpdyFrameType::RST_STREAM, SpdyFrameType::RST_STREAM, | |
| SpdyFrameType::RST_STREAM})); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerHandlesTeHeader) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::string stream_frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/"}, | |
| {":method", "GET"}, | |
| {"te", "trailers"}}, | |
| /*fin=*/true) | |
| .Headers(3, | |
| {{":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/"}, | |
| {":method", "GET"}, | |
| {"te", "trailers, deflate"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1: TE: trailers should be allowed. | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, _, _)).Times(5); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnEndStream(1)); | |
| // Stream 3: TE: <non-trailers> should be rejected. | |
| EXPECT_CALL(visitor, OnFrameHeader(3, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(3)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, _, _)).Times(4); | |
| EXPECT_CALL( | |
| visitor, | |
| OnInvalidFrame(3, Http2VisitorInterface::InvalidFrameError::kHttpHeader)); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(stream_frames.size(), static_cast<size_t>(stream_result)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 3, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 3, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(3, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS, | |
| SpdyFrameType::RST_STREAM})); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerHandlesConnectionSpecificHeaders) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| testing::InSequence s; | |
| const std::string stream_frames = | |
| TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/"}, | |
| {":method", "GET"}, | |
| {"connection", "keep-alive"}}, | |
| /*fin=*/true) | |
| .Headers(3, | |
| {{":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/"}, | |
| {":method", "GET"}, | |
| {"proxy-connection", "keep-alive"}}, | |
| /*fin=*/true) | |
| .Headers(5, | |
| {{":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/"}, | |
| {":method", "GET"}, | |
| {"keep-alive", "timeout=42"}}, | |
| /*fin=*/true) | |
| .Headers(7, | |
| {{":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/"}, | |
| {":method", "GET"}, | |
| {"transfer-encoding", "chunked"}}, | |
| /*fin=*/true) | |
| .Headers(9, | |
| {{":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/"}, | |
| {":method", "GET"}, | |
| {"upgrade", "h2c"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // All streams contain a connection-specific header and should be rejected. | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, _, _)).Times(4); | |
| EXPECT_CALL( | |
| visitor, | |
| OnInvalidFrame(1, Http2VisitorInterface::InvalidFrameError::kHttpHeader)); | |
| EXPECT_CALL(visitor, OnFrameHeader(3, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(3)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, _, _)).Times(4); | |
| EXPECT_CALL( | |
| visitor, | |
| OnInvalidFrame(3, Http2VisitorInterface::InvalidFrameError::kHttpHeader)); | |
| EXPECT_CALL(visitor, OnFrameHeader(5, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(5)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(5, _, _)).Times(4); | |
| EXPECT_CALL( | |
| visitor, | |
| OnInvalidFrame(5, Http2VisitorInterface::InvalidFrameError::kHttpHeader)); | |
| EXPECT_CALL(visitor, OnFrameHeader(7, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(7)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(7, _, _)).Times(4); | |
| EXPECT_CALL( | |
| visitor, | |
| OnInvalidFrame(7, Http2VisitorInterface::InvalidFrameError::kHttpHeader)); | |
| EXPECT_CALL(visitor, OnFrameHeader(9, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(9)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(9, _, _)).Times(4); | |
| EXPECT_CALL( | |
| visitor, | |
| OnInvalidFrame(9, Http2VisitorInterface::InvalidFrameError::kHttpHeader)); | |
| const int64_t stream_result = adapter->ProcessBytes(stream_frames); | |
| EXPECT_EQ(stream_frames.size(), static_cast<size_t>(stream_result)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 1, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 1, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 3, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 3, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(3, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 5, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 5, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(5, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 7, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 7, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(7, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(RST_STREAM, 9, _, 0x0)); | |
| EXPECT_CALL(visitor, | |
| OnFrameSent(RST_STREAM, 9, _, 0x0, | |
| static_cast<int>(Http2ErrorCode::PROTOCOL_ERROR))); | |
| EXPECT_CALL(visitor, OnCloseStream(9, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| EXPECT_TRUE(adapter->want_write()); | |
| int result = adapter->Send(); | |
| EXPECT_EQ(0, result); | |
| EXPECT_THAT( | |
| visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS, | |
| SpdyFrameType::RST_STREAM, SpdyFrameType::RST_STREAM, | |
| SpdyFrameType::RST_STREAM, SpdyFrameType::RST_STREAM, | |
| SpdyFrameType::RST_STREAM})); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerUsesCustomWindowUpdateStrategy) { | |
| // Test the use of a custom WINDOW_UPDATE strategy. | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.should_window_update_fn = [](int64_t /*limit*/, int64_t /*size*/, | |
| int64_t /*delta*/) { return true; }; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}, | |
| /*fin=*/false) | |
| .Data(1, "This is the request body.", | |
| /*fin=*/true) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, _, _)).Times(4); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, DATA, END_STREAM_FLAG)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(1, _)); | |
| EXPECT_CALL(visitor, OnDataForStream(1, "This is the request body.")); | |
| EXPECT_CALL(visitor, OnEndStream(1)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(static_cast<int64_t>(frames.size()), result); | |
| // Mark a small number of bytes for the stream as consumed. Because of the | |
| // custom WINDOW_UPDATE strategy, the session should send WINDOW_UPDATEs. | |
| adapter->MarkDataConsumedForStream(1, 5); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(WINDOW_UPDATE, 1, 4, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(WINDOW_UPDATE, 1, 4, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(WINDOW_UPDATE, 0, 4, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(WINDOW_UPDATE, 0, 4, 0x0, 0)); | |
| int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS, | |
| SpdyFrameType::WINDOW_UPDATE, | |
| SpdyFrameType::WINDOW_UPDATE})); | |
| } | |
| TEST(OgHttp2AdapterTest, ServerConsumesDataWithPadding) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| TestFrameSequence seq = std::move(TestFrameSequence().ClientPreface().Headers( | |
| 1, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}, | |
| /*fin=*/false)); | |
| // Generates a bunch of DATA frames, with the bulk of the payloads consisting | |
| // of padding. | |
| size_t total_size = 0; | |
| while (total_size < 62 * 1024) { | |
| seq.Data(1, "a", /*fin=*/false, /*padding=*/254); | |
| total_size += 255; | |
| } | |
| const std::string frames = seq.Serialize(); | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, _, _)).Times(4); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, DATA, 0x8)) | |
| .Times(testing::AtLeast(1)); | |
| EXPECT_CALL(visitor, OnBeginDataForStream(1, _)).Times(testing::AtLeast(1)); | |
| EXPECT_CALL(visitor, OnDataForStream(1, "a")).Times(testing::AtLeast(1)); | |
| EXPECT_CALL(visitor, OnDataPaddingLength(1, _)).Times(testing::AtLeast(1)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(result, frames.size()); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| // Since most of the flow control window consumed is padding, the adapter | |
| // generates window updates. | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(WINDOW_UPDATE, 1, _, 0x0)).Times(1); | |
| EXPECT_CALL(visitor, OnFrameSent(WINDOW_UPDATE, 1, _, 0x0, 0)).Times(1); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(WINDOW_UPDATE, 0, _, 0x0)).Times(1); | |
| EXPECT_CALL(visitor, OnFrameSent(WINDOW_UPDATE, 0, _, 0x0, 0)).Times(1); | |
| const int send_result = adapter->Send(); | |
| EXPECT_EQ(0, send_result); | |
| EXPECT_THAT(visitor.data(), | |
| EqualsFrames({SpdyFrameType::SETTINGS, SpdyFrameType::SETTINGS, | |
| SpdyFrameType::WINDOW_UPDATE, | |
| SpdyFrameType::WINDOW_UPDATE})); | |
| } | |
| // Verifies that NoopHeaderValidator allows several header combinations that | |
| // would otherwise be invalid. | |
| TEST(OgHttp2AdapterTest, NoopHeaderValidatorTest) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| options.validate_http_headers = false; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = TestFrameSequence() | |
| .ClientPreface() | |
| .Headers(1, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/1"}, | |
| {"content-length", "7"}, | |
| {"content-length", "7"}}, | |
| /*fin=*/false) | |
| .Headers(3, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/3"}, | |
| {"content-length", "11"}, | |
| {"content-length", "13"}}, | |
| /*fin=*/false) | |
| .Headers(5, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":authority", "foo.com"}, | |
| {":path", "/"}, | |
| {"host", "bar.com"}}, | |
| /*fin=*/true) | |
| .Headers(7, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/"}, | |
| {"Accept", "uppercase, oh boy!"}}, | |
| /*fin=*/false) | |
| .Headers(9, | |
| {{":method", "POST"}, | |
| {":scheme", "https"}, | |
| {":authority", "ex|ample.com"}, | |
| {":path", "/"}}, | |
| /*fin=*/false) | |
| .Headers(11, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/"}, | |
| {"content-length", "nan"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 0, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| EXPECT_CALL(visitor, OnFrameHeader(1, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":method", "POST")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":scheme", "https")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":authority", "example.com")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, ":path", "/1")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, "content-length", "7")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, "content-length", "7")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| // Stream 3 | |
| EXPECT_CALL(visitor, OnFrameHeader(3, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(3)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, ":method", "POST")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, ":scheme", "https")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, ":authority", "example.com")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, ":path", "/3")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, "content-length", "11")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(3, "content-length", "13")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(3)); | |
| // Stream 5 | |
| EXPECT_CALL(visitor, OnFrameHeader(5, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(5)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(5, ":method", "POST")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(5, ":scheme", "https")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(5, ":authority", "foo.com")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(5, ":path", "/")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(5, "host", "bar.com")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(5)); | |
| EXPECT_CALL(visitor, OnEndStream(5)); | |
| // Stream 7 | |
| EXPECT_CALL(visitor, OnFrameHeader(7, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(7)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(7, ":method", "POST")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(7, ":scheme", "https")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(7, ":authority", "example.com")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(7, ":path", "/")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(7, "Accept", "uppercase, oh boy!")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(7)); | |
| // Stream 9 | |
| EXPECT_CALL(visitor, OnFrameHeader(9, _, HEADERS, 4)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(9)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(9, ":method", "POST")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(9, ":scheme", "https")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(9, ":authority", "ex|ample.com")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(9, ":path", "/")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(9)); | |
| // Stream 11 | |
| EXPECT_CALL(visitor, OnFrameHeader(11, _, HEADERS, 5)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(11)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(11, ":method", "GET")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(11, ":scheme", "https")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(11, ":authority", "example.com")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(11, ":path", "/")); | |
| EXPECT_CALL(visitor, OnHeaderForStream(11, "content-length", "nan")); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(11)); | |
| EXPECT_CALL(visitor, OnEndStream(11)); | |
| const int64_t result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(frames.size(), static_cast<size_t>(result)); | |
| } | |
| TEST(OgHttp2AdapterTest, NegativeFlowControlStreamResumption) { | |
| TestVisitor visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kServer; | |
| auto adapter = OgHttp2Adapter::Create(visitor, options); | |
| const std::string frames = | |
| TestFrameSequence() | |
| .ClientPreface({{INITIAL_WINDOW_SIZE, 128u * 1024u}}) | |
| .WindowUpdate(0, 1 << 20) | |
| .Headers(1, | |
| {{":method", "GET"}, | |
| {":scheme", "https"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}, | |
| /*fin=*/true) | |
| .Serialize(); | |
| testing::InSequence s; | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 6, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, | |
| OnSetting(Http2Setting{Http2KnownSettingsId::INITIAL_WINDOW_SIZE, | |
| 128u * 1024u})); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 4, WINDOW_UPDATE, 0)); | |
| EXPECT_CALL(visitor, OnWindowUpdate(0, 1 << 20)); | |
| // Stream 1 | |
| EXPECT_CALL(visitor, | |
| OnFrameHeader(1, _, HEADERS, END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnBeginHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnHeaderForStream(1, _, _)).Times(4); | |
| EXPECT_CALL(visitor, OnEndHeadersForStream(1)); | |
| EXPECT_CALL(visitor, OnEndStream(1)); | |
| const int64_t read_result = adapter->ProcessBytes(frames); | |
| EXPECT_EQ(static_cast<size_t>(read_result), frames.size()); | |
| // Submit a response for the stream. | |
| visitor.AppendPayloadForStream(1, std::string(70000, 'a')); | |
| int submit_result = | |
| adapter->SubmitResponse(1, ToHeaders({{":status", "200"}}), false); | |
| ASSERT_EQ(0, submit_result); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(HEADERS, 1, _, END_HEADERS_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(HEADERS, 1, _, END_HEADERS_FLAG, 0)); | |
| EXPECT_CALL(visitor, OnFrameSent(DATA, 1, _, 0x0, 0)).Times(5); | |
| adapter->Send(); | |
| EXPECT_FALSE(adapter->want_write()); | |
| EXPECT_CALL(visitor, OnFrameHeader(0, 6, SETTINGS, 0)); | |
| EXPECT_CALL(visitor, OnSettingsStart()); | |
| EXPECT_CALL(visitor, | |
| OnSetting(Http2Setting{Http2KnownSettingsId::INITIAL_WINDOW_SIZE, | |
| 64u * 1024u})); | |
| EXPECT_CALL(visitor, OnSettingsEnd()); | |
| // Processing these SETTINGS will cause stream 1's send window to become | |
| // negative. | |
| adapter->ProcessBytes(TestFrameSequence() | |
| .Settings({{INITIAL_WINDOW_SIZE, 64u * 1024u}}) | |
| .Serialize()); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_LT(adapter->GetStreamSendWindowSize(1), 0); | |
| visitor.AppendPayloadForStream(1, "Stream should be resumed."); | |
| adapter->ResumeStream(1); | |
| EXPECT_CALL(visitor, OnBeforeFrameSent(SETTINGS, 0, _, ACK_FLAG)); | |
| EXPECT_CALL(visitor, OnFrameSent(SETTINGS, 0, _, ACK_FLAG, 0)); | |
| adapter->Send(); | |
| EXPECT_FALSE(adapter->want_write()); | |
| // Upon receiving the WINDOW_UPDATE, stream 1 should be ready to write. | |
| EXPECT_CALL(visitor, OnFrameHeader(1, 4, WINDOW_UPDATE, 0)); | |
| EXPECT_CALL(visitor, OnWindowUpdate(1, 10000)); | |
| adapter->ProcessBytes(TestFrameSequence().WindowUpdate(1, 10000).Serialize()); | |
| EXPECT_TRUE(adapter->want_write()); | |
| EXPECT_GT(adapter->GetStreamSendWindowSize(1), 0); | |
| EXPECT_CALL(visitor, OnFrameSent(DATA, 1, _, 0x0, 0)); | |
| adapter->Send(); | |
| } | |
| // Verifies that Set-Cookie headers are not folded in either the sending or | |
| // receiving direction. | |
| TEST(OgHttp2AdapterTest, SetCookieRoundtrip) { | |
| TestVisitor client_visitor; | |
| OgHttp2Adapter::Options options; | |
| options.perspective = Perspective::kClient; | |
| auto client_adapter = OgHttp2Adapter::Create(client_visitor, options); | |
| TestVisitor server_visitor; | |
| options.perspective = Perspective::kServer; | |
| auto server_adapter = OgHttp2Adapter::Create(server_visitor, options); | |
| // Set-Cookie is a response headers. For the server to respond, the client | |
| // needs to send a request to open the stream. | |
| const std::vector<Header> request_headers = | |
| ToHeaders({{":method", "GET"}, | |
| {":scheme", "http"}, | |
| {":authority", "example.com"}, | |
| {":path", "/this/is/request/one"}}); | |
| const int32_t stream_id1 = | |
| client_adapter->SubmitRequest(request_headers, true, nullptr); | |
| ASSERT_GT(stream_id1, 0); | |
| // Client visitor expectations on send. | |
| // Client preface with SETTINGS. | |
| EXPECT_CALL(client_visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(client_visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| // The client request. | |
| EXPECT_CALL(client_visitor, | |
| OnBeforeFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(client_visitor, | |
| OnFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| EXPECT_EQ(0, client_adapter->Send()); | |
| // Server visitor expectations on receive. | |
| // Client preface (empty SETTINGS) | |
| EXPECT_CALL(server_visitor, OnFrameHeader(0, 6, SETTINGS, 0)); | |
| EXPECT_CALL(server_visitor, OnSettingsStart()); | |
| EXPECT_CALL(server_visitor, | |
| OnSetting(Http2Setting{Http2KnownSettingsId::ENABLE_PUSH, 0u})); | |
| EXPECT_CALL(server_visitor, OnSettingsEnd()); | |
| // Stream 1 | |
| EXPECT_CALL(server_visitor, OnFrameHeader(stream_id1, _, HEADERS, 5)); | |
| EXPECT_CALL(server_visitor, OnBeginHeadersForStream(stream_id1)); | |
| EXPECT_CALL(server_visitor, OnHeaderForStream).Times(4); | |
| EXPECT_CALL(server_visitor, OnEndHeadersForStream(stream_id1)); | |
| EXPECT_CALL(server_visitor, OnEndStream(stream_id1)); | |
| // The server adapter processes the client's output. | |
| ASSERT_EQ(client_visitor.data().size(), | |
| server_adapter->ProcessBytes(client_visitor.data())); | |
| // Response headers contain two individual Set-Cookie fields. | |
| const std::vector<Header> response_headers = | |
| ToHeaders({{":status", "200"}, | |
| {"set-cookie", "chocolate_chip=yummy"}, | |
| {"set-cookie", "macadamia_nut=okay"}}); | |
| EXPECT_EQ(0, | |
| server_adapter->SubmitResponse(stream_id1, response_headers, true)); | |
| // Server visitor expectations on send. | |
| // Server preface with initial SETTINGS. | |
| EXPECT_CALL(server_visitor, OnBeforeFrameSent(SETTINGS, 0, _, 0x0)); | |
| EXPECT_CALL(server_visitor, OnFrameSent(SETTINGS, 0, _, 0x0, 0)); | |
| // SETTINGS ack | |
| EXPECT_CALL(server_visitor, OnBeforeFrameSent(SETTINGS, 0, 0, ACK_FLAG)); | |
| EXPECT_CALL(server_visitor, OnFrameSent(SETTINGS, 0, 0, ACK_FLAG, 0)); | |
| // Stream 1 response. | |
| EXPECT_CALL(server_visitor, | |
| OnBeforeFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG)); | |
| EXPECT_CALL(server_visitor, | |
| OnFrameSent(HEADERS, stream_id1, _, | |
| END_STREAM_FLAG | END_HEADERS_FLAG, 0)); | |
| // Stream 1 is complete. | |
| EXPECT_CALL(server_visitor, | |
| OnCloseStream(stream_id1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| EXPECT_EQ(0, server_adapter->Send()); | |
| // Client visitor expectations on receive. | |
| // Server preface with initial SETTINGS. | |
| EXPECT_CALL(client_visitor, OnFrameHeader(0, 6, SETTINGS, 0)); | |
| EXPECT_CALL(client_visitor, OnSettingsStart()); | |
| EXPECT_CALL(client_visitor, | |
| OnSetting(Http2Setting{ | |
| Http2KnownSettingsId::ENABLE_CONNECT_PROTOCOL, 1u})); | |
| EXPECT_CALL(client_visitor, OnSettingsEnd()); | |
| // SETTINGS ack. | |
| EXPECT_CALL(client_visitor, OnFrameHeader(0, 0, SETTINGS, ACK_FLAG)); | |
| EXPECT_CALL(client_visitor, OnSettingsAck()); | |
| // Stream 1 response. | |
| EXPECT_CALL(client_visitor, OnFrameHeader(stream_id1, _, HEADERS, 5)); | |
| EXPECT_CALL(client_visitor, OnBeginHeadersForStream(stream_id1)); | |
| EXPECT_CALL(client_visitor, OnHeaderForStream(stream_id1, ":status", "200")); | |
| // Note that the Set-Cookie headers are delivered individually. | |
| EXPECT_CALL(client_visitor, OnHeaderForStream(stream_id1, "set-cookie", | |
| "chocolate_chip=yummy")); | |
| EXPECT_CALL(client_visitor, OnHeaderForStream(stream_id1, "set-cookie", | |
| "macadamia_nut=okay")); | |
| EXPECT_CALL(client_visitor, OnEndHeadersForStream(stream_id1)); | |
| EXPECT_CALL(client_visitor, OnEndStream(stream_id1)); | |
| EXPECT_CALL(client_visitor, | |
| OnCloseStream(stream_id1, Http2ErrorCode::HTTP2_NO_ERROR)); | |
| // The client adapter processes the server's output. | |
| ASSERT_EQ(server_visitor.data().size(), | |
| client_adapter->ProcessBytes(server_visitor.data())); | |
| } | |
| } // namespace | |
| } // namespace test | |
| } // namespace adapter | |
| } // namespace http2 |