Deprecate gfe2_reloadable_flag_quic_use_fast_huffman_encoder. PiperOrigin-RevId: 344845112 Change-Id: I59cf623badd1cee60f32251962cca123d9aac0d5
diff --git a/quic/core/qpack/qpack_instruction_encoder.cc b/quic/core/qpack/qpack_instruction_encoder.cc index c796654..d114ece 100644 --- a/quic/core/qpack/qpack_instruction_encoder.cc +++ b/quic/core/qpack/qpack_instruction_encoder.cc
@@ -20,13 +20,7 @@ string_length_(0), byte_(0), state_(State::kOpcode), - instruction_(nullptr), - use_fast_huffman_encoder_( - GetQuicReloadableFlag(quic_use_fast_huffman_encoder)) { - if (use_fast_huffman_encoder_) { - QUIC_RELOADABLE_FLAG_COUNT(quic_use_fast_huffman_encoder); - } -} + instruction_(nullptr) {} void QpackInstructionEncoder::Encode( const QpackInstructionWithValues& instruction_with_values, @@ -171,11 +165,7 @@ absl::string_view string_to_write = (field_->type == QpackInstructionFieldType::kName) ? name : value; if (use_huffman_) { - if (use_fast_huffman_encoder_) { - http2::HuffmanEncodeFast(string_to_write, string_length_, output); - } else { - http2::HuffmanEncode(string_to_write, string_length_, output); - } + http2::HuffmanEncodeFast(string_to_write, string_length_, output); } else { QuicStrAppend(output, string_to_write); }
diff --git a/quic/core/qpack/qpack_instruction_encoder.h b/quic/core/qpack/qpack_instruction_encoder.h index 4f6fac7..f2e2f4e 100644 --- a/quic/core/qpack/qpack_instruction_encoder.h +++ b/quic/core/qpack/qpack_instruction_encoder.h
@@ -77,9 +77,6 @@ // Field currently being decoded. QpackInstructionFields::const_iterator field_; - - // Latched value of gfe2_reloadable_flag_quic_use_fast_huffman_encoder. - const bool use_fast_huffman_encoder_; }; } // namespace quic
diff --git a/quic/core/quic_flags_list.h b/quic/core/quic_flags_list.h index 01062fd..0792052 100644 --- a/quic/core/quic_flags_list.h +++ b/quic/core/quic_flags_list.h
@@ -71,7 +71,6 @@ QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_unified_iw_options, false) QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_use_circular_deque_for_unacked_packets_v2, false) QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_use_encryption_level_context, false) -QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_use_fast_huffman_encoder, true) QUIC_FLAG(FLAGS_quic_reloadable_flag_quic_use_write_or_buffer_data_at_level, false) QUIC_FLAG(FLAGS_quic_reloadable_flag_send_quic_fallback_server_config_on_leto_error, false) QUIC_FLAG(FLAGS_quic_restart_flag_dont_fetch_quic_private_keys_from_leto, false)