commit ff4b2b68ca5022d7c06c268d25d0898be8e376b8
author renjietang <renjietang@google.com> Wed Feb 12 16:52:32 2020 -0800
committer Copybara-Service <copybara-worker@google.com> Wed Feb 12 16:53:45 2020 -0800
tree 6290fb575847600b5e43df99e9f450f51c562fb5
parent bd33b6225d88b1fb1323bd29154e4a53d7def258

Rename QuicStreamIdManager delegate's OnError() to OnStreamIdManagerError() to differentiate itself from errors generated from other QuicSession components.

gfe-relnote: no behavior change. Not protected.
PiperOrigin-RevId: 294791089
Change-Id: Id93ce2979a767bf4b4696dea8d61e256815c2562

quic/core/quic_stream_id_manager.cc

diff --git a/quic/core/quic_stream_id_manager.cc b/quic/core/quic_stream_id_manager.cc
index f49b188..8f1b413 100644
--- a/quic/core/quic_stream_id_manager.cc
+++ b/quic/core/quic_stream_id_manager.cc
@@ -72,8 +72,8 @@
     // Peer thinks it can send more streams that we've told it.
     // This is a protocol error.
     QUIC_CODE_COUNT(quic_streams_blocked_too_big);
-    delegate_->OnError(QUIC_STREAMS_BLOCKED_ERROR,
-                       "Invalid stream count specified");
+    delegate_->OnStreamIdManagerError(QUIC_STREAMS_BLOCKED_ERROR,
+                                      "Invalid stream count specified");
     return false;
   }
   if (frame.stream_count < incoming_actual_max_streams_) {
@@ -116,8 +116,8 @@
       QuicUtils::GetMaxStreamCount(unidirectional_, perspective());
   QuicStreamCount new_max = std::min(implementation_max, max_open_streams);
   if (new_max < incoming_stream_count_) {
-    delegate_->OnError(QUIC_MAX_STREAMS_ERROR,
-                       "Stream limit less than existing stream count");
+    delegate_->OnStreamIdManagerError(
+        QUIC_MAX_STREAMS_ERROR, "Stream limit less than existing stream count");
     return;
   }
   incoming_actual_max_streams_ = new_max;
@@ -244,10 +244,11 @@
                     << "Failed to create a new incoming stream with id:"
                     << stream_id << ", reaching MAX_STREAMS limit: "
                     << incoming_advertised_max_streams_ << ".";
-    delegate_->OnError(QUIC_INVALID_STREAM_ID,
-                       quiche::QuicheStrCat("Stream id ", stream_id,
-                                            " would exceed stream count limit ",
-                                            incoming_advertised_max_streams_));
+    delegate_->OnStreamIdManagerError(
+        QUIC_INVALID_STREAM_ID,
+        quiche::QuicheStrCat("Stream id ", stream_id,
+                             " would exceed stream count limit ",
+                             incoming_advertised_max_streams_));
     return false;
   }