commit ff4240d00f3efda299ed34c997db1d1abfb8f44c
author renjietang <renjietang@google.com> Wed Jul 01 06:19:55 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Wed Jul 01 06:20:30 2020 -0700
tree 10c981c0bb2dcd09bfdde42418b340a25f4e7f10
parent ed1fe4f83c350bfccf42e612c1111956847721fb

Make QuicSession::ResetStream() smarter.

If the stream reseted doesn't exist, we always send out 0 as the bytes written. And if it doesn, we always send what the stream has written. So we don't need the explicit parameter for bytes_written.

No behavior change. not protected.

PiperOrigin-RevId: 319211675
Change-Id: I6c96d94e2d0ec1eca0c86a4740a7384aa15c8529

quic/core/quic_session.cc

diff --git a/quic/core/quic_session.cc b/quic/core/quic_session.cc
index 9f4de44..97490d6 100644
--- a/quic/core/quic_session.cc
+++ b/quic/core/quic_session.cc
@@ -763,9 +763,7 @@
   }
 }
 
-void QuicSession::ResetStream(QuicStreamId id,
-                              QuicRstStreamErrorCode error,
-                              QuicStreamOffset bytes_written) {
+void QuicSession::ResetStream(QuicStreamId id, QuicRstStreamErrorCode error) {
   QuicStream* stream = GetStream(id);
   if (stream != nullptr && stream->is_static()) {
     connection()->CloseConnection(
@@ -779,7 +777,7 @@
     return;
   }
 
-  SendRstStream(id, error, bytes_written);
+  SendRstStream(id, error, 0);
 }
 
 void QuicSession::MaybeSendRstStreamFrame(QuicStreamId id,
@@ -1795,7 +1793,7 @@
   if (!VersionHasIetfQuicFrames(transport_version()) &&
       !stream_id_manager_.CanOpenIncomingStream()) {
     // Refuse to open the stream.
-    ResetStream(stream_id, QUIC_REFUSED_STREAM, 0);
+    ResetStream(stream_id, QUIC_REFUSED_STREAM);
     return nullptr;
   }