commit fb6a170e739431dee8d7c5dfac832a7f1884736c
author QUICHE team <quiche-dev@google.com> Tue Sep 05 15:11:37 2023 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Sep 05 15:12:18 2023 -0700
tree d497a7355f5e0cabbe009b3a916258520474a62e
parent 60149be6ea57ae9542db1ceccbc6d054f990895e

Remove redundant call to OnDataFrameSent()

QuicSpdyStream::WriteOrBufferBody() calls WriteDataFrameHeader(), which already calls QuicHttp3Logger::OnDataFrameSent(), so WriteOrBufferBody() does not need to directly call it as well. This results in redundant HTTP3_DATA_SENT netlog events which is confusing.

See https://crbug.com/1478833 for context.

PiperOrigin-RevId: 562905348

quiche/quic/core/http/quic_spdy_stream.cc

diff --git a/quiche/quic/core/http/quic_spdy_stream.cc b/quiche/quic/core/http/quic_spdy_stream.cc
index 28b509a..4cc9ce4 100644
--- a/quiche/quic/core/http/quic_spdy_stream.cc
+++ b/quiche/quic/core/http/quic_spdy_stream.cc
@@ -305,10 +305,6 @@
   }
   QuicConnection::ScopedPacketFlusher flusher(spdy_session_->connection());
 
-  if (spdy_session_->debug_visitor()) {
-    spdy_session_->debug_visitor()->OnDataFrameSent(id(), data.length());
-  }
-
   const bool success =
       WriteDataFrameHeader(data.length(), /*force_write=*/true);
   QUICHE_DCHECK(success);