commit fa3ed396af8f077d1942a4a62bcddc1896c01722
author haoyuewang <haoyuewang@google.com> Wed Mar 17 11:24:28 2021 -0700
committer Copybara-Service <copybara-worker@google.com> Wed Mar 17 11:25:22 2021 -0700
tree 9fb0ae5b1893af741f52739ae97e2c9c1f6ae235
parent 877a4197a904f6e8652ad062b0d7bfada2c4962e

Fix quic_connection_test under
--gfe2_flip_canary_feature_flags_to_true_for_test=true.

This failure is encountered in flipping flags for gfe canary.

PiperOrigin-RevId: 363464492
Change-Id: I74ff29fe539cf5b3ce5c4f382201c0614dcaf3a5

quic/core/quic_connection_test.cc

diff --git a/quic/core/quic_connection_test.cc b/quic/core/quic_connection_test.cc
index 21e1f57..6b34ece 100644
--- a/quic/core/quic_connection_test.cc
+++ b/quic/core/quic_connection_test.cc
@@ -2291,8 +2291,9 @@
                                      ENCRYPTION_FORWARD_SECURE);
     EXPECT_LT(2 * received->length(),
               QuicConnectionPeer::BytesReceivedOnAlternativePath(&connection_));
-    EXPECT_TRUE(QuicConnectionPeer::IsAlternativePathValidated(&connection_));
-
+    if (connection_.validate_client_address()) {
+      EXPECT_TRUE(QuicConnectionPeer::IsAlternativePathValidated(&connection_));
+    }
     // Receiving another probing packet from a newer address with a different
     // port shouldn't trigger another reverse path validation.
     QuicSocketAddress kNewerPeerAddress(QuicIpAddress::Loopback4(),