Allow visitor_.OnFrameSent() to propagate a fatal send error, and do not retry sending on fatal send errors.

This CL makes OgHttp2Session::AfterFrameSent() return a bool to reflect an
error value from visitor_.OnFrameSent(), which is treated as a fatal connection
error and propagated to OgHttp2Session::Send(). This propagation is helpful for
compatibility with nghttp2 and Envoy.

For reference, the only (practically considered) error code nghttp2 returns for
failed sends is a fatal error:

This CL also makes a change to not let OgHttp2Session::Send() send data when it
has previously returned an error value. This is not consistent with nghttp2,
but it feels right and does not negatively affect current codec_impl_tests.

With this CL, codec_impl_tests Sponge (ProtocolErrorForTest now passes):

PiperOrigin-RevId: 416424214
4 files changed
tree: 3d53484c2da90f764eeee4b53be01e21489cbed4
  1. common/
  2. epoll_server/
  3. http2/
  4. quic/
  5. spdy/


QUICHE stands for QUIC, Http/2, Etc. It is Google‘s production-ready implementation of QUIC, HTTP/2, HTTP/3, and related protocols and tools. It powers Google’s servers, Chromium, Envoy, and other projects. It is actively developed and maintained.

There are two public QUICHE repositories. Either one may be used by embedders, as they are automatically kept in sync:

To embed QUICHE in your project, platform APIs need to be implemented and build files need to be created. Note that it is on the QUICHE team's roadmap to include default implementation for all platform APIs and to open-source build files. In the meanwhile, take a look at open source embedders like Chromium and Envoy to get started:

To contribute to QUICHE, follow instructions at

QUICHE is only supported on little-endian platforms.