commit eb26841989d5c50e4da3c85f7701e39e5c6d62fe
author fayang <fayang@google.com> Mon Oct 21 14:05:38 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Mon Oct 21 14:06:09 2019 -0700
tree 50b2c4c0719ea14c39dfdee118ce77cadf19754d
parent 104f9c5d8a3d89a4241a470d87ccb6675a1483b6

gfe-relnote: In QUIC, populate the actual length of full padding frame in nonretransmittable_frames (of SerializedPacket). Protected by existing gfe2_reloadable_flag_quic_populate_nonretransmittable_frames.

PiperOrigin-RevId: 275918768
Change-Id: I8004cfcfe2c7b6ec750905505d7df453ea1c849c

quic/core/quic_packet_creator_test.cc

diff --git a/quic/core/quic_packet_creator_test.cc b/quic/core/quic_packet_creator_test.cc
index 2d0d5b3..4fe07ad 100644
--- a/quic/core/quic_packet_creator_test.cc
+++ b/quic/core/quic_packet_creator_test.cc
@@ -2437,6 +2437,11 @@
   ASSERT_EQ(2u, serialized.nonretransmittable_frames.size());
   EXPECT_EQ(ACK_FRAME, serialized.nonretransmittable_frames[0].type);
   EXPECT_EQ(PADDING_FRAME, serialized.nonretransmittable_frames[1].type);
+  // Verify full padding frame is translated to a padding frame with actual
+  // bytes of padding.
+  EXPECT_LT(
+      0,
+      serialized.nonretransmittable_frames[1].padding_frame.num_padding_bytes);
   frames_.clear();
 
   // Serialize another packet with the same frames.