| commit | 1820314b7860d1f73327cbd97cd0be3b35e4f618 | [log] [tgz] |
|---|---|---|
| author | bnc <bnc@google.com> | Fri Jun 11 12:09:24 2021 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Fri Jun 11 12:10:41 2021 -0700 |
| tree | 958f7aed60e163faa1bcec5a3ed229e7e64f194f | |
| parent | 75c7ea51042b3846ccd0276a686f5bad440ea906 [diff] |
Add QuicCryptoClientConfigTest.MultipleCanonicalEntries.
When working on cl/378863627 I originally wrote:
auto it = canonical_server_map_.lower_bound(suffix_server_id);
if (it == canonical_server_map_.end() || it->first < suffix_server_id) {
canonical_server_map_.insert(...);
return false;
}
This is incorrect: lower_bound() never returns an iterator with key less than
its argument. No tests caught this. The statement should have been
if (it == canonical_server_map_.end() || suffix_server_id < it->first) {
or simply
if (it == canonical_server_map_.end() || it->first != suffix_server_id) {
This CL adds a test that would have failed with the incorrect statement.
PiperOrigin-RevId: 378922152
QUICHE (QUIC, Http/2, Etc) is Google‘s implementation of QUIC and related protocols. It powers Chromium as well as Google’s QUIC servers and some other projects. QUICHE is only supported on little-endian platforms.
Code can be viewed in CodeSearch in Quiche and is imported into Chromium.