gfe-relnote: (n/a) Delete use_stateless_rejects_if_peer_supported from QuicCryptoServerStream's constructor. No behavior change, not protected.
PiperOrigin-RevId: 248448524
Change-Id: I0efeca57e329f91c62bb5633c39db961c78d71bb
diff --git a/quic/core/http/quic_server_session_base_test.cc b/quic/core/http/quic_server_session_base_test.cc
index b532601..9c78423 100644
--- a/quic/core/http/quic_server_session_base_test.cc
+++ b/quic/core/http/quic_server_session_base_test.cc
@@ -105,10 +105,8 @@
QuicCryptoServerStreamBase* CreateQuicCryptoServerStream(
const QuicCryptoServerConfig* crypto_config,
QuicCompressedCertsCache* compressed_certs_cache) override {
- return new QuicCryptoServerStream(
- crypto_config, compressed_certs_cache,
- GetQuicReloadableFlag(enable_quic_stateless_reject_support), this,
- stream_helper());
+ return new QuicCryptoServerStream(crypto_config, compressed_certs_cache,
+ this, stream_helper());
}
private:
@@ -463,12 +461,10 @@
QuicCompressedCertsCache* compressed_certs_cache,
QuicServerSessionBase* session,
QuicCryptoServerStream::Helper* helper)
- : QuicCryptoServerStream(
- crypto_config,
- compressed_certs_cache,
- GetQuicReloadableFlag(enable_quic_stateless_reject_support),
- session,
- helper) {}
+ : QuicCryptoServerStream(crypto_config,
+ compressed_certs_cache,
+ session,
+ helper) {}
MockQuicCryptoServerStream(const MockQuicCryptoServerStream&) = delete;
MockQuicCryptoServerStream& operator=(const MockQuicCryptoServerStream&) =
delete;
diff --git a/quic/core/quic_crypto_server_stream.cc b/quic/core/quic_crypto_server_stream.cc
index 8fc4cf3..e8937a0 100644
--- a/quic/core/quic_crypto_server_stream.cc
+++ b/quic/core/quic_crypto_server_stream.cc
@@ -49,7 +49,6 @@
QuicCryptoServerStream::QuicCryptoServerStream(
const QuicCryptoServerConfig* crypto_config,
QuicCompressedCertsCache* compressed_certs_cache,
- bool /*use_stateless_rejects_if_peer_supported*/,
QuicSession* session,
Helper* helper)
: QuicCryptoServerStreamBase(session),
diff --git a/quic/core/quic_crypto_server_stream.h b/quic/core/quic_crypto_server_stream.h
index 30c7ba2..9edd2ea 100644
--- a/quic/core/quic_crypto_server_stream.h
+++ b/quic/core/quic_crypto_server_stream.h
@@ -151,7 +151,6 @@
// |helper| must outlive the stream.
QuicCryptoServerStream(const QuicCryptoServerConfig* crypto_config,
QuicCompressedCertsCache* compressed_certs_cache,
- bool use_stateless_rejects_if_peer_supported,
QuicSession* session,
Helper* helper);
QuicCryptoServerStream(const QuicCryptoServerStream&) = delete;
diff --git a/quic/core/quic_dispatcher_test.cc b/quic/core/quic_dispatcher_test.cc
index 03b281b..46c5bc2 100644
--- a/quic/core/quic_dispatcher_test.cc
+++ b/quic/core/quic_dispatcher_test.cc
@@ -86,10 +86,8 @@
QuicCryptoServerStreamBase* CreateQuicCryptoServerStream(
const QuicCryptoServerConfig* crypto_config,
QuicCompressedCertsCache* compressed_certs_cache) override {
- return new QuicCryptoServerStream(
- crypto_config, compressed_certs_cache,
- GetQuicReloadableFlag(enable_quic_stateless_reject_support), this,
- stream_helper());
+ return new QuicCryptoServerStream(crypto_config, compressed_certs_cache,
+ this, stream_helper());
}
void SetCryptoStream(QuicCryptoServerStream* crypto_stream) {
@@ -1051,12 +1049,10 @@
QuicCompressedCertsCache* compressed_certs_cache,
QuicServerSessionBase* session,
QuicCryptoServerStream::Helper* helper)
- : QuicCryptoServerStream(
- &crypto_config,
- compressed_certs_cache,
- GetQuicReloadableFlag(enable_quic_stateless_reject_support),
- session,
- helper),
+ : QuicCryptoServerStream(&crypto_config,
+ compressed_certs_cache,
+ session,
+ helper),
handshake_confirmed_(false) {}
MockQuicCryptoServerStream(const MockQuicCryptoServerStream&) = delete;
MockQuicCryptoServerStream& operator=(const MockQuicCryptoServerStream&) =
diff --git a/quic/quartc/quartc_session.cc b/quic/quartc/quartc_session.cc
index a4c897d..9615689 100644
--- a/quic/quartc/quartc_session.cc
+++ b/quic/quartc/quartc_session.cc
@@ -408,8 +408,7 @@
void QuartcServerSession::StartCryptoHandshake() {
crypto_stream_ = QuicMakeUnique<QuicCryptoServerStream>(
- server_crypto_config_, compressed_certs_cache_,
- /*use_stateless_rejects_if_peer_supported=*/false, this, stream_helper_);
+ server_crypto_config_, compressed_certs_cache_, this, stream_helper_);
Initialize();
}
diff --git a/quic/test_tools/quic_test_utils.cc b/quic/test_tools/quic_test_utils.cc
index 00cd34a..506d323 100644
--- a/quic/test_tools/quic_test_utils.cc
+++ b/quic/test_tools/quic_test_utils.cc
@@ -638,10 +638,8 @@
TestQuicSpdyServerSession::CreateQuicCryptoServerStream(
const QuicCryptoServerConfig* crypto_config,
QuicCompressedCertsCache* compressed_certs_cache) {
- return new QuicCryptoServerStream(
- crypto_config, compressed_certs_cache,
- GetQuicReloadableFlag(enable_quic_stateless_reject_support), this,
- &helper_);
+ return new QuicCryptoServerStream(crypto_config, compressed_certs_cache, this,
+ &helper_);
}
void TestQuicSpdyServerSession::OnCryptoHandshakeEvent(
diff --git a/quic/tools/quic_simple_server_session.cc b/quic/tools/quic_simple_server_session.cc
index af60524..2b4cae7 100644
--- a/quic/tools/quic_simple_server_session.cc
+++ b/quic/tools/quic_simple_server_session.cc
@@ -45,10 +45,8 @@
QuicSimpleServerSession::CreateQuicCryptoServerStream(
const QuicCryptoServerConfig* crypto_config,
QuicCompressedCertsCache* compressed_certs_cache) {
- return new QuicCryptoServerStream(
- crypto_config, compressed_certs_cache,
- GetQuicReloadableFlag(enable_quic_stateless_reject_support), this,
- stream_helper());
+ return new QuicCryptoServerStream(crypto_config, compressed_certs_cache, this,
+ stream_helper());
}
void QuicSimpleServerSession::OnStreamFrame(const QuicStreamFrame& frame) {
diff --git a/quic/tools/quic_simple_server_session_test.cc b/quic/tools/quic_simple_server_session_test.cc
index 577ff26..7429732 100644
--- a/quic/tools/quic_simple_server_session_test.cc
+++ b/quic/tools/quic_simple_server_session_test.cc
@@ -84,8 +84,6 @@
: QuicCryptoServerStream(
crypto_config,
compressed_certs_cache,
- GetQuicReloadableFlag(
- enable_quic_stateless_reject_support), // NOLINT
session,
helper) {}
MockQuicCryptoServerStream(const MockQuicCryptoServerStream&) = delete;