commit d2e26cc674a5ae66a20a7c0e2bf12ed20fd1f4d1
author dschinazi <dschinazi@google.com> Tue Jun 18 18:35:33 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Jun 18 20:22:45 2019 -0700
tree aa029fc56b89ad7cf24e9115f83b4a48839591df
parent 6abd56b8602e73a011fbb294434c8d7de1bacdf7

Deprecate quic_print_tag_hex

gfe-relnote: deprecate --gfe2_reloadable_flag_quic_print_tag_hex
PiperOrigin-RevId: 253911635
Change-Id: Ic5bb02d318e6065d204df6be23b9c85f514b067d

quic/core/quic_tag.cc

diff --git a/quic/core/quic_tag.cc b/quic/core/quic_tag.cc
index 109803d..3b6ba0d 100644
--- a/quic/core/quic_tag.cc
+++ b/quic/core/quic_tag.cc
@@ -36,7 +36,7 @@
 }
 
 std::string QuicTagToString(QuicTag tag) {
-  if (GetQuicReloadableFlag(quic_print_tag_hex) && tag == 0) {
+  if (tag == 0) {
     return "0";
   }
   char chars[sizeof tag];
@@ -60,12 +60,6 @@
     return std::string(chars, sizeof(chars));
   }
 
-  if (!GetQuicReloadableFlag(quic_print_tag_hex)) {
-    return QuicTextUtils::Uint64ToString(orig_tag);
-  }
-
-  QUIC_RELOADABLE_FLAG_COUNT(quic_print_tag_hex);
-
   return QuicTextUtils::HexEncode(reinterpret_cast<const char*>(&orig_tag),
                                   sizeof(orig_tag));
 }

quic/core/quic_tag_test.cc

diff --git a/quic/core/quic_tag_test.cc b/quic/core/quic_tag_test.cc
index 20af4ee..3d58133 100644
--- a/quic/core/quic_tag_test.cc
+++ b/quic/core/quic_tag_test.cc
@@ -19,10 +19,6 @@
   EXPECT_EQ("SNO ", QuicTagToString(kServerNonceTag));
   EXPECT_EQ("CRT ", QuicTagToString(kCertificateTag));
   EXPECT_EQ("CHLO", QuicTagToString(MakeQuicTag('C', 'H', 'L', 'O')));
-  if (!GetQuicReloadableFlag(quic_print_tag_hex)) {
-    EXPECT_EQ("525092931", QuicTagToString(MakeQuicTag('C', 'H', 'L', '\x1f')));
-    return;
-  }
   // A tag that contains a non-printing character will be printed as hex.
   EXPECT_EQ("43484c1f", QuicTagToString(MakeQuicTag('C', 'H', 'L', '\x1f')));
 }

quic/core/quic_versions.cc

diff --git a/quic/core/quic_versions.cc b/quic/core/quic_versions.cc
index 1989e98..b85a13e 100644
--- a/quic/core/quic_versions.cc
+++ b/quic/core/quic_versions.cc
@@ -434,7 +434,6 @@
   SetQuicReloadableFlag(quic_use_uber_loss_algorithm, true);
   SetQuicReloadableFlag(quic_use_uber_received_packet_manager, true);
   SetQuicReloadableFlag(quic_validate_packet_number_post_decryption, true);
-  SetQuicReloadableFlag(quic_print_tag_hex, true);
   SetQuicReloadableFlag(quic_send_version_negotiation_fixed_bit, true);
   SetQuicReloadableFlag(quic_no_client_conn_ver_negotiation, true);
   SetQuicReloadableFlag(quic_eliminate_static_stream_map_3, true);