commit c9c6d587db0f80122167b13c6a251f679b397ae6
author wub <wub@google.com> Mon Jul 20 08:45:40 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Mon Jul 20 08:46:24 2020 -0700
tree 4a975d8719147f94b1593d24067c40786aaad310
parent b3359b0b014d81e6986700478969af146e025155

Deprecate --gfe2_reloadable_flag_quic_avoid_leak_writer_buffer.

PiperOrigin-RevId: 322151857
Change-Id: Ie85db746d5ff06ca3b7ad53d2b83620d148af1c8

quic/core/quic_packet_creator.cc

diff --git a/quic/core/quic_packet_creator.cc b/quic/core/quic_packet_creator.cc
index 131ef5e..a0f189c 100644
--- a/quic/core/quic_packet_creator.cc
+++ b/quic/core/quic_packet_creator.cc
@@ -469,14 +469,6 @@
   QUIC_CACHELINE_ALIGNED char stack_buffer[kMaxOutgoingPacketSize];
   QuicOwnedPacketBuffer external_buffer(delegate_->GetPacketBuffer());
 
-  if (!avoid_leak_writer_buffer_ && external_buffer.release_buffer != nullptr) {
-    // This is not a flag count because it is incremented when flag is false.
-    QUIC_CODE_COUNT(quic_avoid_leak_writer_buffer_flag_false_noop_1);
-
-    // Setting it to nullptr to keep the behavior unchanged when flag is false.
-    external_buffer.release_buffer = nullptr;
-  }
-
   if (external_buffer.buffer == nullptr) {
     external_buffer.buffer = stack_buffer;
     external_buffer.release_buffer = nullptr;
@@ -510,12 +502,9 @@
   packet_.encrypted_buffer = nullptr;
   packet_.encrypted_length = 0;
   packet_.fate = SEND_TO_WRITER;
-  if (avoid_leak_writer_buffer_) {
-    QUIC_RELOADABLE_FLAG_COUNT_N(quic_avoid_leak_writer_buffer, 2, 3);
-    QUIC_BUG_IF(packet_.release_encrypted_buffer != nullptr)
-        << "packet_.release_encrypted_buffer should be empty";
-    packet_.release_encrypted_buffer = nullptr;
-  }
+  QUIC_BUG_IF(packet_.release_encrypted_buffer != nullptr)
+      << "packet_.release_encrypted_buffer should be empty";
+  packet_.release_encrypted_buffer = nullptr;
   DCHECK(packet_.retransmittable_frames.empty());
   DCHECK(packet_.nonretransmittable_frames.empty());
   packet_.largest_acked.Clear();
@@ -594,14 +583,6 @@
   QUIC_CACHELINE_ALIGNED char stack_buffer[kMaxOutgoingPacketSize];
   QuicOwnedPacketBuffer packet_buffer(delegate_->GetPacketBuffer());
 
-  if (!avoid_leak_writer_buffer_ && packet_buffer.release_buffer != nullptr) {
-    // This is not a flag count because it is incremented when flag is false.
-    QUIC_CODE_COUNT(quic_avoid_leak_writer_buffer_flag_false_noop_2);
-
-    // Setting it to nullptr to keep the behavior unchanged when flag is false.
-    packet_buffer.release_buffer = nullptr;
-  }
-
   if (packet_buffer.buffer == nullptr) {
     packet_buffer.buffer = stack_buffer;
     packet_buffer.release_buffer = nullptr;
@@ -692,15 +673,10 @@
   packet_size_ = 0;
   packet_.encrypted_buffer = encrypted_buffer;
   packet_.encrypted_length = encrypted_length;
-  if (avoid_leak_writer_buffer_) {
-    QUIC_RELOADABLE_FLAG_COUNT_N(quic_avoid_leak_writer_buffer, 3, 3);
-    packet_buffer.buffer = nullptr;
-    packet_.release_encrypted_buffer = std::move(packet_buffer).release_buffer;
-  } else {
-    // If flag --quic_avoid_leak_writer_buffer is false, the release function
-    // should be empty.
-    DCHECK(packet_buffer.release_buffer == nullptr);
-  }
+
+  packet_buffer.buffer = nullptr;
+  packet_.release_encrypted_buffer = std::move(packet_buffer).release_buffer;
+
   packet_.retransmittable_frames.push_back(QuicFrame(frame));
   OnSerializedPacket();
 }
@@ -850,16 +826,9 @@
   queued_frames_.clear();
   packet_.encrypted_buffer = encrypted_buffer.buffer;
   packet_.encrypted_length = encrypted_length;
-  if (avoid_leak_writer_buffer_) {
-    QUIC_RELOADABLE_FLAG_COUNT_N(quic_avoid_leak_writer_buffer, 1, 3);
-    encrypted_buffer.buffer = nullptr;
-    packet_.release_encrypted_buffer =
-        std::move(encrypted_buffer).release_buffer;
-  } else {
-    // If flag --quic_avoid_leak_writer_buffer is false, the release function
-    // should be empty.
-    DCHECK(encrypted_buffer.release_buffer == nullptr);
-  }
+
+  encrypted_buffer.buffer = nullptr;
+  packet_.release_encrypted_buffer = std::move(encrypted_buffer).release_buffer;
 }
 
 std::unique_ptr<QuicEncryptedPacket>