commit c39b6e54505b8ba2f08203122f260fc91f4d3781
author vasilvv <vasilvv@google.com> Tue Mar 16 17:42:41 2021 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Mar 16 17:43:23 2021 -0700
tree 1b1f9951d6a420f0d730f992e6906b4adc31c7b1
parent 60aff8240a8da1341d5d63f51ab0575b2c0849b4

Add some DCHECKs into WebTransportHttp3 constructor.

This is mostly to make the compiler warning about unused variables go away for now.

PiperOrigin-RevId: 363309734
Change-Id: I884d95c52d453f39716020dd861271fe24310af8

quic/core/http/web_transport_http3.cc

diff --git a/quic/core/http/web_transport_http3.cc b/quic/core/http/web_transport_http3.cc
index 0c7c9a8..da77200 100644
--- a/quic/core/http/web_transport_http3.cc
+++ b/quic/core/http/web_transport_http3.cc
@@ -8,6 +8,8 @@
 
 #include "quic/core/http/quic_spdy_session.h"
 #include "quic/core/http/quic_spdy_stream.h"
+#include "quic/core/quic_utils.h"
+#include "common/platform/api/quiche_logging.h"
 
 namespace quic {
 
@@ -28,7 +30,11 @@
     : session_(session),
       connect_stream_(connect_stream),
       id_(id),
-      visitor_(std::make_unique<NoopWebTransportVisitor>()) {}
+      visitor_(std::make_unique<NoopWebTransportVisitor>()) {
+  QUICHE_DCHECK(session_->SupportsWebTransport());
+  QUICHE_DCHECK(IsValidWebTransportSessionId(id, session_->version()));
+  QUICHE_DCHECK_EQ(connect_stream_->id(), id);
+}
 
 void WebTransportHttp3::HeadersReceived(
     const spdy::SpdyHeaderBlock& /*headers*/) {

quic/core/http/web_transport_http3.h

diff --git a/quic/core/http/web_transport_http3.h b/quic/core/http/web_transport_http3.h
index 7176411..b2da0ed 100644
--- a/quic/core/http/web_transport_http3.h
+++ b/quic/core/http/web_transport_http3.h
@@ -49,8 +49,8 @@
   void SetDatagramMaxTimeInQueue(QuicTime::Delta max_time_in_queue) override;
 
  private:
-  const QuicSpdySession* session_;        // Unowned.
-  const QuicSpdyStream* connect_stream_;  // Unowned.
+  QuicSpdySession* const session_;        // Unowned.
+  QuicSpdyStream* const connect_stream_;  // Unowned.
   const WebTransportSessionId id_;
   // |ready_| is set to true when the peer has seen both sets of headers.
   bool ready_ = false;