commit bcf4072b32f2acc3fbab6049066f749756d6ac65
author dschinazi <dschinazi@google.com> Wed Apr 20 03:35:18 2022 -0700
committer Copybara-Service <copybara-worker@google.com> Wed Apr 20 03:36:04 2022 -0700
tree b8a81cc3e7c6e8f570f9284c8000f8e14b352bc9
parent 376d10d0af62400b02c6e5e2bfe5b1aefac66625

Remove support for CONNECT-FOO methods

This was added in the early MASQUE days when were going to use CONNECT-UDP, but now the working group has decided to instead use extended CONNECT so we can remove this code.

This is not flag protected because QuicSimpleServerStream is not used in production.

PiperOrigin-RevId: 443050223

quiche/quic/tools/quic_simple_server_stream.cc

diff --git a/quiche/quic/tools/quic_simple_server_stream.cc b/quiche/quic/tools/quic_simple_server_stream.cc
index 91f91d3..909b709 100644
--- a/quiche/quic/tools/quic_simple_server_stream.cc
+++ b/quiche/quic/tools/quic_simple_server_stream.cc
@@ -7,7 +7,6 @@
 #include <list>
 #include <utility>
 
-#include "absl/strings/match.h"
 #include "absl/strings/numbers.h"
 #include "absl/strings/str_cat.h"
 #include "absl/strings/string_view.h"
@@ -62,12 +61,12 @@
   }
   ConsumeHeaderList();
   if (!fin && !response_sent_) {
-    // CONNECT and other CONNECT-like methods (such as CONNECT-UDP) require
-    // sending the response right after parsing the headers even though the FIN
-    // bit has not been received on the request stream.
+    // CONNECT requests do not carry any message content but carry data after
+    // the headers, so they require sending the response right after parsing the
+    // headers even though the FIN bit has not been received on the request
+    // stream.
     auto it = request_headers_.find(":method");
-    if (it != request_headers_.end() &&
-        absl::StartsWith(it->second, "CONNECT")) {
+    if (it != request_headers_.end() && it->second == "CONNECT") {
       SendResponse();
     }
   }
@@ -156,11 +155,9 @@
   }
 
   if (!request_headers_.contains(":path")) {
-    // CONNECT and other CONNECT-like methods (such as CONNECT-UDP) do not all
-    // require :path to be present.
+    // The CONNECT method does not require :path to be present.
     auto it = request_headers_.find(":method");
-    if (it == request_headers_.end() ||
-        !absl::StartsWith(it->second, "CONNECT")) {
+    if (it == request_headers_.end() || it->second != "CONNECT") {
       QUIC_DVLOG(1) << "Request headers do not contain :path.";
       SendErrorResponse();
       return;