commit bb2e22aa90f14415a598e9a6cc6f3b8108e4b4c3
author renjietang <renjietang@google.com> Thu Sep 12 15:46:39 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Fri Sep 13 10:55:02 2019 -0700
tree f3ef23482332ece155ce51c8f7ec127de0791ef8
parent c5589bd906d94db549f9fe0dee414264d2284ff9

Re-enable tests that were blocked by TLS not setting initial connection flow control window.

Note that this CL doesn't re-enable all tests that are blocked by TLS. Some tests still need investigation on the reason of failure.

gfe-relnote: test change only, not protected.
PiperOrigin-RevId: 268784273
Change-Id: I8f206aa0e32687a3e7613dd14aab7b540fbdf5ff

quic/core/qpack/qpack_send_stream_test.cc

diff --git a/quic/core/qpack/qpack_send_stream_test.cc b/quic/core/qpack/qpack_send_stream_test.cc
index 8431afc..241c0c5 100644
--- a/quic/core/qpack/qpack_send_stream_test.cc
+++ b/quic/core/qpack/qpack_send_stream_test.cc
@@ -6,6 +6,7 @@
 
 #include "net/third_party/quiche/src/quic/core/http/http_constants.h"
 #include "net/third_party/quiche/src/quic/platform/api/quic_test.h"
+#include "net/third_party/quiche/src/quic/test_tools/quic_config_peer.h"
 #include "net/third_party/quiche/src/quic/test_tools/quic_spdy_session_peer.h"
 #include "net/third_party/quiche/src/quic/test_tools/quic_test_utils.h"
 
@@ -56,6 +57,11 @@
             SupportedVersions(GetParam().version))),
         session_(connection_) {
     session_.Initialize();
+    QuicConfigPeer::SetReceivedInitialSessionFlowControlWindow(
+        session_.config(), kMinimumFlowControlSendWindow);
+    QuicConfigPeer::SetReceivedMaxIncomingUnidirectionalStreams(
+        session_.config(), 3);
+    session_.OnConfigNegotiated();
 
     qpack_send_stream_ =
         QuicSpdySessionPeer::GetQpackDecoderSendStream(&session_);
@@ -78,11 +84,6 @@
                          ::testing::ValuesIn(GetTestParams()));
 
 TEST_P(QpackSendStreamTest, WriteStreamTypeOnlyFirstTime) {
-  if (GetParam().version.handshake_protocol == PROTOCOL_TLS1_3) {
-    // TODO(nharper, b/112643533): Figure out why this test fails when TLS is
-    // enabled and fix it.
-    return;
-  }
   std::string data = "data";
   EXPECT_CALL(session_, WritevData(_, _, 1, _, _));
   EXPECT_CALL(session_, WritevData(_, _, data.length(), _, _));