commit bb1c489f45c520ec911a1231aebe53bfead85598
author renjietang <renjietang@google.com> Fri May 24 15:58:44 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Tue May 28 17:46:31 2019 -0700
tree 239e81961a2050638647e5d89a6e3c24dd5ba98d
parent 6810fb56da4d57a173418befc8bf4b9358497343

Support HTTP/3 style of Server push.

Server push stream now has stream type of 0x01 encoded as variable length integer. It will be sent along with the first stream write. And the peer will open the incoming stream once the stream type byte is received.

Pending stream is enabled in this CL.

gfe-relnote: version 99 only. Not in production.
PiperOrigin-RevId: 249914001
Change-Id: I291d1cc98ce44f930722608f82f9829da033c213

quic/core/quic_session.cc

diff --git a/quic/core/quic_session.cc b/quic/core/quic_session.cc
index f605e56..89e08ef 100644
--- a/quic/core/quic_session.cc
+++ b/quic/core/quic_session.cc
@@ -157,7 +157,7 @@
 }
 
 void QuicSession::PendingStreamOnStreamFrame(const QuicStreamFrame& frame) {
-  DCHECK(VersionHasControlStreams(connection()->transport_version()));
+  DCHECK(VersionHasStreamType(connection()->transport_version()));
   QuicStreamId stream_id = frame.stream_id;
 
   PendingStream* pending = GetOrCreatePendingStream(stream_id);
@@ -171,7 +171,12 @@
   }
 
   pending->OnStreamFrame(frame);
-  ProcessPendingStream(pending);
+  if (ProcessPendingStream(pending)) {
+    // The pending stream should now be in the scope of normal streams.
+    DCHECK(IsClosedStream(stream_id) || IsOpenStream(stream_id))
+        << "Stream " << stream_id << " not created";
+    pending_stream_map_.erase(stream_id);
+  }
 }
 
 void QuicSession::OnStreamFrame(const QuicStreamFrame& frame) {
@@ -192,7 +197,7 @@
     return;
   }
 
-  if (VersionHasControlStreams(connection()->transport_version()) &&
+  if (VersionHasStreamType(connection()->transport_version()) &&
       UsesPendingStreams() &&
       QuicUtils::GetStreamType(stream_id, perspective(),
                                IsIncomingStream(stream_id)) ==
@@ -327,7 +332,7 @@
 }
 
 void QuicSession::PendingStreamOnRstStream(const QuicRstStreamFrame& frame) {
-  DCHECK(VersionHasControlStreams(connection()->transport_version()));
+  DCHECK(VersionHasStreamType(connection()->transport_version()));
   QuicStreamId stream_id = frame.stream_id;
 
   PendingStream* pending = GetOrCreatePendingStream(stream_id);
@@ -362,7 +367,7 @@
     visitor_->OnRstStreamReceived(frame);
   }
 
-  if (VersionHasControlStreams(connection()->transport_version()) &&
+  if (VersionHasStreamType(connection()->transport_version()) &&
       UsesPendingStreams() &&
       QuicUtils::GetStreamType(stream_id, perspective(),
                                IsIncomingStream(stream_id)) ==