Remove redundant VersionSupportsGoogleAltSvcFormat.
The function VersionSupportsGoogleAltSvcFormat is equivalent to !VersionIsIetfQuic. This change removes the redundant function and updates its call sites to use !VersionIsIetfQuic or VersionIsIetfQuic as appropriate.
Also remove deprecated functions that have been fully removed from the codebase.
PiperOrigin-RevId: 834517818
diff --git a/quiche/quic/core/quic_versions.cc b/quiche/quic/core/quic_versions.cc
index dc53534..c526e2a 100644
--- a/quiche/quic/core/quic_versions.cc
+++ b/quiche/quic/core/quic_versions.cc
@@ -76,11 +76,6 @@
return IsIetfQuic();
}
-bool ParsedQuicVersion::HasIetfQuicFrames() const {
- QUICHE_DCHECK(IsKnown());
- return IsIetfQuic();
-}
-
bool ParsedQuicVersion::UsesLegacyTlsExtension() const {
QUICHE_DCHECK(IsKnown());
return transport_version == QUIC_VERSION_IETF_DRAFT_29;
@@ -504,10 +499,6 @@
return result;
}
-bool VersionSupportsGoogleAltSvcFormat(QuicTransportVersion transport_version) {
- return transport_version <= QUIC_VERSION_46;
-}
-
bool QuicVersionLabelUses4BitConnectionIdLength(
QuicVersionLabel version_label) {
// As we deprecate old versions, we still need the ability to send valid
diff --git a/quiche/quic/core/quic_versions.h b/quiche/quic/core/quic_versions.h
index d4b35c6..371c0c5 100644
--- a/quiche/quic/core/quic_versions.h
+++ b/quiche/quic/core/quic_versions.h
@@ -288,15 +288,11 @@
// Envoy.
bool UsesHttp3() const;
- // TODO(martinduke): Remove this function when it has been deleted from
- // external callers.
- bool HasIetfQuicFrames() const;
-
// Returns whether this version uses the legacy TLS extension codepoint.
bool UsesLegacyTlsExtension() const;
// TODO(martinduke): Remove this function when it has been deleted from
- // Envoy and internal callers.
+ // Envoy.
bool UsesTls() const;
// Returns whether this version uses the QUICv2 Long Header Packet Types.
@@ -501,18 +497,6 @@
std::numeric_limits<size_t>::max());
}
-// TODO(martinduke): Remove this function when it has been deleted from
-// external callers.
-QUICHE_EXPORT constexpr bool VersionHasIetfQuicFrames(
- QuicTransportVersion transport_version) {
- return VersionIsIetfQuic(transport_version);
-}
-
-// Returns true if this version supports the old Google-style Alt-Svc
-// advertisement format.
-QUICHE_EXPORT bool VersionSupportsGoogleAltSvcFormat(
- QuicTransportVersion transport_version);
-
// Returns whether this version label supports long header 4-bit encoded
// connection ID lengths as described in draft-ietf-quic-invariants-05 and
// draft-ietf-quic-transport-21.
