Deprecate gfe2_reloadable_flag_quic_retransmit_handshake_data_early. PiperOrigin-RevId: 328398697 Change-Id: I33175a557b7a1d9b2291903c356d08e0f460d855
diff --git a/quic/core/quic_connection.cc b/quic/core/quic_connection.cc index 4677258..f0769fd 100644 --- a/quic/core/quic_connection.cc +++ b/quic/core/quic_connection.cc
@@ -4318,23 +4318,15 @@ void QuicConnection::MaybeBundleCryptoDataWithAcks() { DCHECK(SupportsMultiplePacketNumberSpaces()); - if (GetQuicReloadableFlag(quic_retransmit_handshake_data_early) && - IsHandshakeConfirmed()) { + if (IsHandshakeConfirmed()) { return; } PacketNumberSpace space = HANDSHAKE_DATA; - if (perspective() == Perspective::IS_SERVER) { - // On the server side, sends INITIAL data with INITIAL ACK. On the client - // side, sends HANDSHAKE data (containing client Finished) with HANDSHAKE - // ACK. + if (perspective() == Perspective::IS_SERVER && + framer_.HasEncrypterOfEncryptionLevel(ENCRYPTION_INITIAL)) { + // On the server side, sends INITIAL data with INITIAL ACK if initial key is + // available. space = INITIAL_DATA; - if (GetQuicReloadableFlag(quic_retransmit_handshake_data_early)) { - QUIC_RELOADABLE_FLAG_COUNT(quic_retransmit_handshake_data_early); - if (!framer_.HasEncrypterOfEncryptionLevel(ENCRYPTION_INITIAL)) { - // Retransmit HANDSHAKE data early. - space = HANDSHAKE_DATA; - } - } } const QuicTime ack_timeout = uber_received_packet_manager_.GetAckTimeout(space);
diff --git a/quic/core/quic_connection_test.cc b/quic/core/quic_connection_test.cc index 3dd3cc2..0f1a8dc 100644 --- a/quic/core/quic_connection_test.cc +++ b/quic/core/quic_connection_test.cc
@@ -11442,12 +11442,8 @@ clock_.AdvanceTime(kAlarmGranularity); connection_.GetAckAlarm()->Fire(); EXPECT_FALSE(writer_->ack_frames().empty()); - if (GetQuicReloadableFlag(quic_retransmit_handshake_data_early)) { - // Verify handshake data gets retransmitted early. - EXPECT_FALSE(writer_->crypto_frames().empty()); - } else { - EXPECT_TRUE(writer_->crypto_frames().empty()); - } + // Verify handshake data gets retransmitted early. + EXPECT_FALSE(writer_->crypto_frames().empty()); } // Regression test for b/161228202