commit b932f95f81e3aa2f2d45c750094a304cacfca60c
author renjietang <renjietang@google.com> Fri Jun 28 11:33:11 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Jul 02 19:29:55 2019 -0700
tree 821bbb4b9d0ea6914b7bd34918938a7e7df78d8a
parent 8aadca75db6ac08c8ec0dabe30b668e34713c08f

Create a new interface called QpackStreamReceiver and make
Qpack(Decoder/Encoder)StreamReceiver derive from it.

The new interface will be used in QpackReceiveStream to decode data.

gfe-relnote: v99 only, not used in prod.
PiperOrigin-RevId: 255638066
Change-Id: I6bf86f356e49f2846e63b2fa422a7e1e59e7a800

quic/core/qpack/qpack_encoder_stream_receiver.h

diff --git a/quic/core/qpack/qpack_encoder_stream_receiver.h b/quic/core/qpack/qpack_encoder_stream_receiver.h
index 5519b4c..8da3147 100644
--- a/quic/core/qpack/qpack_encoder_stream_receiver.h
+++ b/quic/core/qpack/qpack_encoder_stream_receiver.h
@@ -9,6 +9,7 @@
 #include <string>
 
 #include "net/third_party/quiche/src/quic/core/qpack/qpack_instruction_decoder.h"
+#include "net/third_party/quiche/src/quic/core/qpack/qpack_stream_receiver.h"
 #include "net/third_party/quiche/src/quic/platform/api/quic_export.h"
 #include "net/third_party/quiche/src/quic/platform/api/quic_string_piece.h"
 
@@ -16,7 +17,8 @@
 
 // This class decodes data received on the encoder stream.
 class QUIC_EXPORT_PRIVATE QpackEncoderStreamReceiver
-    : public QpackInstructionDecoder::Delegate {
+    : public QpackInstructionDecoder::Delegate,
+      public QpackStreamReceiver {
  public:
   // An interface for handling instructions decoded from the encoder stream, see
   // https://quicwg.org/base-drafts/draft-ietf-quic-qpack.html#rfc.section.5.2
@@ -46,10 +48,11 @@
       delete;
   ~QpackEncoderStreamReceiver() override = default;
 
+  // Implements QpackStreamReceiver::Decode().
   // Decode data and call appropriate Delegate method after each decoded
   // instruction.  Once an error occurs, Delegate::OnErrorDetected() is called,
   // and all further data is ignored.
-  void Decode(QuicStringPiece data);
+  void Decode(QuicStringPiece data) override;
 
   // QpackInstructionDecoder::Delegate implementation.
   bool OnInstructionDecoded(const QpackInstruction* instruction) override;