commit b8f83440913646db362d25591c60d2b31a39de04
author fayang <fayang@google.com> Mon Jun 01 12:09:17 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Mon Jun 01 12:09:49 2020 -0700
tree 8ff50e1db4132fde6a108ac273565051adcb717c
parent 8b2f28cf571d448e9c3422d47487d8622b4ffccb

Deprecate gfe2_reloadable_flag_quic_break_session_stream_close_loop.

Also inline CloseStreamInner.

PiperOrigin-RevId: 314176674
Change-Id: Iad90f3607bac0204b047f1c455d824b8ddfc84b8

quic/core/quic_stream.h

diff --git a/quic/core/quic_stream.h b/quic/core/quic_stream.h
index 930fd17..80b2fb0 100644
--- a/quic/core/quic_stream.h
+++ b/quic/core/quic_stream.h
@@ -165,14 +165,6 @@
   // stream to write any pending data.
   virtual void OnCanWrite();
 
-  // Called just before the object is destroyed.
-  // The object should not be accessed after OnClose is called.
-  // Sends a RST_STREAM with code QUIC_RST_ACKNOWLEDGEMENT if neither a FIN nor
-  // a RST_STREAM has been sent.
-  // TODO(fayang): move this to protected when deprecating
-  // quic_break_session_stream_close_loop.
-  virtual void OnClose();
-
   // Called by the session when the endpoint receives a RST_STREAM from the
   // peer.
   virtual void OnStreamReset(const QuicRstStreamFrame& frame);
@@ -381,6 +373,12 @@
       const QuicReferenceCountedPointer<QuicAckListenerInterface>&
       /*ack_listener*/) {}
 
+  // Called just before the object is destroyed.
+  // The object should not be accessed after OnClose is called.
+  // Sends a RST_STREAM with code QUIC_RST_ACKNOWLEDGEMENT if neither a FIN nor
+  // a RST_STREAM has been sent.
+  virtual void OnClose();
+
   // True if buffered data in send buffer is below buffered_data_threshold_.
   bool CanWriteNewData() const;