commit | b402517c01d42d3930b8add316ae6d74b9712cbd | [log] [tgz] |
---|---|---|
author | bnc <bnc@google.com> | Fri Jul 12 18:09:59 2019 -0700 |
committer | Copybara-Service <copybara-worker@google.com> | Fri Jul 12 18:12:01 2019 -0700 |
tree | 0ad50e35cd1bb97b63d15501adb6fbf70c4e6ea1 | |
parent | 1ad8dc6e917d8df681cf341f8fbb938fa584dace [diff] |
Use HpackEntry::Size() instead of rolling our own in QpackDynamicTable. (Note that QpackEntry is an alias for HpackEntry.) I'm a little uncomfortable with HpackEntry::Size() returning size_t instead of uint64_t, because Chromium supports platforms where size_t is uint32_t and sometimes funny things happen, especially with UBSAN around type conversions. The reason for returning size_t is that is string_view::size_type and std::string::size_type. In practice we'll never deal with long strings so this should really not be a problem. This came up because I will need to access EntrySize() from outside QpackHeaderTable and it makes more sense to use HpackEntry::Size() consistently then to make EntrySize() public. gfe-relnote: n/a, QUIC v99-only code. PiperOrigin-RevId: 257903243 Change-Id: I354ffb46a9a6d7e2e4f2ba2d581115f6c0f4cfd5
QUICHE (QUIC, Http/2, Etc) is Google‘s implementation of QUIC and related protocols. It powers Chromium as well as Google’s QUIC servers and some other projects.
The code is currently in process of being moved from https://cs.chromium.org/chromium/src/net/third_party/ into this repository. Please excuse our appearance while we're under construction.