Save large connection IDs on the heap
The IETF will soon increase the maximum size of connection IDs, this change allows us to scale that by placing large ones on the heap.
gfe-relnote: change representation of connection IDs, protected by quic_use_allocated_connection_ids
PiperOrigin-RevId: 252524833
Change-Id: Ia98aee46adebbe6f5f3df2a4c0062a54a22e2d0d
diff --git a/quic/core/quic_connection_id_test.cc b/quic/core/quic_connection_id_test.cc
index bbe04f9..1d290fc 100644
--- a/quic/core/quic_connection_id_test.cc
+++ b/quic/core/quic_connection_id_test.cc
@@ -91,6 +91,53 @@
EXPECT_NE(connection_id64_2.Hash(), connection_id64_3.Hash());
}
+TEST_F(QuicConnectionIdTest, AssignAndCopy) {
+ QuicConnectionId connection_id = test::TestConnectionId(1);
+ QuicConnectionId connection_id2 = test::TestConnectionId(2);
+ connection_id = connection_id2;
+ EXPECT_EQ(connection_id, test::TestConnectionId(2));
+ EXPECT_NE(connection_id, test::TestConnectionId(1));
+ connection_id = QuicConnectionId(test::TestConnectionId(1));
+ EXPECT_EQ(connection_id, test::TestConnectionId(1));
+ EXPECT_NE(connection_id, test::TestConnectionId(2));
+}
+
+TEST_F(QuicConnectionIdTest, ChangeLength) {
+ QuicConnectionId connection_id64_1 = test::TestConnectionId(1);
+ QuicConnectionId connection_id64_2 = test::TestConnectionId(2);
+ QuicConnectionId connection_id136_2 = test::TestConnectionId(2);
+ connection_id136_2.set_length(17);
+ memset(connection_id136_2.mutable_data() + 8, 0, 9);
+ char connection_id136_2_bytes[17] = {0, 0, 0, 0, 0, 0, 0, 2, 0,
+ 0, 0, 0, 0, 0, 0, 0, 0};
+ QuicConnectionId connection_id136_2b(connection_id136_2_bytes,
+ sizeof(connection_id136_2_bytes));
+ EXPECT_EQ(connection_id136_2, connection_id136_2b);
+ QuicConnectionId connection_id = connection_id64_1;
+ connection_id.set_length(17);
+ EXPECT_NE(connection_id64_1, connection_id);
+ // Check resizing big to small.
+ connection_id.set_length(8);
+ EXPECT_EQ(connection_id64_1, connection_id);
+ // Check resizing small to big.
+ connection_id.set_length(17);
+ memset(connection_id.mutable_data(), 0, connection_id.length());
+ memcpy(connection_id.mutable_data(), connection_id64_2.data(),
+ connection_id64_2.length());
+ EXPECT_EQ(connection_id136_2, connection_id);
+ EXPECT_EQ(connection_id136_2b, connection_id);
+ QuicConnectionId connection_id120(connection_id136_2_bytes, 15);
+ connection_id.set_length(15);
+ EXPECT_EQ(connection_id120, connection_id);
+ // Check resizing big to big.
+ QuicConnectionId connection_id2 = connection_id120;
+ connection_id2.set_length(17);
+ connection_id2.mutable_data()[15] = 0;
+ connection_id2.mutable_data()[16] = 0;
+ EXPECT_EQ(connection_id136_2, connection_id2);
+ EXPECT_EQ(connection_id136_2b, connection_id2);
+}
+
} // namespace
} // namespace quic
