commit abb01bf63553ead53c318f8586e649ebe26fb458
author dmcardle <dmcardle@google.com> Tue Sep 23 11:58:01 2025 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Sep 23 11:58:46 2025 -0700
tree e011ac07aa9d65f89e1ead099a9ec2ab6f91dd62
parent 36cd272ac3b50673d61208a46603f4d467b1669b

Add a FUZZ_TEST for ParseTransportParameters()

It would be nice to also fuzz SerializeTransportParameters(), but it has some undocumented requirements on the input that trigger QUIC_BUGs.

PiperOrigin-RevId: 810527578

quiche/quic/core/crypto/transport_parameters_test.cc

diff --git a/quiche/quic/core/crypto/transport_parameters_test.cc b/quiche/quic/core/crypto/transport_parameters_test.cc
index e314ede..04f3311 100644
--- a/quiche/quic/core/crypto/transport_parameters_test.cc
+++ b/quiche/quic/core/crypto/transport_parameters_test.cc
@@ -4,6 +4,7 @@
 
 #include "quiche/quic/core/crypto/transport_parameters.h"
 
+#include <cstdint>
 #include <cstring>
 #include <memory>
 #include <optional>
@@ -21,8 +22,10 @@
 #include "quiche/quic/core/quic_versions.h"
 #include "quiche/quic/platform/api/quic_expect_bug.h"
 #include "quiche/quic/platform/api/quic_ip_address.h"
+#include "quiche/quic/platform/api/quic_socket_address.h"
 #include "quiche/quic/platform/api/quic_test.h"
 #include "quiche/quic/test_tools/quic_test_utils.h"
+#include "quiche/common/platform/api/quiche_fuzztest.h"
 
 namespace quic {
 namespace test {
@@ -161,8 +164,6 @@
   }
 }
 
-}  // namespace
-
 class TransportParametersTest : public QuicTestWithParam<ParsedQuicVersion> {
  protected:
   TransportParametersTest() : version_(GetParam()) {}
@@ -1226,5 +1227,21 @@
   EXPECT_NE(original_serialized_params_, serialized);
 }
 
+void ParseTransportParametersDoesNotCrash(ParsedQuicVersion version,
+                                          Perspective perspective,
+                                          const std::vector<uint8_t>& data) {
+  TransportParameters params;
+  std::string error_details;
+  (void)ParseTransportParameters(version, perspective, data.data(), data.size(),
+                                 &params, &error_details);
+}
+
+FUZZ_TEST(TransportParametersFuzzTest, ParseTransportParametersDoesNotCrash)
+    .WithDomains(fuzztest::ElementOf(AllSupportedVersions()),
+                 fuzztest::ElementOf({Perspective::IS_CLIENT,
+                                      Perspective::IS_SERVER}),
+                 fuzztest::Arbitrary<std::vector<uint8_t>>());
+
+}  // namespace
 }  // namespace test
 }  // namespace quic