LSC: Apply performance-unnecessary-value-param where it matters for performance.
This cl was generated with go/gwp-clang-tidy.
The following lines are helpful in [determining](http://go/gwp-clang-tidy#metrics-summary) the impact of the change:
```
gwp_clang_tidy_metric: 667.275 gcus
gwp_clang_tidy_metric_for_key: 667.275 gcus
gwp_clang_tidy_fn_name: quic::(anonymous namespace)::AppendIetfConnectionIds(bool, bool, quic::QuicConnectionId, quic::QuicConnectionId, quic::QuicDataWriter*)
gwp_clang_tidy_num_overlapping_findings: 6
gwp_clang_tidy_call: quic::QuicFramer::AppendIetfPacketHeader(quic::QuicPacketHeader const&, quic::QuicDataWriter*, unsigned long*) -> quic::QuicConnectionId::QuicConnectionId(quic::QuicConnectionId const&) (590.613 gcus)
gwp_clang_tidy_call: quic::QuicFramer::BuildIetfVersionNegotiationPacket(bool, quic::QuicConnectionId, quic::QuicConnectionId, std::__u::vector<quic::ParsedQuicVersion, std::__u::allocator<quic::ParsedQuicVersion>> const&) -> quic::QuicConnectionId::~QuicConnectionId() (0.0511007 gcus)
gwp_clang_tidy_call: quic::QuicFramer::BuildDataPacket(quic::QuicPacketHeader const&, absl::InlinedVector<quic::QuicFrame, 1ul, std::__u::allocator<quic::QuicFrame>> const&, char*, unsigned long, quic::EncryptionLevel) -> quic::QuicConnectionId::QuicConnectionId(quic::QuicConnectionId const&) (3.16413 gcus)
gwp_clang_tidy_call: quic::QuicFramer::BuildIetfVersionNegotiationPacket(bool, quic::QuicConnectionId, quic::QuicConnectionId, std::__u::vector<quic::ParsedQuicVersion, std::__u::allocator<quic::ParsedQuicVersion>> const&) -> quic::QuicConnectionId::QuicConnectionId(quic::QuicConnectionId const&) (0.215968 gcus)
gwp_clang_tidy_call: quic::QuicFramer::WriteClientVersionNegotiationProbePacket(char*, unsigned long, char const*, unsigned char) -> quic::QuicConnectionId::~QuicConnectionId() (0.0205518 gcus)
gwp_clang_tidy_call: quic::QuicFramer::WriteClientVersionNegotiationProbePacket(char*, unsigned long, char const*, unsigned char) -> quic::QuicConnectionId::QuicConnectionId(quic::QuicConnectionId const&) (0.128068 gcus)
gwp_clang_tidy_call: quic::QuicFramer::AppendIetfPacketHeader(quic::QuicPacketHeader const&, quic::QuicDataWriter*, unsigned long*) -> quic::QuicConnectionId::~QuicConnectionId() (73.0821 gcus)
gwp_clang_tidy_type_name: class quic::QuicConnectionId
gwp_clang_tidy_check: google3-custom-unnecessary-value-param
```
Tested:
http://test/OCL:713980267:BASE:715300728:1736851372677:caa9282b
Some test failures are present; the CL author decided to mail
PiperOrigin-RevId: 715386954
diff --git a/quiche/quic/core/quic_framer.cc b/quiche/quic/core/quic_framer.cc
index 32a54dd..1cddd90 100644
--- a/quiche/quic/core/quic_framer.cc
+++ b/quiche/quic/core/quic_framer.cc
@@ -316,8 +316,8 @@
}
bool AppendIetfConnectionIds(bool version_flag, bool use_length_prefix,
- QuicConnectionId destination_connection_id,
- QuicConnectionId source_connection_id,
+ const QuicConnectionId& destination_connection_id,
+ const QuicConnectionId& source_connection_id,
QuicDataWriter* writer) {
if (!version_flag) {
return writer->WriteConnectionId(destination_connection_id);
