Migration from QUIC_BUG to QUIC_BUG_V2(bug_id).
Per go/gfe-bug-improvements GFE_BUGs are getting stable IDs to allow for monitoring and alerting. Existing QUIC_BUG instances are changed to have `quic_bug_n_m` ID, where `n` is unique for each file, and `m` is a counter within each file, so we get `QUIC_BUG_V2(quic_bug_123_2)`
PiperOrigin-RevId: 361603672
Change-Id: I9dfb1bc8736c6366106b3b4b00426308c993e8d4
diff --git a/quic/core/batch_writer/quic_batch_writer_base.cc b/quic/core/batch_writer/quic_batch_writer_base.cc
index b2fd80c..4f79980 100644
--- a/quic/core/batch_writer/quic_batch_writer_base.cc
+++ b/quic/core/batch_writer/quic_batch_writer_base.cc
@@ -121,10 +121,10 @@
// Since buffered_writes has been emptied, this write must have been
// buffered successfully.
- QUIC_BUG_IF(!buffered) << "Failed to push to an empty batch buffer."
- << " self_addr:" << self_address.ToString()
- << ", peer_addr:" << peer_address.ToString()
- << ", buf_len:" << buf_len;
+ QUIC_BUG_IF_V2(quic_bug_10826_1, !buffered)
+ << "Failed to push to an empty batch buffer."
+ << " self_addr:" << self_address.ToString()
+ << ", peer_addr:" << peer_address.ToString() << ", buf_len:" << buf_len;
}
result.send_time_offset = release_time.release_time_offset;
diff --git a/quic/core/batch_writer/quic_batch_writer_buffer.cc b/quic/core/batch_writer/quic_batch_writer_buffer.cc
index 0de792d..81f8b0a 100644
--- a/quic/core/batch_writer/quic_batch_writer_buffer.cc
+++ b/quic/core/batch_writer/quic_batch_writer_buffer.cc
@@ -75,11 +75,12 @@
} else if (IsInternalBuffer(buffer, buf_len)) {
memmove(next_write_location, buffer, buf_len);
} else {
- QUIC_BUG << "Buffer[" << static_cast<const void*>(buffer) << ", "
- << static_cast<const void*>(buffer + buf_len)
- << ") overlaps with internal buffer["
- << static_cast<const void*>(buffer_) << ", "
- << static_cast<const void*>(buffer_end()) << ")";
+ QUIC_BUG_V2(quic_bug_10831_1)
+ << "Buffer[" << static_cast<const void*>(buffer) << ", "
+ << static_cast<const void*>(buffer + buf_len)
+ << ") overlaps with internal buffer["
+ << static_cast<const void*>(buffer_) << ", "
+ << static_cast<const void*>(buffer_end()) << ")";
return result;
}
result.buffer_copied = true;
diff --git a/quic/core/batch_writer/quic_sendmmsg_batch_writer.cc b/quic/core/batch_writer/quic_sendmmsg_batch_writer.cc
index ec8e4ae..1181d9b 100644
--- a/quic/core/batch_writer/quic_sendmmsg_batch_writer.cc
+++ b/quic/core/batch_writer/quic_sendmmsg_batch_writer.cc
@@ -55,7 +55,8 @@
QUICHE_DCHECK_EQ(0, num_packets_sent);
break;
} else if (num_packets_sent == 0) {
- QUIC_BUG << "WriteMultiplePackets returned OK, but no packets were sent.";
+ QUIC_BUG_V2(quic_bug_10825_1)
+ << "WriteMultiplePackets returned OK, but no packets were sent.";
write_result = WriteResult(WRITE_STATUS_ERROR, EIO);
break;
}
diff --git a/quic/test_tools/simulator/quic_endpoint.cc b/quic/test_tools/simulator/quic_endpoint.cc
index cb0b58e..71f4621 100644
--- a/quic/test_tools/simulator/quic_endpoint.cc
+++ b/quic/test_tools/simulator/quic_endpoint.cc
@@ -228,7 +228,8 @@
QuicStreamOffset /*offset*/,
QuicByteCount /*data_length*/,
QuicDataWriter* /*writer*/) {
- QUIC_BUG << "QuicEndpoint::DataProducer::WriteCryptoData is unimplemented";
+ QUIC_BUG_V2(quic_bug_10157_1)
+ << "QuicEndpoint::DataProducer::WriteCryptoData is unimplemented";
return false;
}
diff --git a/quic/test_tools/simulator/simulator.cc b/quic/test_tools/simulator/simulator.cc
index 8d68ee4..7476b2a 100644
--- a/quic/test_tools/simulator/simulator.cc
+++ b/quic/test_tools/simulator/simulator.cc
@@ -155,10 +155,11 @@
Unschedule(actor);
if (clock_.Now() > event_time) {
- QUIC_BUG << "Error: event registered by [" << actor->name()
- << "] requires travelling back in time. Current time: "
- << clock_.Now().ToDebuggingValue()
- << ", scheduled time: " << event_time.ToDebuggingValue();
+ QUIC_BUG_V2(quic_bug_10150_1)
+ << "Error: event registered by [" << actor->name()
+ << "] requires travelling back in time. Current time: "
+ << clock_.Now().ToDebuggingValue()
+ << ", scheduled time: " << event_time.ToDebuggingValue();
}
clock_.now_ = event_time;
