commit a2b13becc8b429e88feb0b5f09d1b327fb1650cb
author bnc <bnc@google.com> Wed Jul 31 12:04:20 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Fri Aug 02 06:18:51 2019 -0700
tree 4e394facdee32e9ab3d3c6b2cbb3fddd608209bd
parent cefe2b9c5988c9cabae5b557d98d6d67f187c7d3

Remove Http3FrameLengths.

HttpDecoder::Visitor implementations do not make use of the payload length
information, so it can be removed.  (The only exception is
QuicSpdyStream::OnHeadersFrameStart(), but instead
QuicSpdyStream::OnHeadersFramePayload() can easily accumulate payload lengths.)

gfe-relnote: n/a, change to QUIC v99-only code.  Protected by existing disabled gfe2_reloadable_flag_quic_enable_version_99.
PiperOrigin-RevId: 260972901
Change-Id: I95955d7d43791d556fa2f925a86d506197008efd

quic/core/http/http_decoder.cc

diff --git a/quic/core/http/http_decoder.cc b/quic/core/http/http_decoder.cc
index d424c04..550aa6f 100644
--- a/quic/core/http/http_decoder.cc
+++ b/quic/core/http/http_decoder.cc
@@ -133,24 +133,23 @@
   // Calling the following visitor methods does not require parsing of any
   // frame payload.
   bool continue_processing = true;
-  auto frame_meta = Http3FrameLengths(
-      current_length_field_length_ + current_type_field_length_,
-      current_frame_length_);
+  const QuicByteCount header_length =
+      current_length_field_length_ + current_type_field_length_;
 
   switch (current_frame_type_) {
     case static_cast<uint64_t>(HttpFrameType::DATA):
-      continue_processing = visitor_->OnDataFrameStart(frame_meta);
+      continue_processing = visitor_->OnDataFrameStart(header_length);
       break;
     case static_cast<uint64_t>(HttpFrameType::HEADERS):
-      continue_processing = visitor_->OnHeadersFrameStart(frame_meta);
+      continue_processing = visitor_->OnHeadersFrameStart(header_length);
       break;
     case static_cast<uint64_t>(HttpFrameType::PRIORITY):
-      continue_processing = visitor_->OnPriorityFrameStart(frame_meta);
+      continue_processing = visitor_->OnPriorityFrameStart(header_length);
       break;
     case static_cast<uint64_t>(HttpFrameType::CANCEL_PUSH):
       break;
     case static_cast<uint64_t>(HttpFrameType::SETTINGS):
-      continue_processing = visitor_->OnSettingsFrameStart(frame_meta);
+      continue_processing = visitor_->OnSettingsFrameStart(header_length);
       break;
     case static_cast<uint64_t>(HttpFrameType::PUSH_PROMISE):
       break;
@@ -162,7 +161,7 @@
       break;
     default:
       continue_processing =
-          visitor_->OnUnknownFrameStart(current_frame_type_, frame_meta);
+          visitor_->OnUnknownFrameStart(current_frame_type_, header_length);
       break;
   }
 
@@ -228,9 +227,7 @@
         remaining_frame_length_ -= bytes_remaining - reader->BytesRemaining();
         if (!visitor_->OnPushPromiseFrameStart(
                 push_id,
-                Http3FrameLengths(
                     current_length_field_length_ + current_type_field_length_,
-                    current_frame_length_),
                 push_id_length)) {
           continue_processing = false;
           break;