commit 9848247f7238b4194abc0e49d06f2637e3ce5c3c
author bnc <bnc@google.com> Tue Mar 31 10:51:39 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Mar 31 10:52:22 2020 -0700
tree 15778194e2f97527e07e82ff4839ac5f34430578
parent 0abcd8febd32d1f0b833ee190a0d4aa79895db36

gfe-relnote: verify gfe2_reloadable_flag_quic_create_incoming_stream_bug.

2_of_2 code counter is hit billons of times, with not a single hit for 1_of_2,
as expected:

http://trafficmon.prodz.google.com/graphnav?graph_type=dygraph&grid=xtics%20ytics&yformat=%25.1s%25c&ylabel=Rate&duration=1d&format_0=%25job%25%40%25dc%25&expr=%7Bvar%3D%22dc%3Agfe_code_counters%3Asum_rate%22%2Cjob%3D%22%2F.*gfe.*%2F%22%2Cname_of_code_point%3D%22%2F.*gfe2_reloadable_flag_quic_create_incoming_stream_bug.*%2F%22%7D

http://0.trafficmon.master.traffic-monitoring.vl.borg.google.com/r/expr_browser.html#expr=%7Bvar%3D%22dc_code_count%3Acode_counters_total%3Asum%22%2Cjob%3D%22%2F.*_layer1_gfe.*%2F%22%2Cdc%3D%22vl%22%2Cname_of_code_point%3D%22%2F.*gfe2_reloadable_flag_quic_create_incoming_stream_bug.*%2F%22%7D&grid&w=1533&yrange=%5B0%3A%5D

http://0.trafficmon.master.traffic-monitoring.wk.borg.google.com/r/expr_browser.html#expr=%7Bvar%3D%22dc_code_count%3Acode_counters_total%3Asum%22%2Cjob%3D%22%2F.*_layer1_gfe.*%2F%22%2Cdc%3D%22wk%22%2Cname_of_code_point%3D%22%2F.*gfe2_reloadable_flag_quic_create_incoming_stream_bug.*%2F%22%7D&grid&w=1533&yrange=%5B0%3A%5D

PiperOrigin-RevId: 303999833
Change-Id: I6ab7b9e1d50b8dc61311534360cd3cfe8ba37c33

quic/core/http/quic_spdy_client_session.cc

diff --git a/quic/core/http/quic_spdy_client_session.cc b/quic/core/http/quic_spdy_client_session.cc
index 07b9c7a..48d21ea 100644
--- a/quic/core/http/quic_spdy_client_session.cc
+++ b/quic/core/http/quic_spdy_client_session.cc
@@ -136,23 +136,9 @@
     return false;
   }
 
-  if (GetQuicReloadableFlag(quic_create_incoming_stream_bug)) {
-    if (QuicUtils::IsClientInitiatedStreamId(transport_version(), id)) {
-      QUIC_RELOADABLE_FLAG_COUNT_N(quic_create_incoming_stream_bug, 1, 2);
-      QUIC_BUG << "ShouldCreateIncomingStream called with client initiated "
-                  "stream ID.";
-      return false;
-    } else {
-      QUIC_RELOADABLE_FLAG_COUNT_N(quic_create_incoming_stream_bug, 2, 2);
-    }
-  }
-
   if (QuicUtils::IsClientInitiatedStreamId(transport_version(), id)) {
-    QUIC_LOG(WARNING) << "Received invalid push stream id " << id;
-    connection()->CloseConnection(
-        QUIC_INVALID_STREAM_ID,
-        "Server created non write unidirectional stream",
-        ConnectionCloseBehavior::SEND_CONNECTION_CLOSE_PACKET);
+    QUIC_BUG << "ShouldCreateIncomingStream called with client initiated "
+                "stream ID.";
     return false;
   }