| commit | 94d1500be0482e407c32ce92624b846ab49b8399 | [log] [tgz] |
|---|---|---|
| author | dschinazi <dschinazi@google.com> | Fri Apr 16 05:30:49 2021 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Fri Apr 16 05:31:20 2021 -0700 |
| tree | 292d3d3cc2f892b4b6c2b9c5b9554aa23a08e496 | |
| parent | 81e779db54d3d1543e5923112b0dd42253c222c4 [diff] |
Make sure that a low QuicPacketCreator soft limit does not cause issues This issue was causing a DCHECK failure in Envoy QUIC integration tests. In this test, Envoy would receive a QUIC packet and queue up some 1-RTT stream data which would trigger coalescing and set the soft max packet length. Then the code would try to send an initial ack. The issue there is that when switching the encryption level to initial, the header size would increase - and then when trying to add a frame we would trigger a DCHECK in BytesFree because the soft max packet length is lower than the header size. After performing code analysis, it is clear that any caller of BytesFree() properly handles the case where BytesFree() returns 0, so this DCHECK can be safely removed as it provides no value. This CL adds a regression test that would trigger the DCHECK if it were still present. PiperOrigin-RevId: 368828653 Change-Id: I300326dd4e068569f4cec2690002cd4352d2afc2
QUICHE (QUIC, Http/2, Etc) is Google‘s implementation of QUIC and related protocols. It powers Chromium as well as Google’s QUIC servers and some other projects. QUICHE is only supported on little-endian platforms.
Code can be viewed in CodeSearch in Quiche and is imported into Chromium.