| commit | 93ea18dcce59ad0b9b6f36dfa483baefc4310055 | [log] [tgz] |
|---|---|---|
| author | bnc <bnc@google.com> | Thu Aug 22 09:57:43 2019 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Aug 22 10:39:27 2019 -0700 |
| tree | cef32e7ddffeb39d36894ac6ad7350a8de229164 | |
| parent | 8c01622348c679409c945f7839570686bfc33e19 [diff] [blame] |
Signal error on duplicate SETTINGS identifiers. See https://quicwg.org/base-drafts/draft-ietf-quic-http.html#frame-settings, with proposed clarification at https://github.com/quicwg/base-drafts/pull/2979. gfe-relnote: n/a, change to QUIC v99-only code. Protected by existing disabled gfe2_reloadable_flag_quic_enable_version_99. PiperOrigin-RevId: 264857966 Change-Id: I6bcd0f70cb52d897d465fb89f9937ab4a3ea093f
diff --git a/quic/core/http/http_decoder.cc b/quic/core/http/http_decoder.cc index 78f8539..c9519fe 100644 --- a/quic/core/http/http_decoder.cc +++ b/quic/core/http/http_decoder.cc
@@ -565,7 +565,12 @@ "Unable to read settings frame content"); return false; } - frame->values[id] = content; + auto result = frame->values.insert({id, content}); + if (!result.second) { + // TODO(b/124216424): Use HTTP_SETTINGS_ERROR. + RaiseError(QUIC_INVALID_FRAME_DATA, "Duplicate SETTINGS identifier."); + return false; + } } return true; }