commit 8f3a576515ada564d3e2b560220649f49a21dec1
author danzh <danzh@google.com> Tue Jun 25 13:43:51 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Jun 25 13:44:37 2019 -0700
tree fb9d3942ec288a09867eaf99c1f43cf3f57b1efa
parent d9eccf02f36b9318ce98655234f4a927f9b6a289

gfe-relnote: n/a(code clean up) Apply quic compile options to spdy/core
code.

These options are added to enhance cross platfrom compatibility. As spdy is also part of QUICHE, it's good to apply these options as well.
Fix all the violations under third_party/spdy/core.

Platform-ize gunit, gmock and gunit_main

PiperOrigin-RevId: 255038615
Change-Id: I6ad003f68679f8adf4b2582c7dea3b6b950f0acc

spdy/core/spdy_framer_test.cc

diff --git a/spdy/core/spdy_framer_test.cc b/spdy/core/spdy_framer_test.cc
index 0caa160..abca5a7 100644
--- a/spdy/core/spdy_framer_test.cc
+++ b/spdy/core/spdy_framer_test.cc
@@ -12,8 +12,6 @@
 #include <tuple>
 #include <vector>
 
-#include "testing/gmock/include/gmock/gmock.h"
-#include "testing/gtest/include/gtest/gtest.h"
 #include "net/third_party/quiche/src/spdy/core/array_output_buffer.h"
 #include "net/third_party/quiche/src/spdy/core/hpack/hpack_constants.h"
 #include "net/third_party/quiche/src/spdy/core/mock_spdy_framer_visitor.h"
@@ -28,6 +26,7 @@
 #include "net/third_party/quiche/src/spdy/platform/api/spdy_ptr_util.h"
 #include "net/third_party/quiche/src/spdy/platform/api/spdy_string.h"
 #include "net/third_party/quiche/src/spdy/platform/api/spdy_string_utils.h"
+#include "net/third_party/quiche/src/spdy/platform/api/spdy_test.h"
 
 using ::http2::Http2DecoderAdapter;
 using ::testing::_;
@@ -315,14 +314,14 @@
   }
 
   SpdyHeadersHandlerInterface* OnHeaderFrameStart(
-      SpdyStreamId stream_id) override {
+      SpdyStreamId /*stream_id*/) override {
     if (headers_handler_ == nullptr) {
       headers_handler_ = SpdyMakeUnique<TestHeadersHandler>();
     }
     return headers_handler_.get();
   }
 
-  void OnHeaderFrameEnd(SpdyStreamId stream_id) override {
+  void OnHeaderFrameEnd(SpdyStreamId /*stream_id*/) override {
     CHECK(headers_handler_ != nullptr);
     headers_ = headers_handler_->decoded_block().Clone();
     header_bytes_received_ = headers_handler_->header_bytes_parsed();